Bug 1036845

Summary: 'systemctl reload $SERVICE' returns 0 (success) even if ExecReload command returns 1
Product: [Fedora] Fedora Reporter: Arjun Shankar <ashankar>
Component: systemdAssignee: systemd-maint
Status: CLOSED ERRATA QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: medium Docs Contact:
Priority: unspecified    
Version: 20CC: johannbg, lnie, lnykryn, msekleta, plautrba, systemd-maint, vpavlin, zbyszek
Target Milestone: ---   
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: systemd-208-14.fc20 Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of:
: 1036848 (view as bug list) Environment:
Last Closed: 2014-02-24 12:35:05 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Bug Depends On:    
Bug Blocks: 1036848    

Description Arjun Shankar 2013-12-02 18:18:59 UTC
Description of problem:

    Even if the command specified in ExecReload in /lib/systemd/system/$SERVICE returns an error, executing 'systemctl reload $SERVICE' always returns 0.

    According to LSB [1], some actions such as 'start', 'stop', 'restart' have exceptions where success is reported irrespective of parts of action failing. But this isn't the case for 'reload'.

Version-Release number of selected component (if applicable):

    systemd-208-6.fc20

How reproducible:

Always

Steps to Reproduce:
    1. # yum install -y nscd
    2. # systemctl stop nscd
    3. # systemctl reload nscd # try to reload a stopped service
    4. # echo $? # check if reload succeeded

Actual results:
    0 # even though all the ExecReload commands return 1 (fail)

Expected results:
    1

Additional info:
[1] http://refspecs.linuxbase.org/LSB_3.1.1/LSB-Core-generic/LSB-Core-generic/iniscrptact.html

Comment 1 Zbigniew Jędrzejewski-Szmek 2013-12-03 03:26:04 UTC
Fixed upstream in http://cgit.freedesktop.org/systemd/systemd/commit/?id=6a371e23e.

Comment 2 Fedora Update System 2014-01-15 01:27:17 UTC
systemd-208-11.fc20 has been submitted as an update for Fedora 20.
https://admin.fedoraproject.org/updates/systemd-208-11.fc20

Comment 3 lnie 2014-01-15 03:24:01 UTC
systemd-208-11.fc20 works

Comment 4 Fedora Update System 2014-01-16 07:03:42 UTC
Package systemd-208-11.fc20:
* should fix your issue,
* was pushed to the Fedora 20 testing repository,
* should be available at your local mirror within two days.
Update it with:
# su -c 'yum update --enablerepo=updates-testing systemd-208-11.fc20'
as soon as you are able to.
Please go to the following url:
https://admin.fedoraproject.org/updates/FEDORA-2014-0902/systemd-208-11.fc20
then log in and leave karma (feedback).

Comment 5 Fedora Update System 2014-02-17 07:39:48 UTC
systemd-208-13.fc20 has been submitted as an update for Fedora 20.
https://admin.fedoraproject.org/updates/systemd-208-13.fc20

Comment 6 Fedora Update System 2014-02-17 15:08:28 UTC
systemd-208-14.fc20 has been submitted as an update for Fedora 20.
https://admin.fedoraproject.org/updates/systemd-208-14.fc20

Comment 7 Fedora Update System 2014-02-24 12:35:05 UTC
systemd-208-14.fc20 has been pushed to the Fedora 20 stable repository.  If problems still persist, please make note of it in this bug report.