Bug 1037295

Summary:	qpid-cpp FTBFS if "-Werror=format-security" flag is used
Product:	[Fedora] Fedora	Reporter:	Dhiru Kholia <dkholia>
Component:	qpid-cpp	Assignee:	Darryl L. Pierce <dpierce>
Status:	CLOSED ERRATA	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	unspecified	Docs Contact:
Priority:	unspecified
Version:	rawhide	CC:	bressers, dkholia, dpierce, jose.p.oliveira.oss, mtasaka, nsantos, tross
Target Milestone:	---
Target Release:	---
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:	qpid-cpp-0.24-9.fc20	Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2014-02-01 03:59:56 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Bug Depends On:
Bug Blocks:	1038083

Description Dhiru Kholia 2013-12-03 05:54:10 UTC

Description of problem
----------------------

qpid-cpp fails to build if "-Werror=format-security" flag is used.

...

/builddir/build/BUILD/qpid-0.24/cpp/bindings/qpid/ruby/rubyRUBY_wrap.cxx:2237:38: error: format not a string literal and no format arguments [-Werror=format-security]
/builddir/build/BUILD/qpid-0.24/cpp/bindings/qpid/ruby/rubyRUBY_wrap.cxx:2304:34: error: format not a string literal and no format arguments [-Werror=format-security]
/builddir/build/BUILD/qpid-0.24/cpp/bindings/qpid/ruby/rubyRUBY_wrap.cxx:2340:34: error: format not a string literal and no format arguments [-Werror=format-security]
/builddir/build/BUILD/qpid-0.24/cpp/bindings/qpid/ruby/rubyRUBY_wrap.cxx:2409:34: error: format not a string literal and no format arguments [-Werror=format-security]

...

We are working on a proposal to enable "-Werror=format-security" for all
packages. Once this flag is enabled, GCC will refuse to compile code that could
be vulnerable to a string format security flaw. For more details, please see
https://fedorahosted.org/fesco/ticket/1185 page.

To understand why it is important to fix this, please see
https://fedoraproject.org/wiki/Format-Security-FAQ page.

How to fix this
---------------

The fix for these errors is quite simple. It's a matter of changing a
line like,

printf(foo);

to read,

printf("%s", foo);

That's it.

Please fix this issue in rawhide with a patch (which you should submit
to upstream to merge moving forward). Please do a new build with the
fix in rawhide. Other releases do not need to be directly fixed, but
there should be no harm in pushing out this fix/patch with other needed
changes to those branches.

In the event you don't fix this bug before the next mass rebuild,
provenpackagers may step in and update your package(s) to fix this
issue.

How reproducible
----------------

Build qpid-cpp-0.24-5.fc21.src.rpm with "-Werror=format-security" flag to reproduce the problem.

To make this process easier, you can use a modified "redhat-rpm-config" package
from http://people.fedoraproject.org/~halfie/artifacts/redhat-rpm-config/ URL.

$ sha256sum redhat-rpm-config-9.1.0-56.fc20.*
faad7594b2080fe76497d0ce50808c905a93dd7b41c1defdde5ca57e3833d3d2 redhat-rpm-config-9.1.0-56.fc20.noarch.rpm
5aa9357174305c7285ffdbc92d7ffe1c07a8a95d5459b930461308f5aad75413 redhat-rpm-config-9.1.0-56.fc20.src.rpm

Comment 1 Darryl L. Pierce 2013-12-06 15:30:21 UTC

The code in the example shown isn't upstream code, but is generated by Swig when it creates language bindings for our library. This proposal is going to negatively affect any package that uses Swig to generate dynamic language bindings, since we don't (AFAIK) have the ability to control how those statements are generated in the binding code.

What's the proposal in that scenario?

Comment 2 Mamoru TASAKA 2014-01-22 03:09:21 UTC

The input files for swig themselves need fixing.

qpid-0.24/cpp/bindings/qpid/ruby/ruby.i:33:        rb_raise(merror, mex.what());
qpid-0.24/cpp/bindings/qmf2/ruby/ruby.i:33:        rb_raise(qmferror, mex.what());
qpid-0.24/cpp/include/qpid/swig_ruby_typemaps.i:109:            rb_raise(error, ex.what());

Comment 3 Fedora Update System 2014-01-22 19:53:37 UTC

qpid-cpp-0.24-9.fc20 has been submitted as an update for Fedora 20.
https://admin.fedoraproject.org/updates/qpid-cpp-0.24-9.fc20

Comment 4 Fedora Update System 2014-01-23 11:04:22 UTC

Package qpid-cpp-0.24-9.fc20:
* should fix your issue,
* was pushed to the Fedora 20 testing repository,
* should be available at your local mirror within two days.
Update it with:
# su -c 'yum update --enablerepo=updates-testing qpid-cpp-0.24-9.fc20'
as soon as you are able to.
Please go to the following url:
https://admin.fedoraproject.org/updates/FEDORA-2014-1366/qpid-cpp-0.24-9.fc20
then log in and leave karma (feedback).

Comment 5 Fedora Update System 2014-02-01 03:59:56 UTC

qpid-cpp-0.24-9.fc20 has been pushed to the Fedora 20 stable repository.  If problems still persist, please make note of it in this bug report.