Bug 1037337

Summary:	stalonetray FTBFS if "-Werror=format-security" flag is used
Product:	[Fedora] Fedora	Reporter:	Dhiru Kholia <dkholia>
Component:	stalonetray	Assignee:	Ben Boeckel <fedora>
Status:	CLOSED RAWHIDE	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	unspecified	Docs Contact:
Priority:	unspecified
Version:	rawhide	CC:	bressers, dhiru, fedora
Target Milestone:	---
Target Release:	---
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:		Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2014-02-21 18:43:51 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:
Bug Blocks:	1038083

Description Dhiru Kholia 2013-12-03 05:59:24 UTC

Description of problem
----------------------

stalonetray fails to build if "-Werror=format-security" flag is used.

...

debug.c:39:2: error: format not a string literal and no format arguments [-Werror=format-security]

...

We are working on a proposal to enable "-Werror=format-security" for all
packages. Once this flag is enabled, GCC will refuse to compile code that could
be vulnerable to a string format security flaw. For more details, please see
https://fedorahosted.org/fesco/ticket/1185 page.

To understand why it is important to fix this, please see
https://fedoraproject.org/wiki/Format-Security-FAQ page.

How to fix this
---------------

The fix for these errors is quite simple. It's a matter of changing a
line like,

printf(foo);

to read,

printf("%s", foo);

That's it.

Please fix this issue in rawhide with a patch (which you should submit
to upstream to merge moving forward). Please do a new build with the
fix in rawhide. Other releases do not need to be directly fixed, but
there should be no harm in pushing out this fix/patch with other needed
changes to those branches.

In the event you don't fix this bug before the next mass rebuild,
provenpackagers may step in and update your package(s) to fix this
issue.

How reproducible
----------------

Build stalonetray-0.8.1-3.fc20.src.rpm with "-Werror=format-security" flag to reproduce the problem.

To make this process easier, you can use a modified "redhat-rpm-config" package
from http://people.fedoraproject.org/~halfie/artifacts/redhat-rpm-config/ URL.

$ sha256sum redhat-rpm-config-9.1.0-56.fc20.*
faad7594b2080fe76497d0ce50808c905a93dd7b41c1defdde5ca57e3833d3d2 redhat-rpm-config-9.1.0-56.fc20.noarch.rpm
5aa9357174305c7285ffdbc92d7ffe1c07a8a95d5459b930461308f5aad75413 redhat-rpm-config-9.1.0-56.fc20.src.rpm

Comment 1 Ben Boeckel 2013-12-03 16:48:17 UTC

Patch: https://pkgs.fedoraproject.org/cgit/stalonetray.git/tree/stalonetray-0.8.1--Werror-format-security.patch

Builds with the patch (but without the flag):

http://koji.fedoraproject.org/koji/buildinfo?buildID=479763
http://koji.fedoraproject.org/koji/buildinfo?buildID=479761

Comment 2 Ben Boeckel 2014-02-21 15:34:26 UTC

When is the flag supposed to be turned on? stalonetray should be ready for it, but I haven't seen other builds go through with the flag.

Comment 3 Dhiru Kholia 2014-02-21 15:59:56 UTC

Hi Ben,

It seems that it will be a while before a mass rebuild (with new flags) takes place. 

I have requested it on https://fedorahosted.org/fesco/ticket/1185 URL.

Comment 4 Ben Boeckel 2014-02-21 18:43:51 UTC

OK, looks like it will just hitch a ride on some mass rebuild goes through for GCC or the like. I'll close this since it seems that holding it open until an actual rebuild goes through might cause confusion with it now Blocking the tracking bug.