Bug 1037501

Summary:	All the existing bricks are not marked source when new brick is added to volume to increase the replica count from 2 to 3
Product:	[Community] GlusterFS	Reporter:	vsomyaju
Component:	replicate	Assignee:	vsomyaju
Status:	CLOSED CURRENTRELEASE	QA Contact:
Severity:	high	Docs Contact:
Priority:	high
Version:	pre-release	CC:	gluster-bugs, nsathyan, spandura, vagarwal, vbellur, vsomyaju
Target Milestone:	---	Keywords:	ZStream
Target Release:	---
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:	glusterfs-3.5.0	Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:	1024371	Environment:
Last Closed:	2014-04-17 11:51:50 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:	1024371
Bug Blocks:

Comment 1 Anand Avati 2013-12-03 10:11:28 UTC

REVIEW: http://review.gluster.org/6408 (cluster/afr: All existing source brick are marked as source) posted (#1) for review on master by venkatesh somyajulu (vsomyaju)

Comment 2 Anand Avati 2013-12-04 08:50:05 UTC

REVIEW: http://review.gluster.org/6419 (cluster/afr: For entry self heal, mark all source bricks) posted (#1) for review on release-3.5 by venkatesh somyajulu (vsomyaju)

Comment 3 Anand Avati 2013-12-06 07:01:29 UTC

REVIEW: http://review.gluster.org/6451 (cluster/afr: For entry self heal, mark all source bricks) posted (#1) for review on master by venkatesh somyajulu (vsomyaju)

Comment 4 Anand Avati 2013-12-06 07:03:03 UTC

REVIEW: http://review.gluster.org/6419 (cluster/afr: For entry self heal, mark all source bricks) posted (#2) for review on release-3.5 by venkatesh somyajulu (vsomyaju)

Comment 5 Anand Avati 2013-12-11 07:33:12 UTC

REVIEW: http://review.gluster.org/6419 (cluster/afr: For entry self heal, mark all source bricks) posted (#3) for review on release-3.5 by venkatesh somyajulu (vsomyaju)

Comment 6 Anand Avati 2013-12-16 13:00:52 UTC

REVIEW: http://review.gluster.org/6419 (cluster/afr: For entry self heal, mark all source bricks) posted (#4) for review on release-3.5 by venkatesh somyajulu (vsomyaju)

Comment 7 Anand Avati 2013-12-16 13:37:43 UTC

REVIEW: http://review.gluster.org/6419 (cluster/afr: For entry self heal, mark all source bricks) posted (#5) for review on release-3.5 by venkatesh somyajulu (vsomyaju)

Comment 8 Anand Avati 2013-12-19 11:44:58 UTC

COMMIT: http://review.gluster.org/6419 committed in release-3.5 by Vijay Bellur (vbellur) 
------
commit 7683a4bed9d3168f9a6e70af1a7e316334b201cb
Author: Venkatesh Somyajulu <vsomyaju>
Date:   Mon Dec 16 19:04:54 2013 +0530

    cluster/afr: For entry self heal, mark all source bricks
    
    Problem:
    Whenever a new brick is added into a replicate volume, all
    source bricks are not marked as source. Only one of them is
    marked as source. Here marked as source refers to adding
    extended attribute at the backend of a file corresponding to
    the newly added brick. As well as source bricks should point
    to the newly added brick so that heal can be triggered.
    
    Fix:
    All source bricks will now point to newly added bricks and heal
    can be triggered based on the extended attributes.
    
    Change-Id: Ia7cf118270fecc429bdecddbcb9201f23fedc7a1
    BUG: 1037501
    Signed-off-by: Venkatesh Somyajulu <vsomyaju>
    Reviewed-on: http://review.gluster.org/6419
    Tested-by: Gluster Build System <jenkins.com>
    Reviewed-by: Pranith Kumar Karampuri <pkarampu>
    Reviewed-by: Ravishankar N <ravishankar>
    Reviewed-by: Vijay Bellur <vbellur>

Comment 9 Anand Avati 2013-12-19 12:36:43 UTC

REVIEW: http://review.gluster.org/6541 (cluster/afr:  Change errno to op_errno) posted (#1) for review on release-3.5 by venkatesh somyajulu (vsomyaju)

Comment 10 Anand Avati 2013-12-19 12:44:42 UTC

REVIEW: http://review.gluster.org/6540 (cluster/afr: For entry self heal, mark all source bricks) posted (#2) for review on master by venkatesh somyajulu (vsomyaju)

Comment 11 Anand Avati 2013-12-19 12:45:37 UTC

REVIEW: http://review.gluster.org/6541 (cluster/afr:  Change errno to op_errno) posted (#2) for review on release-3.5 by venkatesh somyajulu (vsomyaju)

Comment 12 Anand Avati 2013-12-19 17:34:13 UTC

COMMIT: http://review.gluster.org/6540 committed in master by Vijay Bellur (vbellur) 
------
commit 3991b0d0e934214882c064a0b720375af5c1575a
Author: Venkatesh Somyajulu <vsomyaju>
Date:   Thu Dec 19 18:11:38 2013 +0530

    cluster/afr: For entry self heal, mark all source bricks
    
    Problem:
    Whenever a new brick is added into a replicate volume, all
    source bricks are not marked as source. Only one of them is
    marked as source. Here marked as source refers to adding
    extended attribute at the backend of a file corresponding to
    the newly added brick. As well as source bricks should point
    to the newly added brick so that heal can be triggered.
    
    Fix:
    All source bricks will now point to newly added bricks and heal
    can be triggered based on the extended attributes.
    
    Change-Id: I318e1f779a380c16c448a2d05c0140d8e4647fd4
    BUG: 1037501
    Signed-off-by: Venkatesh Somyajulu <vsomyaju>
    Reviewed-on: http://review.gluster.org/6540
    Reviewed-by: Pranith Kumar Karampuri <pkarampu>
    Tested-by: Gluster Build System <jenkins.com>
    Reviewed-by: Vijay Bellur <vbellur>

Comment 13 Anand Avati 2013-12-26 09:21:45 UTC

REVIEW: http://review.gluster.org/6596 (test: Modified bug-1037501.t script) posted (#1) for review on master by venkatesh somyajulu (vsomyaju)

Comment 14 Anand Avati 2013-12-26 10:43:43 UTC

REVIEW: http://review.gluster.org/6598 (test: Modified bug-1037501.t script) posted (#1) for review on release-3.5 by venkatesh somyajulu (vsomyaju)

Comment 15 Anand Avati 2013-12-27 11:18:37 UTC

REVIEW: http://review.gluster.org/6596 (test: Modified bug-1037501.t script) posted (#2) for review on master by venkatesh somyajulu (vsomyaju)

Comment 16 Anand Avati 2013-12-27 11:22:54 UTC

REVIEW: http://review.gluster.org/6596 (test: Modified bug-1037501.t script) posted (#3) for review on master by venkatesh somyajulu (vsomyaju)

Comment 17 Anand Avati 2013-12-27 11:28:03 UTC

REVIEW: http://review.gluster.org/6598 (test: Modified bug-1037501.t script) posted (#2) for review on release-3.5 by venkatesh somyajulu (vsomyaju)

Comment 18 Anand Avati 2013-12-28 03:13:25 UTC

COMMIT: http://review.gluster.org/6596 committed in master by Vijay Bellur (vbellur) 
------
commit 6b41a0b7dfd9f48e1518430bacba9135bee4fcb4
Author: Venkatesh Somyajulu <vsomyaju>
Date:   Fri Dec 27 16:51:29 2013 +0530

    test: Modified bug-1037501.t script
    
    Change-Id: I3114009681d49249fe292f94a464efc419c944cb
    BUG: 1037501
    Signed-off-by: Venkatesh Somyajulu <vsomyaju>
    Reviewed-on: http://review.gluster.org/6596
    Reviewed-by: Pranith Kumar Karampuri <pkarampu>
    Tested-by: Gluster Build System <jenkins.com>

Comment 19 Anand Avati 2013-12-28 03:13:54 UTC

COMMIT: http://review.gluster.org/6598 committed in release-3.5 by Vijay Bellur (vbellur) 
------
commit c4ce0d7785923a2896830a19166facaf5cfc39cc
Author: Venkatesh Somyajulu <vsomyaju>
Date:   Fri Dec 27 16:51:29 2013 +0530

    test: Modified bug-1037501.t script
    
    Change-Id: I6d49d8a66a6dc68619005e731969010b013cb834
    BUG: 1037501
    Signed-off-by: Venkatesh Somyajulu <vsomyaju>
    Reviewed-on: http://review.gluster.org/6598
    Reviewed-by: Pranith Kumar Karampuri <pkarampu>
    Tested-by: Gluster Build System <jenkins.com>

Comment 20 Anand Avati 2013-12-30 07:16:41 UTC

COMMIT: http://review.gluster.org/6541 committed in release-3.5 by Vijay Bellur (vbellur) 
------
commit a3e3e8dee442371665996450ac3a8d2859c47cc0
Author: Venkatesh Somyajulu <vsomyaju>
Date:   Thu Dec 19 18:04:46 2013 +0530

    cluster/afr:  Change errno to op_errno
    
    Changed errno to op_errno
    
    Change-Id: I357987af352cf1d9abda4188d392f17d10b12aec
    BUG: 1037501
    Signed-off-by: Venkatesh Somyajulu <vsomyaju>
    Reviewed-on: http://review.gluster.org/6541
    Reviewed-by: Pranith Kumar Karampuri <pkarampu>
    Tested-by: Gluster Build System <jenkins.com>
    Reviewed-by: Vijay Bellur <vbellur>

Comment 21 Niels de Vos 2014-04-17 11:51:50 UTC

This bug is getting closed because a release has been made available that should address the reported issue. In case the problem is still not fixed with glusterfs-3.5.0, please reopen this bug report.

glusterfs-3.5.0 has been announced on the Gluster Developers mailinglist [1], packages for several distributions should become available in the near future. Keep an eye on the Gluster Users mailinglist [2] and the update infrastructure for your distribution.

[1] http://thread.gmane.org/gmane.comp.file-systems.gluster.devel/6137
[2] http://thread.gmane.org/gmane.comp.file-systems.gluster.user