Bug 1037855

Summary: remove avail async API from plugins
Product: [Other] RHQ Project Reporter: John Mazzitelli <mazz>
Component: AgentAssignee: John Mazzitelli <mazz>
Status: CLOSED CURRENTRELEASE QA Contact: Mike Foley <mfoley>
Severity: unspecified Docs Contact:
Priority: unspecified    
Version: 4.10CC: hrupp
Target Milestone: GA   
Target Release: RHQ 4.10   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2014-04-23 12:30:42 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On: 971556    
Bug Blocks:    
Attachments:
Description Flags
patch to remove async avail from plugins
none
more comprehensive patch none

Description John Mazzitelli 2013-12-03 22:52:10 UTC 
see bug #971556 - now that that is fixed, we should eliminate the async availability API that was given to plugins to use (since all resources now have their avails checked asynchrhonously). this means we have to take the code out of the plugins that used it (which I think included JBossAS 4, JBossAS 5). Also take out the plugin configuration metadata that controlled the async option.
Comment 1 John Mazzitelli 2013-12-04 14:43:47 UTC 
Created attachment 832687 [details]
patch to remove async avail from plugins

attached is a patch that removes all the async avail stuff from the plugins. The plugins affected are the three JBossAS plugins (AS4, AS5, AS7).

I only mark the async availability collector class as @Deprecated in case other plugins out in the wild are using it.
Comment 2 John Mazzitelli 2013-12-04 15:21:17 UTC 
Created attachment 832706 [details]
more comprehensive patch

attaching a more comprehensive patch from the previous one. this new patch obsoletes the one I earlier attached.
Comment 3 John Mazzitelli 2013-12-09 17:51:15 UTC 
git commit to master related to this issue:

f89a8b4ce8c647c93255db0645758eded2423239
273c9a9593fe488f5f1ac85dfcf66253d1f19d25
988034f36abce65ed3bf4a6fa1846a0d540398ba
Comment 4 John Mazzitelli 2013-12-09 20:39:13 UTC 
git commit 856d791 - there are some public constants that could have been removed, but when doing so caused the API check to fail. So I put them back and marked them as deprecated.
Comment 5 Heiko W. Rupp 2014-04-23 12:30:42 UTC 
Bulk closing of 4.10 issues.

If an issue is not solved for you, please open a new BZ (or clone the existing one) with a version designator of 4.10.