Bug 1037859

Summary: off-by-one error(?) when setting umask special permissions in gitolite.rc
Product: [Fedora] Fedora EPEL Reporter: Tiemen Ruiten <tiemen>
Component: gitolite3Assignee: Gwyn Ciesla <gwync>
Status: CLOSED CURRENTRELEASE QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: medium Docs Contact:
Priority: unspecified    
Version: el6CC: gwync, lkundrak
Target Milestone: ---   
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2014-01-16 14:08:31 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:

Description Tiemen Ruiten 2013-12-03 23:14:32 UTC
Description of problem:
whenever I set the special (first) bit of the UMASK variable in gitolite.rc, and try to update the gitolite-admin repository, objects are created/modified with the wrong permissions. I'm not a programmer, but this seems to be an off-by-one error. For example: I set the UMASK to 5027, binary representation 101 000 010 111, the actual permissions the object gets updated with are:
d--x-wxr--  2 gitolite3 gitolite3 4096 Dec  4 00:03 e6

binary representation: 000 001 011 100

Version-Release number of selected component (if applicable):
3.5.2

How reproducible:
set the first bit in the umask in gitolite.rc to something other than 0 and update the gitolite-admin repo, the update will fail because of permission problems in the objects folder.

Comment 1 Gwyn Ciesla 2014-01-16 14:08:31 UTC
Fixed.