Bug 1038067

Summary: Resource Summary/Activity shows summary of disabled metrics
Product: [JBoss] JBoss Operations Network Reporter: Armine Hovsepyan <ahovsepy>
Component: UIAssignee: Jirka Kremser <jkremser>
Status: CLOSED CURRENTRELEASE QA Contact: Mike Foley <mfoley>
Severity: high Docs Contact:
Priority: unspecified    
Version: JON 3.2CC: jkremser, jshaughn, lkrejci, loleary, mfoley, myarboro
Target Milestone: DR01Keywords: Triaged
Target Release: JON 3.2.1   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2014-05-08 17:43:59 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Attachments:
Description Flags
metric_summary_schedule
none
non-platform-resource none

Description Armine Hovsepyan 2013-12-04 10:59:21 UTC 
Description of problem:
Resource Summary/Activity shows summary of disabled metrics

Version-Release number of selected component (if applicable):
jon 3.2 CR1

How reproducible:
always

Steps to Reproduce:
1. Navigate to Monitoring -> Schedule of platform resource
2. Click on See More link (or navigate to Platform -. Monitoring -> Metrics)
3. Cound metrics
4. navigate to platform resource -> summary -> activity
5. Count metrics shown

Actual results:
After step4:
Diabled metrics (visible after step1 invisible after step 2)are visible on page


Expected results:
Only enabled metrics should be shown on summary -> activity page


2nd case:
1. Enable disabled metric visible on summary -> activity page
2. Compare values in summary and Monitoring/metrics pages

Actual results:
After step2. Value in Monitoring/Metrics is naN while values in Summary/Activity is not-null

Expected results:
Values in Monitoring/metrics and Summary/Activity are the same


Additional info:
Screen-shots attached
Comment 1 Armine Hovsepyan 2013-12-04 11:00:38 UTC 
Created attachment 832575 [details]
metric_summary_schedule

disabled metrics visible on summary/activity
Comment 2 Armine Hovsepyan 2013-12-04 11:06:18 UTC 
the issue seems visible for platform resources only - not visible for storage->cassandra server jvm->memory subsystem resource -- screen-shot attached
Comment 3 Armine Hovsepyan 2013-12-04 11:06:45 UTC 
Created attachment 832577 [details]
non-platform-resource
Comment 4 Jirka Kremser 2013-12-04 19:24:27 UTC 
branch:  master
link:    http://git.fedorahosted.org/cgit/rhq/rhq.git/commit/?id=985cf07bc
time:    2013-12-04 20:10:36 +0100
commit:  985cf07bc5835ab816d661008f1f752a355f3d4e
author:  Jirka Kremser - jkremser
message: [BZ 1038067] - Resource Summary/Activity shows summary of disabled
         metrics - adding a check that finds out whether the resource
         has those metrics scheduled. This is done in parallel using the
         countdown latch pattern.


=> needs to be cherry-picked over to the release branch once 3.2 is out
Comment 5 Mike Thompson 2013-12-04 21:39:28 UTC 
*** Bug 1033338 has been marked as a duplicate of this bug. ***
Comment 6 Jirka Kremser 2013-12-05 18:34:21 UTC 
branch:  master
link:    http://git.fedorahosted.org/cgit/rhq/rhq.git/commit/?id=ab5629677
time:    2013-11-21 12:31:24 +0200
commit:  ab5629677b79df0286df8ced99e919264e0b6aba
author:  Jirka Kremser - jkremser
message: [BZ 1038067] - Resource Summary/Activity shows summary of disabled
         metrics - fixing the issue for resource groups (Autogroups and
         compatible ones).

    Also doing some refactoring, because the same code was in the portlet
    for resource and for group, so I moved the common functionality to the
    group portlet and resource portlet overrides the different parts. What
    would be even better is to introduce a common abstract class in the new
    package
    org.rhq.coregui.client.dashboard.portlets.common (the same way it is
    done in the org.rhq.coregui.client.inventory.common package). However,
    all the portlets follow this pattern (ResourcePortlet extends
    GroupPortles), so it would be inconsistent.
    
    After the refactoring, the code is more flat because the callback hell is
    not so evil when using own methods for each callback. The toll for it is
    the number of arguments that has to be passed to those methods
    representing the state that is needed inside the method.



=> needs to be cherry-picked over to the release branch once 3.2 is out (together with the previous commit)
Comment 11 Jay Shaughnessy 2014-01-10 18:59:42 UTC 
release/jon3.2.x commit 03f930f8d89535f76e68778dd538d3a5d4101886

  Cherry-Pick master 985cf07bc5835ab816d661008f1f752a355f3d4e

release/jon3.2.x commit 8932ffebcdeec5c2277e77ab05b9d632637ab0fa

  Cherry-Pick master ab5629677b79df0286df8ced99e919264e0b6aba
Comment 12 Simeon Pinder 2014-02-18 15:08:31 UTC 
Moving to ON_QA as available for testing in the following brew build:
https://brewweb.devel.redhat.com//buildinfo?buildID=336752

Note: the installed version is still JON 3.2.0.GA by design and this represents part of the payload for JON 3.2.1 also known as cumulative patch 1 for 3.2.0.GA.  How this will be delivered to customers is still being discussed.
Comment 13 Mike Foley 2014-02-18 18:54:32 UTC 
verified jon 3.2.1 dr1
Comment 14 Mike Foley 2014-03-19 19:50:47 UTC 
re-verified in JON 3.2 CP1
Comment 15 Mike Foley 2014-05-08 17:43:59 UTC 
JON 3.2.1 released week of 5/5/2014