Bug 1038190

Full scratch build available at: http://koji.fedoraproject.org/koji/taskinfo?taskID=6256270

Spec available at: http://averi.fedorapeople.org/RPMs/python-cmdln/python-cmdln.spec

Updated scratch build: http://koji.fedoraproject.org/koji/taskinfo?taskID=6256364

SPEC at the same url.

Package Review
==============

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed


Issues:
- Please use URL as Source
- Please put the docs/ dir in a -doc subpackage (which requires the base package)
- Please remove the BuildRoot tag
- Please remove teh %clean section



===== MUST items =====

Generic:
[x]: Package is licensed with an open-source compatible license and meets
     other legal requirements as defined in the legal section of Packaging
     Guidelines.
[x]: License field in the package spec file matches the actual license.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
     Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Package is not known to require an ExcludeArch tag.
[!]: Large documentation must go in a -doc subpackage. Large could be size
     (~1MB) or number of files.
     Note: Documentation size is 102400 bytes in 7 files.
[!]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least one
     supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
     Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the license(s)
     in its own file, then that file, containing the text of the license(s)
     for the package is included in %doc.
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: All build dependencies are listed in BuildRequires, except for any that
     are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
     beginning of %install.
[x]: Each %files section contains %defattr if rpm < 4.4
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install' ' DESTDIR=... doesn't
     work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package do not use a name that already exist
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as provided
     in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
     %{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local

Python:
[x]: Python eggs must not download any dependencies during the build process.
[x]: A package which is used by another package via an egg interface should
     provide egg info.
[x]: Package meets the Packaging Guidelines::Python
[x]: Package contains BR: python2-devel or python3-devel
[x]: Binary eggs must be removed in %prep

===== SHOULD items =====

Generic:
[!]: Buildroot is not present
     Note: Invalid buildroot found:
     %{_tmppath}/%{name}-%{version}-%{release}-buildroot
     See: http://fedoraproject.org/wiki/Packaging/Guidelines#BuildRoot_tag
[!]: Package has no %clean section with rm -rf %{buildroot} (or
     $RPM_BUILD_ROOT)
     Note: %clean present but not required
[x]: If the source package does not include license text(s) as a separate file
     from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[?]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[!]: SourceX tarball generation or download is documented.
     Note: Package contains tarball without URL, check comments
[-]: Description and summary sections in the package spec file contains
     translations for supported Non-English languages, if available.
[x]: Package should compile and build into binary rpms on all supported
     architectures.
[-]: %check is present and all tests pass.
[x]: Packages should try to preserve timestamps of original installed files.
[x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file
[x]: Reviewer should test that the package builds in mock.
[x]: Dist tag is present (not strictly required in GL).
[x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin.
[x]: Fully versioned dependency in subpackages if applicable.
[x]: SourceX is a working URL.
[x]: Spec use %global instead of %define unless justified.

===== EXTRA items =====

Generic:
[x]: Spec file according to URL is the same as in SRPM.
[x]: Rpmlint is run on all installed packages.
     Note: There are rpmlint messages (see attachment).
[x]: Large data in /usr/share should live in a noarch subpackage if package is
     arched.


Rpmlint
-------
Checking: python-cmdln-1.1.2-1.fc19.noarch.rpm
          python-cmdln-1.1.2-1.fc19.src.rpm
python-cmdln.noarch: W: spelling-error Summary(en_US) cmd -> cm, cad, cod
python-cmdln.noarch: W: spelling-error Summary(en_US) py -> pt, p, y
python-cmdln.noarch: W: spelling-error %description -l en_US py -> pt, p, y
python-cmdln.noarch: W: spelling-error %description -l en_US cmd -> cm, cad, cod
python-cmdln.noarch: W: spelling-error %description -l en_US multi -> mulch, mufti
python-cmdln.noarch: W: spelling-error %description -l en_US cvs -> cs, vs, cos
python-cmdln.noarch: W: spelling-error %description -l en_US svn -> sen, sin, son
python-cmdln.noarch: W: spelling-error %description -l en_US gdb -> db, gab, gob
python-cmdln.noarch: W: spelling-error %description -l en_US pdb -> pd, db, pub
python-cmdln.noarch: W: spelling-error %description -l en_US optparse -> opt parse, opt-parse, sparse
python-cmdln.noarch: E: non-executable-script /usr/lib/python2.7/site-packages/cmdln.py 0644L /usr/bin/env
python-cmdln.noarch: W: doc-file-dependency /usr/share/doc/python-cmdln-1.1.2/p4.py /usr/bin/env
python-cmdln.noarch: W: doc-file-dependency /usr/share/doc/python-cmdln-1.1.2/svn.py /usr/bin/env
python-cmdln.src: W: spelling-error Summary(en_US) cmd -> cm, cad, cod
python-cmdln.src: W: spelling-error Summary(en_US) py -> pt, p, y
python-cmdln.src: W: spelling-error %description -l en_US py -> pt, p, y
python-cmdln.src: W: spelling-error %description -l en_US cmd -> cm, cad, cod
python-cmdln.src: W: spelling-error %description -l en_US multi -> mulch, mufti
python-cmdln.src: W: spelling-error %description -l en_US cvs -> cs, vs, cos
python-cmdln.src: W: spelling-error %description -l en_US svn -> sen, sin, son
python-cmdln.src: W: spelling-error %description -l en_US gdb -> db, gab, gob
python-cmdln.src: W: spelling-error %description -l en_US pdb -> pd, db, pub
python-cmdln.src: W: spelling-error %description -l en_US optparse -> opt parse, opt-parse, sparse
python-cmdln.src: W: invalid-url Source0: python-cmdln-1.1.2.tar.gz
2 packages and 0 specfiles checked; 1 errors, 23 warnings.




Rpmlint (installed packages)
----------------------------
# rpmlint python-cmdln
python-cmdln.noarch: W: spelling-error Summary(en_US) cmd -> cm, cad, cod
python-cmdln.noarch: W: spelling-error Summary(en_US) py -> pt, p, y
python-cmdln.noarch: W: spelling-error %description -l en_US py -> pt, p, y
python-cmdln.noarch: W: spelling-error %description -l en_US cmd -> cm, cad, cod
python-cmdln.noarch: W: spelling-error %description -l en_US multi -> mulch, mufti
python-cmdln.noarch: W: spelling-error %description -l en_US cvs -> cs, vs, cos
python-cmdln.noarch: W: spelling-error %description -l en_US svn -> sen, sin, son
python-cmdln.noarch: W: spelling-error %description -l en_US gdb -> db, gab, gob
python-cmdln.noarch: W: spelling-error %description -l en_US pdb -> pd, db, pub
python-cmdln.noarch: W: spelling-error %description -l en_US optparse -> opt parse, opt-parse, sparse
python-cmdln.noarch: E: non-executable-script /usr/lib/python2.7/site-packages/cmdln.py 0644L /usr/bin/env
python-cmdln.noarch: W: doc-file-dependency /usr/share/doc/python-cmdln-1.1.2/p4.py /usr/bin/env
python-cmdln.noarch: W: doc-file-dependency /usr/share/doc/python-cmdln-1.1.2/svn.py /usr/bin/env
1 packages and 0 specfiles checked; 1 errors, 12 warnings.
# echo 'rpmlint-done:'


Requires
--------
python-cmdln (rpmlib, GLIBC filtered):
    /usr/bin/env
    python(abi)



Provides
--------
python-cmdln:
    python-cmdln



Generated by fedora-review 0.5.0 (920221d) last change: 2013-08-30
Command line :/usr/bin/fedora-review -b 1038190
Buildroot used: fedora-19-x86_64
Active plugins: Generic, Python, Shell-api
Disabled plugins: Java, C/C++, SugarActivity, Perl, R, PHP, Ruby
Disabled flags: EPEL5, EXARCH, DISTTAG

With your changes to the spec:

APPROVED

Thanks, as a note, final SRPM and spec file:

SPEC: http://averi.fedorapeople.org/RPMs/python-cmdln/python-cmdln.spec

SRPM: http://kojipkgs.fedoraproject.org//work/tasks/6796/6256796/python-cmdln-1.3.0-1.fc21.src.rpm

New Package SCM Request
=======================
Package Name: python-cmdln
Short Description: An improved cmd.py for Writing Multi-command Scripts and Shells
Owners: averi 
Branches: f20 el6
InitialCC: averi

Git done (by process-git-requests).

python-cmdln-1.3.0-1.el6 has been submitted as an update for Fedora EPEL 6.
https://admin.fedoraproject.org/updates/python-cmdln-1.3.0-1.el6

python-cmdln-1.3.0-1.fc20 has been submitted as an update for Fedora 20.
https://admin.fedoraproject.org/updates/python-cmdln-1.3.0-1.fc20

python-cmdln-1.3.0-1.fc20 has been pushed to the Fedora 20 testing repository.

python-cmdln-1.3.0-2.el6 has been submitted as an update for Fedora EPEL 6.
https://admin.fedoraproject.org/updates/python-cmdln-1.3.0-2.el6

python-cmdln-1.3.0-2.fc20 has been submitted as an update for Fedora 20.
https://admin.fedoraproject.org/updates/python-cmdln-1.3.0-2.fc20

python-cmdln-1.3.0-2.fc20 has been pushed to the Fedora 20 stable repository.  If problems still persist, please make note of it in this bug report.

python-cmdln-1.3.0-2.el6 has been pushed to the Fedora EPEL 6 stable repository.  If problems still persist, please make note of it in this bug report.