Bug 1038354

Summary: hwcert-client no longer logging "Test Parameters"
Product: [Retired] Red Hat Hardware Certification Program Reporter: Greg Nichols <gnichols>
Component: Test Suite (tests)Assignee: Greg Nichols <gnichols>
Status: CLOSED ERRATA QA Contact: Red Hat Kernel QE team <kernel-qe>
Severity: unspecified Docs Contact:
Priority: unspecified    
Version: 1.7.0CC: bbrock, brose, gnichols, qcai, rlandry, yxue
Target Milestone: ---   
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: hwcert-client 1.7.0-20131210 Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: 1016382 Environment:
Last Closed: 2015-07-13 15:10:23 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Bug Depends On:    
Bug Blocks: 1016295    
Attachments:
Description Flags
patch adding <parameters> to <run> to log Test Parameters in XML
none
additional patch storing parameters as name/value pairs none

Description Greg Nichols 2013-12-05 00:50:11 UTC 
+++ This bug was initially created as a clone of Bug #1016382 +++

hwcert-clinet not prints "Test Parameters" in log, which useful for reviewers.
In v7, "Test Parameters" will be printed in the top of log
such as:
https://hardware.redhat.com/results.cgi?cert_id=1010875&id=288877

While in hwcert-client it disappear, such as:
https://hardware.redhat.com/results.cgi?cert_id=1007347&id=289135

But it is useful for reviewers, sometime, we will grab some info form it.

--- Additional comment from Greg Nichols on 2013-10-08 09:28:18 EDT ---

This was changed to be printed only in debug modes.   Do we want to restore it in 1.6.5 and.or 1.7.0?

--- Additional comment from Rob Landry on 2013-10-10 14:26:53 EDT ---

(In reply to Greg Nichols from comment #1)
> This was changed to be printed only in debug modes.   Do we want to restore
> it in 1.6.5 and.or 1.7.0?

Yes, can we put them in a <parameters> tag or similar?  We could then easily control visibility in the catalog if it becomes noisy.

--- Additional comment from Greg Nichols on 2013-11-21 19:33:34 EST ---

This makes sense.

--- Additional comment from Greg Nichols on 2013-12-04 19:48:18 EST ---
Comment 1 Greg Nichols 2013-12-05 00:53:19 UTC 
Created attachment 832919 [details]
patch adding <parameters> to <run> to log Test Parameters in XML
Comment 2 Greg Nichols 2013-12-10 15:33:42 UTC 
Created attachment 834837 [details]
additional patch storing parameters as name/value pairs


This added patch stores each property as xml elements, rather than a combined string:

<run end-time="2013-12-10 15:26:28" mode="normal" number="1" return-value="0" run-time="2013-12-10 15:26:24">
        <summary>PASS</summary>
        <parameters>
          <property name="OUTPUTFILE">/var/log/hwcert/runs/1/USB2/output.log</property>
          <property name="TESTSERVER">hwcert.boston.devel.redhat.com</property>
          <property name="RUNMODE">normal</property>
          <property name="DEBUG">low</property>
          <property name="UDI">/devices/pci0000:00/0000:00:14.0/usb3</property>
        </parameters>
[...]