Bug 1038604

Summary: make seabios 256k for rhel7 machine types
Product: Red Hat Enterprise Linux 7 Reporter: Gerd Hoffmann <kraxel>
Component: seabiosAssignee: Gerd Hoffmann <kraxel>
Status: CLOSED CURRENTRELEASE QA Contact: Virtualization Bugs <virt-bugs>
Severity: unspecified Docs Contact:
Priority: unspecified    
Version: 7.0CC: acathrow, flang, hhuang, juzhang, kraxel, michen, mrezanin, qiguo, qzhang, virt-maint, xfu
Target Milestone: rc   
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: seabios-1.7.2.2-5.el7 Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: 1038603
: 1038630 (view as bug list) Environment:
Last Closed: 2014-06-13 11:15:36 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On: 1038603    
Bug Blocks: 1038630    

Description Gerd Hoffmann 2013-12-05 13:11:53 UTC 
+++ This bug was initially created as a clone of Bug #1038603 +++

Description of problem:
Recent seabios doesn't fit into 128k any more.
Switch to 256k for rhel7 machine types.
rhel6 machine types must stay at 128k for compatibility reasons.

No very urgent needed as the rhel7 bios has some hardware support
disabled and is a bit smaller than upstream.  We'll get it from
upstream with the 7.1 rebase though, and having all rhel7 machine
types use the same bios size will simplify things, so backporting
to 7.0 looks useful nevertheless.
Comment 1 Gerd Hoffmann 2013-12-05 13:20:05 UTC 
need backport commit 85f8fac87526341d775b02a0bfbc29d97f3ba22a
also some specfile build logic
Comment 3 Gerd Hoffmann 2013-12-05 14:50:21 UTC 
patches on the list
Comment 4 Miroslav Rezanina 2013-12-10 07:48:56 UTC 
Fix included in seabios-1.7.2.2-5.el7
Comment 6 langfang 2013-12-17 09:12:50 UTC 
Hi Gerd 

    Could you please give QE a method of verify this bug?Thanks in advance


thanks

fang lang
Comment 7 Gerd Hoffmann 2013-12-17 17:02:34 UTC 
# ls -l /usr/share/seabios
total 384
-rw-r--r--. 1 root root 262144 Dec 12 10:52 bios-256k.bin
-rw-r--r--. 1 root root 131072 Dec 12 10:52 bios.bin

"bios-256k.bin" is the new seabios build, 256k in size.
Older seabios rpms don't have that.
Comment 8 langfang 2013-12-18 02:17:03 UTC 
Reproduce this bug as follow version:
Host:
# uname -r
3.10.0-61.el7.x86_64
# rpm -q qemu-kvm
qemu-kvm-1.5.3-21.el7.x86_64
#rpm -q seabios
seabios-1.7.2.2-4.el7.x86_64

# ls -l /usr/share/seabios
total 128
-rw-r--r--. 1 root root 131072 Nov  5 09:25 bios.bin

verify this bug as follow version:

seabios-1.7.2.2-6.el7.x86_64

# ls -l /usr/share/seabios
total 384
-rw-r--r--. 1 root root 262144 Dec 17 16:32 bios-256k.bin
-rw-r--r--. 1 root root 131072 Dec 17 16:32 bios.bin


According to above test ,this bug has fixed.
Comment 9 juzhang 2014-01-09 09:32:05 UTC 
(In reply to Gerd Hoffmann from comment #7)
> # ls -l /usr/share/seabios
> total 384
> -rw-r--r--. 1 root root 262144 Dec 12 10:52 bios-256k.bin
> -rw-r--r--. 1 root root 131072 Dec 12 10:52 bios.bin
> 
> "bios-256k.bin" is the new seabios build, 256k in size.
> Older seabios rpms don't have that.

Hi Gerd,

If we have 2 seabios.bin(bios-256k.bin and bios.bin). How do we know which bin is using by qemu-kvm?

One more question:
if boot guest with -M pc-i440fx-rhel7.0.0 or -M q35, the qemu-kvm should use bios-256k.bin. If boot guest with -M rhel6.x, the qemu-kvm will use the older one(bios.bin)?

Thanks,
Junyi
Comment 10 Gerd Hoffmann 2014-01-13 10:47:04 UTC 
> If we have 2 seabios.bin(bios-256k.bin and bios.bin). How do we know which
> bin is using by qemu-kvm?

'info roms' monitor command will list it.

> One more question:
> if boot guest with -M pc-i440fx-rhel7.0.0 or -M q35, the qemu-kvm should use
> bios-256k.bin. If boot guest with -M rhel6.x, the qemu-kvm will use the
> older one(bios.bin)?

Yes, that is the plan.  rhel6 machine types need the 128k bios for compatibility reasons.

Was sick for a while, so I'm not fully sure the qemu patches needed for that are merged into rhel7 already.  Hmm, bug 1038603 is still in POST, looks like not yet ...
Comment 11 juzhang 2014-01-14 01:30:19 UTC 
(In reply to Gerd Hoffmann from comment #10)
> > If we have 2 seabios.bin(bios-256k.bin and bios.bin). How do we know which
> > bin is using by qemu-kvm?
> 
> 'info roms' monitor command will list it.

Get it.

> 
> > One more question:
> > if boot guest with -M pc-i440fx-rhel7.0.0 or -M q35, the qemu-kvm should use
> > bios-256k.bin. If boot guest with -M rhel6.x, the qemu-kvm will use the
> > older one(bios.bin)?
> 
> Yes, that is the plan.  rhel6 machine types need the 128k bios for
> compatibility reasons.
> 
> Was sick for a while, so I'm not fully sure the qemu patches needed for that
> are merged into rhel7 already.  Hmm, bug 1038603 is still in POST, looks
> like not yet ..

Thanks for the explanation and welcome to back.

Best Regards,
Junyi
Comment 12 langfang 2014-01-21 10:16:50 UTC 
Reproduce this bug as follow version:
Host:
# uname -r
3.10.0-61.el7.x86_64
# rpm -q qemu-kvm
qemu-kvm-1.5.3-21.el7.x86_64
#rpm -q seabios
seabios-1.7.2.2-4.el7.x86_64

# ls -l /usr/share/seabios
total 128
-rw-r--r--. 1 root root 131072 Nov  5 09:25 bios.bin

verify this bug on latest version:
Host
# rpm -q qemu-kvm
qemu-kvm-1.5.3-38.el7.x86_64
seabios-1.7.2.2-9.el7.x86_64

Steps:
# ls -l /usr/share/seabios
total 384
-rw-r--r--. 1 root root 262144 Jan 15 14:13 bios-256k.bin
-rw-r--r--. 1 root root 131072 Jan 15 14:13 bios.bin


Addtional test on latest version test:

*senaro 1)

 1.Boot guest with "-M rhel6.5.0/rhel6.4.0/rhel6.3.0/rhel6.2.0/rhel6.1.0/rhel6.0.0"
 2.(qemu)info roms

Results:
(qemu) info roms
fw=genroms/kvmvapic.bin size=0x002400 name="kvmvapic.bin"
addr=00000000fffe0000 size=0x020000 mem=rom name="bios.bin"---->using bios.bin

*senaro 2)

  1.Boot guest with "-M pc/pc-i440fx-rhel7.0.0/q35/pc-q35-rhel7.0.0
  
Results:
(qemu) info roms
/rom@genroms/kvmvapic.bin size=0x002400 name="kvmvapic.bin"
addr=00000000fffc0000 size=0x040000 mem=rom name="bios-256k.bin"--->using bios-256k.bin
/rom@etc/acpi/tables size=0x003000 name="etc/acpi/tables"
/rom@etc/table-loader size=0x001000 name="etc/table-loader"

According to above test ,this bug has been fixed.
Comment 14 Ludek Smid 2014-06-13 11:15:36 UTC 
This request was resolved in Red Hat Enterprise Linux 7.0.

Contact your manager or support representative in case you have further questions about the request.