Bug 1038748

Summary:	Web interface should update changed fields only
Product:	[Community] Bugzilla	Reporter:	Jiri Denemark <jdenemar>
Component:	Bugzilla General	Assignee:	PnT DevOps Devs <hss-ied-bugs>
Status:	CLOSED WONTFIX	QA Contact:	tools-bugs <tools-bugs>
Severity:	high	Docs Contact:
Priority:	unspecified
Version:	4.4	CC:	jmcdonal, rjoost
Target Milestone:	---
Target Release:	---
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:		Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2013-12-24 02:43:51 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:

Description Jiri Denemark 2013-12-05 18:11:13 UTC

Description of problem:

Everytime I hit "Save Changes" button in bugzilla web interface, it seems the complete state of the bug as shown by the web interface is sent to bugzilla server and the bug is updated to that state. As a result of this, two independent updates conflict with each other even though different fields were changed.

If I'm "lucky", I'll get an insane mid-air collision warning and by hitting "submit my changes anyway", the other changes are undone even though I changed different fields.

If I'm even less lucky, changes made while I was updating a bug will be silently reverted (for example, if someone sets *_ack+ flag, it will be reset to *_ack? which is more than annoying).

Version-Release number of selected component (if applicable):

4.4.1011

How reproducible:

100%

Steps to Reproduce:
1. open a bug in two browser windows
2. change something in one window and save changes
3. change something else in the other window and save changes

Expected results:

"Save changes" should only save changes and nothing else. Thus independent updates of different fields should just work. In other words, it should work similarly to bugzilla RPC or the intrface for changing multiple bugs at once.

Additional info:

Technically, it should be pretty easy to do. The form can just send both the original values and the updated values and the cgi script can remove all unchanged fields before updating bugzilla database.

Comment 1 Jason McDonald 2013-12-06 03:35:57 UTC

I think this is a request that would be better filed with the upstream Bugzila project (https://bugzilla.mozilla.org/enter_bug.cgi?product=bugzilla).

This is quite a signoificnat code change and making such a change in Red Hat's customized version would be a big chunk of custom code to carry, test and maintain.  It would also make it harder to sync with upstream changes due to the many additional conflicts that would exist in the code.

I'm also not quite convinced that mid-air collisions should be happening very often, unless you have bugs open for a long time before submitting changesm in which case it would be wise to refresh the page before making changes.

Despite being a heavy RH Bugzilla user, I've only hit the mid-air collision screen two or three times in the last year.

Comment 2 Jason McDonald 2013-12-24 02:43:51 UTC

Closing this report for now. Feel free to file this issue with the upstream Bugzilla project.