Bug 1038817

This is a re-review request for a package rename.
Old package names are mate-file-manager-image-converter, mate-file-manager-open-terminal, mate-file-manager-sendto and mate-file-manager-share
Note, this affect only rawhide, f18/19/20 will use old packages until there EOL.

updated sources:
Spec URL: http://raveit65.fedorapeople.org/Mate/SPECS/caja-extensions.spec
SRPM URL: http://raveit65.fedorapeople.org/Mate/SRPM/caja-extensions-1.7.1-0.2.git298c725.fc21.src.rpm

* Fri Dec 06 2013 Wolfgang Ulbrich <chat-to-me> - 1.7.1-0.2.git298c725
- fix all the macro-in-comment warnings
- add versioned provides for the obsoleted packages
- remove NEWS, zero-length
- fix spelling-errors

Spec URL: http://raveit65.fedorapeople.org/Mate/SPECS/caja-extensions.spec
SRPM URL: http://raveit65.fedorapeople.org/Mate/SRPM/caja-extensions-1.7.1-0.3.git298c725.fc21.src.rpm

* Sat Dec 14 2013 Wolfgang Ulbrich <chat-to-me> - 1.7.0-0.3.git298c725
- remove isa tags from obsoletes/provides

Looks good, approved.


Package Review
==============

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed



===== MUST items =====

C/C++:
[ ]: Package does not contain kernel modules.
[ ]: Package contains no static executables.
[ ]: Development (unversioned) .so files in -devel subpackage, if present.
     Note: Unversioned so-files in private %_libdir subdirectory (see
     attachment). Verify they are not in ld path.
[x]: Header files in -devel subpackage, if present.
[x]: Package does not contain any libtool archives (.la)
[x]: Rpath absent or only used for internal libs.

Generic:
[ ]: Package is licensed with an open-source compatible license and meets
     other legal requirements as defined in the legal section of Packaging
     Guidelines.
[ ]: License field in the package spec file matches the actual license.
     Note: Checking patched sources after %prep for licenses. Licenses found:
     "*No copyright* GPL (v2 or later)", "GPL (v2 or later)", "Unknown or
     generated". 4 files have unknown license. Detailed output of licensecheck
     in /home/dan/fedora-review/1038817-caja-extensions/licensecheck.txt
[ ]: License file installed when any subpackage combination is installed.
[ ]: Package must own all directories that it creates.
     Note: Directories without known owners: /usr/share/gtk-doc, /usr/share
     /gtk-doc/html
[ ]: Package does not own files or directories owned by other packages.
     Note: Dirs in package are owned also by: /usr/share/gtk-doc/html/caja-
     sendto(mate-file-manager-sendto), /usr/lib64/caja-sendto(mate-file-
     manager-sendto), /usr/include/caja-sendto(mate-file-manager-sendto-
     devel), /usr/lib64/caja-sendto/plugins(mate-file-manager-sendto)
[ ]: %build honors applicable compiler flags or justifies otherwise.
[ ]: Package contains no bundled libraries without FPC exception.
[ ]: Changelog in prescribed format.
[ ]: Sources contain only permissible code or content.
[ ]: %config files are marked noreplace or the reason is justified.
     Note: No (noreplace) in %config /etc/samba/caja-share-smb.conf.example
[ ]: Package contains desktop file if it is a GUI application.
[ ]: Development files must be in a -devel package
[ ]: Package uses nothing in %doc for runtime.
[ ]: glib-compile-schemas is run in %postun and %posttrans if package has
     *.gschema.xml files.
     Note: gschema file(s) in caja-open-terminal, caja-sendto
[ ]: The spec file handles locales properly.
[ ]: Package consistently uses macros (instead of hard-coded directory names).
[ ]: Package is named according to the Package Naming Guidelines.
[ ]: Package does not generate any conflict.
[ ]: Package obeys FHS, except libexecdir and /usr/target.
[ ]: If the package is a rename of another package, proper Obsoletes and
     Provides are present.
[ ]: Requires correct, justified where necessary.
[ ]: Spec file is legible and written in American English.
[ ]: Package contains systemd file(s) if in need.
[ ]: Useful -debuginfo package or justification otherwise.
[ ]: Package is not known to require an ExcludeArch tag.
[ ]: Large documentation must go in a -doc subpackage. Large could be size
     (~1MB) or number of files.
     Note: Documentation size is 30720 bytes in 4 files.
[ ]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least one
     supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
     Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the license(s)
     in its own file, then that file, containing the text of the license(s)
     for the package is included in %doc.
[x]: Package requires other packages for directories it uses.
[x]: All build dependencies are listed in BuildRequires, except for any that
     are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
     beginning of %install.
[x]: Each %files section contains %defattr if rpm < 4.4
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install' ' DESTDIR=... doesn't
     work.
[x]: Package is named using only allowed ASCII characters.
[x]: No %config files under /usr.
[x]: Package do not use a name that already exist
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as provided
     in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
     %{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local

===== SHOULD items =====

Generic:
[ ]: If the source package does not include license text(s) as a separate file
     from upstream, the packager SHOULD query upstream to include it.
[ ]: Final provides and requires are sane (see attachments).
[ ]: Fully versioned dependency in subpackages if applicable.
     Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in caja-
     extensions-common , caja-image-converter , caja-open-terminal , caja-
     sendto , caja-sendto-devel , caja-share , caja-beesu
[ ]: Package functions as described.
[ ]: Latest version is packaged.
[ ]: Package does not include license text files separate from upstream.
[ ]: Patches link to upstream bugs/comments/lists or are otherwise justified.
[ ]: Scriptlets must be sane, if used.
[ ]: Description and summary sections in the package spec file contains
     translations for supported Non-English languages, if available.
[ ]: Package should compile and build into binary rpms on all supported
     architectures.
[ ]: %check is present and all tests pass.
[ ]: Packages should try to preserve timestamps of original installed files.
[x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file
[x]: Sources can be downloaded from URI in Source: tag
[x]: Reviewer should test that the package builds in mock.
[x]: Buildroot is not present
[x]: Package has no %clean section with rm -rf %{buildroot} (or
     $RPM_BUILD_ROOT)
[x]: Dist tag is present (not strictly required in GL).
[x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin.
[x]: Uses parallel make %{?_smp_mflags} macro.
[x]: The placement of pkgconfig(.pc) files are correct.
[x]: SourceX tarball generation or download is documented.
[x]: SourceX is a working URL.
[x]: Spec use %global instead of %define unless justified.

===== EXTRA items =====

Generic:
[x]: Rpmlint is run on all installed packages.
     Note: There are rpmlint messages (see attachment).
[x]: Large data in /usr/share should live in a noarch subpackage if package is
     arched.
[x]: Spec file according to URL is the same as in SRPM.


Rpmlint
-------
Checking: caja-extensions-common-1.7.1-0.3.git298c725.fc21.noarch.rpm
          caja-image-converter-1.7.1-0.3.git298c725.fc21.x86_64.rpm
          caja-open-terminal-1.7.1-0.3.git298c725.fc21.x86_64.rpm
          caja-sendto-1.7.1-0.3.git298c725.fc21.x86_64.rpm
          caja-sendto-devel-1.7.1-0.3.git298c725.fc21.x86_64.rpm
          caja-share-1.7.1-0.3.git298c725.fc21.x86_64.rpm
          caja-beesu-1.7.1-0.3.git298c725.fc21.x86_64.rpm
          caja-extensions-1.7.1-0.3.git298c725.fc21.src.rpm
caja-image-converter.x86_64: W: no-documentation
caja-open-terminal.x86_64: W: no-documentation
caja-sendto-devel.x86_64: W: no-documentation
caja-share.x86_64: W: conffile-without-noreplace-flag /etc/samba/caja-share-smb.conf.example
caja-share.x86_64: W: no-documentation
caja-beesu.x86_64: W: no-documentation
caja-extensions.src: W: spelling-error %description -l en_US sendto -> send to, send-to, Townsend
8 packages and 0 specfiles checked; 0 errors, 7 warnings.




Rpmlint (installed packages)
----------------------------
# rpmlint caja-image-converter caja-beesu caja-share caja-sendto caja-extensions-common caja-sen 
dto-devel caja-open-terminal
caja-image-converter.x86_64: W: no-documentation
caja-beesu.x86_64: W: no-documentation
caja-share.x86_64: W: conffile-without-noreplace-flag /etc/samba/caja-share-smb.conf.example
caja-share.x86_64: W: no-documentation
caja-sendto-devel.x86_64: W: no-documentation
caja-open-terminal.x86_64: W: no-documentation
7 packages and 0 specfiles checked; 0 errors, 6 warnings.
# echo 'rpmlint-done:'



Requires
--------
caja-image-converter (rpmlib, GLIBC filtered):
    ImageMagick
    caja-extensions-common
    libatk-1.0.so.0()(64bit)
    libc.so.6()(64bit)
    libcairo.so.2()(64bit)
    libcaja-extension.so.1()(64bit)
    libfontconfig.so.1()(64bit)
    libfreetype.so.6()(64bit)
    libgdk-x11-2.0.so.0()(64bit)
    libgdk_pixbuf-2.0.so.0()(64bit)
    libgio-2.0.so.0()(64bit)
    libglib-2.0.so.0()(64bit)
    libgobject-2.0.so.0()(64bit)
    libgtk-x11-2.0.so.0()(64bit)
    libpango-1.0.so.0()(64bit)
    libpangocairo-1.0.so.0()(64bit)
    libpangoft2-1.0.so.0()(64bit)
    rtld(GNU_HASH)

caja-beesu (rpmlib, GLIBC filtered):
    beesu
    caja-extensions-common
    libatk-1.0.so.0()(64bit)
    libc.so.6()(64bit)
    libcairo.so.2()(64bit)
    libcaja-extension.so.1()(64bit)
    libfontconfig.so.1()(64bit)
    libfreetype.so.6()(64bit)
    libgdk-x11-2.0.so.0()(64bit)
    libgdk_pixbuf-2.0.so.0()(64bit)
    libgio-2.0.so.0()(64bit)
    libglib-2.0.so.0()(64bit)
    libgobject-2.0.so.0()(64bit)
    libgtk-x11-2.0.so.0()(64bit)
    libpango-1.0.so.0()(64bit)
    libpangocairo-1.0.so.0()(64bit)
    libpangoft2-1.0.so.0()(64bit)
    rtld(GNU_HASH)

caja-share (rpmlib, GLIBC filtered):
    caja-extensions-common
    config(caja-share)
    libatk-1.0.so.0()(64bit)
    libc.so.6()(64bit)
    libcairo.so.2()(64bit)
    libcaja-extension.so.1()(64bit)
    libfontconfig.so.1()(64bit)
    libfreetype.so.6()(64bit)
    libgdk-x11-2.0.so.0()(64bit)
    libgdk_pixbuf-2.0.so.0()(64bit)
    libgio-2.0.so.0()(64bit)
    libglib-2.0.so.0()(64bit)
    libgobject-2.0.so.0()(64bit)
    libgtk-x11-2.0.so.0()(64bit)
    libpango-1.0.so.0()(64bit)
    libpangocairo-1.0.so.0()(64bit)
    libpangoft2-1.0.so.0()(64bit)
    libpthread.so.0()(64bit)
    rtld(GNU_HASH)
    samba

caja-sendto (rpmlib, GLIBC filtered):
    /bin/sh
    caja-extensions-common
    libatk-1.0.so.0()(64bit)
    libc.so.6()(64bit)
    libcairo.so.2()(64bit)
    libcaja-extension.so.1()(64bit)
    libdbus-1.so.3()(64bit)
    libdbus-glib-1.so.2()(64bit)
    libfontconfig.so.1()(64bit)
    libfreetype.so.6()(64bit)
    libgdk-x11-2.0.so.0()(64bit)
    libgdk_pixbuf-2.0.so.0()(64bit)
    libgio-2.0.so.0()(64bit)
    libglib-2.0.so.0()(64bit)
    libgmodule-2.0.so.0()(64bit)
    libgobject-2.0.so.0()(64bit)
    libgthread-2.0.so.0()(64bit)
    libgtk-x11-2.0.so.0()(64bit)
    libgupnp-1.0.so.4()(64bit)
    libpango-1.0.so.0()(64bit)
    libpangocairo-1.0.so.0()(64bit)
    libpangoft2-1.0.so.0()(64bit)
    libpthread.so.0()(64bit)
    rtld(GNU_HASH)

caja-extensions-common (rpmlib, GLIBC filtered):

caja-sendto-devel (rpmlib, GLIBC filtered):
    /usr/bin/pkg-config
    caja-extensions-common
    caja-sendto(x86-64)
    pkgconfig(glib-2.0)
    pkgconfig(gmodule-2.0)
    pkgconfig(gtk+-2.0)

caja-open-terminal (rpmlib, GLIBC filtered):
    /bin/sh
    caja-extensions-common
    libatk-1.0.so.0()(64bit)
    libc.so.6()(64bit)
    libcairo.so.2()(64bit)
    libcaja-extension.so.1()(64bit)
    libdconf.so.1()(64bit)
    libfontconfig.so.1()(64bit)
    libfreetype.so.6()(64bit)
    libgdk-x11-2.0.so.0()(64bit)
    libgdk_pixbuf-2.0.so.0()(64bit)
    libgio-2.0.so.0()(64bit)
    libglib-2.0.so.0()(64bit)
    libgobject-2.0.so.0()(64bit)
    libgtk-x11-2.0.so.0()(64bit)
    libmate-desktop-2.so.17()(64bit)
    libpango-1.0.so.0()(64bit)
    libpangocairo-1.0.so.0()(64bit)
    libpangoft2-1.0.so.0()(64bit)
    libstartup-notification-1.so.0()(64bit)
    rtld(GNU_HASH)



Provides
--------
caja-image-converter:
    caja-image-converter
    caja-image-converter(x86-64)
    libcaja-image-converter.so()(64bit)
    mate-file-manager-image-converter

caja-beesu:
    caja-beesu
    caja-beesu(x86-64)
    libcaja-gksu.so()(64bit)

caja-share:
    caja-share
    caja-share(x86-64)
    config(caja-share)
    libcaja-share.so()(64bit)
    mate-file-manager-share

caja-sendto:
    caja-sendto
    caja-sendto(x86-64)
    libcaja-sendto.so()(64bit)
    libnstburn.so()(64bit)
    libnstemailclient.so()(64bit)
    libnstgajim.so()(64bit)
    libnstpidgin.so()(64bit)
    libnstremovable_devices.so()(64bit)
    libnstupnp.so()(64bit)
    mate-file-manager-sendto

caja-extensions-common:
    caja-extensions-common

caja-sendto-devel:
    caja-sendto-devel
    caja-sendto-devel(x86-64)
    mate-file-manager-sendto-devel(x86-64)
    pkgconfig(caja-sendto)

caja-open-terminal:
    caja-open-terminal
    caja-open-terminal(x86-64)
    libcaja-open-terminal.so()(64bit)
    mate-file-manager-open-terminal



Unversioned so-files
--------------------
caja-image-converter: /usr/lib64/caja/extensions-2.0/libcaja-image-converter.so
caja-open-terminal: /usr/lib64/caja/extensions-2.0/libcaja-open-terminal.so
caja-sendto: /usr/lib64/caja-sendto/plugins/libnstburn.so
caja-sendto: /usr/lib64/caja-sendto/plugins/libnstemailclient.so
caja-sendto: /usr/lib64/caja-sendto/plugins/libnstgajim.so
caja-sendto: /usr/lib64/caja-sendto/plugins/libnstpidgin.so
caja-sendto: /usr/lib64/caja-sendto/plugins/libnstremovable_devices.so
caja-sendto: /usr/lib64/caja-sendto/plugins/libnstupnp.so
caja-sendto: /usr/lib64/caja/extensions-2.0/libcaja-sendto.so
caja-share: /usr/lib64/caja/extensions-2.0/libcaja-share.so
caja-beesu: /usr/lib64/caja/extensions-2.0/libcaja-gksu.so

Source checksums
----------------
http://raveit65.fedorapeople.org/Mate/git-upstream/caja-extensions-1.7.1.git298c725.tar.xz :
  CHECKSUM(SHA256) this package     : 817de498aa42a3778e1a9c49683fbe53e6cee3134a94549d65ade2a46feb609a
  CHECKSUM(SHA256) upstream package : 817de498aa42a3778e1a9c49683fbe53e6cee3134a94549d65ade2a46feb609a


Generated by fedora-review 0.5.0 (920221d) last change: 2013-08-30
Command line :/usr/bin/fedora-review -b 1038817
Buildroot used: fedora-rawhide-x86_64
Active plugins: Generic, Shell-api, C/C++
Disabled plugins: Java, Python, SugarActivity, Perl, R, PHP, Ruby
Disabled flags: EPEL5, EXARCH, DISTTAG

New Package SCM Request
=======================
Package Name: caja-extensions 
Short Description: Set of extensions for caja file manager
Owners: raveit65 vicodan
Branches:
InitialCC:

Note: branch is empty because other branches than rawhide will use old package name until releases are EOL.

Git done (by process-git-requests).

Package Change Request
======================
Package Name: caja-extensions
New Branches: f20
Owners: raveit65 vicodan
InitialCC:

Git done (by process-git-requests).