Bug 1038847
| Summary: | SizeNotPositiveError: spec= param must be >=0 - "1" as size of encrypted partition | ||||||||||||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Alexey Torkhov <atorkhov> | ||||||||||||||||||||||
| Component: | anaconda | Assignee: | Vratislav Podzimek <vpodzime> | ||||||||||||||||||||||
| Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> | ||||||||||||||||||||||
| Severity: | unspecified | Docs Contact: | |||||||||||||||||||||||
| Priority: | unspecified | ||||||||||||||||||||||||
| Version: | 20 | CC: | awilliam, bugzilla, g.kaviyarasu, jonathan, jsedlak, kparal, lnie, mruckman, robatino, vanmeeuwen+fedora, vpodzime | ||||||||||||||||||||||
| Target Milestone: | --- | ||||||||||||||||||||||||
| Target Release: | --- | ||||||||||||||||||||||||
| Hardware: | x86_64 | ||||||||||||||||||||||||
| OS: | Unspecified | ||||||||||||||||||||||||
| Whiteboard: | abrt_hash:fb855b364004d7af1cb7b6bcbc3285427e4c1e1632a22727969f5dca8001d282 AcceptedBlocker | ||||||||||||||||||||||||
| Fixed In Version: | anaconda-20.25.15-1.fc20 | Doc Type: | Bug Fix | ||||||||||||||||||||||
| Doc Text: | Story Points: | --- | |||||||||||||||||||||||
| Clone Of: | Environment: | ||||||||||||||||||||||||
| Last Closed: | 2013-12-13 05:33:41 UTC | Type: | --- | ||||||||||||||||||||||
| Regression: | --- | Mount Type: | --- | ||||||||||||||||||||||
| Documentation: | --- | CRM: | |||||||||||||||||||||||
| Verified Versions: | Category: | --- | |||||||||||||||||||||||
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |||||||||||||||||||||||
| Cloudforms Team: | --- | Target Upstream Version: | |||||||||||||||||||||||
| Embargoed: | |||||||||||||||||||||||||
| Bug Depends On: | |||||||||||||||||||||||||
| Bug Blocks: | 980656 | ||||||||||||||||||||||||
| Attachments: |
|
||||||||||||||||||||||||
Created attachment 833371 [details]
File: anaconda-tb
Created attachment 833372 [details]
File: anaconda.log
Created attachment 833373 [details]
File: environ
Created attachment 833374 [details]
File: journalctl
Created attachment 833375 [details]
File: lsblk_output
Created attachment 833376 [details]
File: nmcli_dev_list
Created attachment 833377 [details]
File: os_info
Created attachment 833378 [details]
File: program.log
Created attachment 833379 [details]
File: storage.log
Created attachment 833380 [details]
File: ifcfg.log
To reproduce: 1. Start installer, go to installation destination, select disks 2. Use LVM, enable encryption, select custom paritioning 3. Add new mount point, use / or /var or /home, enter 1 as capacity. It crashes after thinking... Adding as blocker, as per: Reject or disallow invalid disk and volume configurations without crashing. This could be a dup of bug 1013586. Regression from 20.25.12-1? Reproducing bug 1038847 according to comment 11. cmdline: /usr/bin/python /sbin/anaconda cmdline_file: initrd=initrd.img inst.stage2=hd:LABEL=Fedora\x2020-TC5\x20x86_64 quiet BOOT_IMAGE=vmlinuz hashmarkername: anaconda kernel: 3.11.10-300.fc20.x86_64 package: anaconda-20.25.14-1 product: Fedora reason: SizeNotPositiveError: spec= param must be >=0 release: Cannot get release name. version: 20-TC5 Discussed in 2013-12-09 Blocker Review meeting [1]. Voted as an AcceptedBlocker for violating the beta criteria "When using the custom partitioning flow, the installer must be able to: ... Reject or disallow invalid disk and volume configurations without crashing." [2] [1] http://meetbot.fedoraproject.org/fedora-blocker-review/2013-12-09/ [2] https://fedoraproject.org/wiki/Fedora_20_Beta_Release_Criteria#Custom_partitioning In what way are the partition sizes "weird"? https://www.happyassassin.net/extras/updates-1038847.img should be the updates.img to test this, if I did things right. Well, the update seems to fix the bug, but I hit a crash soon after. Follow Alexey's reproducer from c#11, note it doesn't crash, then: 4. Change the size of the / partition you created to something reasonable (I did 10GB, anaconda rounded to 9.99) 5. Add a partition named 'swap', don't enter a size Crashed. Filing the crash. Crash filed as #1040263. The crash can be reproduced much more simply with the updates.img applied - just enable encryption, go into custom partitioning, and try creating a partition without explicitly specifying a size. Looks like the patch didn't consider that case. I also tried dlehman's alternative patch - https://lists.fedorahosted.org/pipermail/anaconda-patches/2013-December/007755.html - but it doesn't seem to work, unless I screwed something up. I built the updates.img as https://www.happyassassin.net/extras/dlehman-1038847.img . I can't immediately see *why* the patch doesn't work, but it doesn't seem to. In bug 1038969 comment 12 there is updates.img that is supposed to fix this bug too. if i'm reading things right that likely has the same change as I tested in c#18, so I'd expect the same behaviour; but do go ahead and try it and see if you reproduce my results. Please try this updates.img: http://vpodzime.fedorapeople.org/f20_blockers_updates.img I tested it with updates image from comment 24 and it works. And problem from comment 18 was also OK. anaconda-20.25.15-1.fc20, python-blivet-0.23.9-1.fc20 has been submitted as an update for Fedora 20. https://admin.fedoraproject.org/updates/python-blivet-0.23.9-1.fc20,anaconda-20.25.15-1.fc20 20.25.15-1.fc20 works fine anaconda-20.25.15-1.fc20, python-blivet-0.23.9-1.fc20 has been pushed to the Fedora 20 stable repository. If problems still persist, please make note of it in this bug report. |
Description of problem: created /var partition with size "1" Version-Release number of selected component: anaconda-20.25.14-1.fc20.x86_64 The following was filed automatically by anaconda: anaconda 20.25.14-1 exception report Traceback (most recent call first): File "/usr/lib/python2.7/site-packages/blivet/size.py", line 96, in _parseSpec raise SizeNotPositiveError("spec= param must be >=0") File "/usr/lib/python2.7/site-packages/blivet/size.py", line 164, in __new__ self = Decimal.__new__(cls, value=_parseSpec(en_spec, False)) File "/usr/lib64/python2.7/site-packages/pyanaconda/ui/gui/spokes/lib/accordion.py", line 61, in selectorFromDevice size = Size(en_spec="%f MB" % device.size) File "/usr/lib64/python2.7/site-packages/pyanaconda/ui/gui/spokes/lib/accordion.py", line 176, in addSelector selector = selectorFromDevice(device, mountpoint=mountpoint) File "/usr/lib64/python2.7/site-packages/pyanaconda/ui/gui/spokes/custom.py", line 997, in _do_refresh mountpoint=mountpoint) File "/usr/lib64/python2.7/site-packages/pyanaconda/ui/gui/spokes/custom.py", line 2096, in on_add_clicked self._do_refresh(mountpointToShow=mountpoint or fstype) SizeNotPositiveError: spec= param must be >=0 Additional info: cmdline: /usr/bin/python /sbin/anaconda --liveinst --method=livecd:///dev/mapper/live-base cmdline_file: initrd=initrd0.img root=live:CDLABEL=Fedora-Live-KDE-x86_64-20-TC5 rootfstype=auto ro rd.live.image quiet rhgb rd.luks=0 rd.md=0 rd.dm=0 BOOT_IMAGE=vmlinuz0 executable: /sbin/anaconda hashmarkername: anaconda kernel: 3.11.10-300.fc20.x86_64 other involved packages: python-blivet-0.23.8-1.fc20.noarch product: Fedora release: Fedora release 20 (Heisenbug) type: anaconda version: 20