Bug 1038887

Summary: hwcert-backend: Dead loop occurs when trying to install require rpms if enable debug mode
Product: [Retired] Red Hat Hardware Certification Program Reporter: Dong Zhu <dZhu>
Component: Test Suite (harness)Assignee: Greg Nichols <gnichols>
Status: CLOSED CURRENTRELEASE QA Contact: Brian Brock <bbrock>
Severity: unspecified Docs Contact:
Priority: unspecified    
Version: 1.7CC: bbrock, gnichols, qcai, rlandry
Target Milestone: ---   
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: hwcert-client 1.7.0-20131210 Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2016-07-05 17:49:39 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Bug Depends On:    
Bug Blocks: 1016295    
Attachments:
Description Flags
patch fix the dead loop issue when trying to install require rpms if enable debug mode gnichols: review-

Description Dong Zhu 2013-12-06 03:42:54 UTC 
Description of problem:
Run the fowllowing command:
hwcert-backend run --test memory --debug high --mode auto

and got the following information:
......
start checkRequireRPMS...
Checking for additional required packages based on the test plan:
cdrom requires dvd+rw-tools, genisoimage, wodim, util-linux
dvd requires dvd+rw-tools, genisoimage, wodim, util-linux
USB2 requires usbutils
1GigEthernet requires ethtool
Ethernet requires ethtool
Ethernet requires ethtool
Ethernet requires ethtool
fv_core requires libvirt, libvirt-python, virt-install, qemu-kvm, qemu-kvm-tools, seabios, seabios-bin, ipxe-roms-qemu, qemu-kvm-common
fv_memory requires libvirt, libvirt-python, virt-install, qemu-kvm, qemu-kvm-tools, seabios, seabios-bin, ipxe-roms-qemu, qemu-kvm-common
fv_network requires libvirt, libvirt-python, virt-install, qemu-kvm, qemu-kvm-tools, seabios, seabios-bin, ipxe-roms-qemu, qemu-kvm-common
fv_storage requires libvirt, libvirt-python, virt-install, qemu-kvm, qemu-kvm-tools, seabios, seabios-bin, ipxe-roms-qemu, qemu-kvm-common
profiler requires oprofile
video requires xorg-x11-apps, xorg-x11-utils, glx-utils, xorg-x11-server-Xorg, xorg-x11-xinit
info requires kabi-whitelists, policycoreutils
kdump requires kexec-tools, crash, kernel-debuginfo
kdump requires kexec-tools, crash, kernel-debuginfo
Checking installed rpms:
package xorg-x11-apps is not installed
kernel-debuginfo-3.10.0-42.el7.x86_64
seabios-1.7.2.2-4.el7.x86_64
kexec-tools-2.0.4-12.el7.x86_64
package kabi-whitelists is not installed
xorg-x11-server-Xorg-1.14.2-11.el7.x86_64
package dvd+rw-tools is not installed
libvirt-python-1.1.1-11.el7.x86_64
ethtool-3.8-1.el7.x86_64
crash-7.0.2-2.el7.x86_64
libvirt-1.1.1-11.el7.x86_64
xorg-x11-xinit-1.3.2-8.el7.x86_64
package virt-install, is not installed
package qemu-kvm, is not installed
qemu-kvm-tools-1.5.3-14.el7.x86_64
glx-utils-8.1.0-3.el7.x86_64
util-linux-2.23.2-6.el7.x86_64
qemu-kvm-common-1.5.3-14.el7.x86_64
xorg-x11-utils-7.5-9.el7.x86_64
seabios-bin-1.7.2.2-4.el7.noarch
ipxe-roms-qemu-20130517-1.gitc4bce43.el7.noarch
usbutils-007-2.el7.x86_64
policycoreutils-2.1.14-88.el7.x86_64
genisoimage-1.1.11-20.el7.x86_64
oprofile-0.9.9-2.el7.x86_64
wodim-1.1.11-20.el7.x86_64
Loaded plugins: product-id, subscription-manager
No package xorg-x11-apps available.
No package kabi-whitelists available.
No package dvd+rw-tools available.
No package virt-install, available.
No package qemu-kvm, available.
Package 10:qemu-kvm-tools-1.5.3-14.el7.x86_64 already installed and latest version
Nothing to do
The following packages are required for testing:
xorg-x11-apps, kabi-whitelists, dvd+rw-tools, virt-install, qemu-kvm, qemu-kvm-tools
Rechecking required rpms
Checking installed rpms:

......

Dead loop occured here if I enabled the debug mode and some require rpms can't be installed.

Version-Release number of selected component (if applicable):
hwcert-client-1.7.0-20131203.el7.noarch
Comment 1 Dong Zhu 2013-12-12 06:03:40 UTC 
Created attachment 835624 [details]
patch fix the dead loop issue when trying to install require rpms if enable debug mode
Comment 2 Greg Nichols 2013-12-19 16:05:54 UTC 
I can't reproduce this bug in hwcert-client 1.7.0-20131210.  It's a result of bug 1038345 - the added comma on some of the package names created a situation where rpm -q didn't find the package, but yum found it to be already installed, returning 0.

This created the loop because in mode auto, the iteration of installs only stops when yum fails to install the package.

In addition, the problem with the proposed patch is that it will never try to install packages in --mode auto, which will cause multiple tests to fail.
Comment 4 Brian Brock 2014-02-10 21:16:09 UTC 
marking as verified in hwcert-client-1.7.0-20140207.el7

disabled the yum repo that contained dvd+rw-tools, uninstalled the package, ran `clean`, and then `plan`:

[tail of output]
This system is not registered to Red Hat Subscription Management. You can use subscription-manager to register.
No package dvd+rw-tools available.
Error: Nothing to do
Error: could not install required packages.
saved test plan to /var/hwcert/results.xml

I get the same result without the "--debug low" flag.  A valid plan is created, and a subsequent "run -t info" will attempt to run without complaint.