Bug 1039335

Two problems:
[!]: Package must own all directories that it creates.
     Note: Directories without known owners: /usr/share/glite-lb-logger
[!]: Package does not own files or directories owned by other packages.
     Note: Dirs in package are owned also by: /var/lib/glite(glite-px-
     proxyrenewal)

Rest looks good!

(In reply to Sandro Mani from comment #1)
> Two problems:
> [!]: Package must own all directories that it creates.
>      Note: Directories without known owners: /usr/share/glite-lb-logger

OK, fixed.

> [!]: Package does not own files or directories owned by other packages.
>      Note: Dirs in package are owned also by: /var/lib/glite(glite-px-
>      proxyrenewal)
> 

This is the case described here:

http://fedoraproject.org/wiki/Packaging:Guidelines#The_directory_is_owned_by_a_package_which_is_not_required_for_your_package_to_function

/var/lib/glite directory is required in both packages (glite-px-proxyrenewal and glite-lb-logger), but the packages don't depend on each other.

(Alternative solution would be some glite-filesystem with /var/lib/glite or glite-user package handling both glite user and /var/lib/glite directory, but I would prefer not to do that. :-))


New version:

Spec URL: http://scientific.zcu.cz/fedora/glite-lb-logger-2.4.21-2/glite-lb-logger.spec
SRPM URL: http://scientific.zcu.cz/fedora/glite-lb-logger-2.4.21-2/glite-lb-logger-2.4.21-2.fc21.src.rpm

* Mon Jan 13 2014 František Dvořák <valtri.cz> - 2.4.21-2
- Missing directory
- Enable hardened build
- EPEL 7 support

All ok, approved!

Package Review
==============

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed



===== MUST items =====

C/C++:
[x]: Package does not contain kernel modules.
[x]: Package contains no static executables.
[x]: Header files in -devel subpackage, if present.
[x]: Package does not contain any libtool archives (.la)
[x]: Rpath absent or only used for internal libs.

Generic:
[x]: Package is licensed with an open-source compatible license and meets
     other legal requirements as defined in the legal section of Packaging
     Guidelines.
[x]: License field in the package spec file matches the actual license.
     Note: Checking patched sources after %prep for licenses. Licenses found:
     "Apache (v2.0)", "Unknown or generated". 1 files have unknown license.
     Detailed output of licensecheck in /home/sandro/.Data/Desktop/1039335
     -glite-lb-logger/licensecheck.txt
[x]: License file installed when any subpackage combination is installed.
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[!]: Package does not own files or directories owned by other packages.
	-> Ok due to http://fedoraproject.org/wiki/Packaging:Guidelines#The_directory_is_owned_by_a_package_which_is_not_required_for_your_package_to_function
[x]: %build honors applicable compiler flags or justifies otherwise.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[x]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
     Provides are present.
[?]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Useful -debuginfo package or justification otherwise.
[x]: Package is not known to require an ExcludeArch tag.
[-]: Large documentation must go in a -doc subpackage. Large could be size
     (~1MB) or number of files.
     Note: Documentation size is 30720 bytes in 2 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least one
     supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
     Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the license(s)
     in its own file, then that file, containing the text of the license(s)
     for the package is included in %doc.
[x]: All build dependencies are listed in BuildRequires, except for any that
     are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
     beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install' ' DESTDIR=... doesn't
     work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package do not use a name that already exist
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as provided
     in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
     %{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local

===== SHOULD items =====

Generic:
[-]: If the source package does not include license text(s) as a separate file
     from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[?]: Package functions as described.
[?]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[x]: Patches link to upstream bugs/comments/lists or are otherwise justified.
[-]: Description and summary sections in the package spec file contains
     translations for supported Non-English languages, if available.
[?]: Package should compile and build into binary rpms on all supported
     architectures.
[-]: %check is present and all tests pass.
[x]: Packages should try to preserve timestamps of original installed files.
[x]: Files in /run, var/run and /var/lock uses tmpfiles.d when appropriate
[x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file
[x]: Sources can be downloaded from URI in Source: tag
[x]: Reviewer should test that the package builds in mock.
[x]: Buildroot is not present
[x]: Package has no %clean section with rm -rf %{buildroot} (or
     $RPM_BUILD_ROOT)
[x]: Dist tag is present (not strictly required in GL).
[x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin.
[x]: Fully versioned dependency in subpackages if applicable.
[x]: SourceX is a working URL.
[x]: Spec use %global instead of %define unless justified.

===== EXTRA items =====

Generic:
[x]: Rpmlint is run on all installed packages.
     Note: There are rpmlint messages (see attachment).
[x]: Large data in /usr/share should live in a noarch subpackage if package is
     arched.
[x]: Package should not use obsolete m4 macros
[x]: Spec file according to URL is the same as in SRPM.


Rpmlint
-------
Checking: glite-lb-logger-2.4.21-2.fc21.x86_64.rpm
          glite-lb-logger-devel-2.4.21-2.fc21.x86_64.rpm
          glite-lb-logger-2.4.21-2.fc21.src.rpm
glite-lb-logger.x86_64: W: summary-not-capitalized C gLite Logging and Bookkeeping local-logger and inter-logger
glite-lb-logger.x86_64: W: spelling-error %description -l en_US logd -> gold, logs, log
glite-lb-logger.x86_64: W: spelling-error %description -l en_US interlogd -> interloped, interloper
glite-lb-logger.x86_64: W: spelling-error %description -l en_US notif -> motif, notify, not if
glite-lb-logger.x86_64: W: only-non-binary-in-usr-lib
glite-lb-logger.x86_64: W: non-standard-uid /var/lib/glite glite
glite-lb-logger.x86_64: W: non-standard-gid /var/lib/glite glite
glite-lb-logger.x86_64: W: non-standard-uid /var/spool/glite glite
glite-lb-logger.x86_64: W: non-standard-gid /var/spool/glite glite
glite-lb-logger.x86_64: W: non-standard-uid /var/run/glite glite
glite-lb-logger.x86_64: W: non-standard-gid /var/run/glite glite
glite-lb-logger.x86_64: W: non-standard-uid /var/spool/glite/lb-locallogger glite
glite-lb-logger.x86_64: W: non-standard-gid /var/spool/glite/lb-locallogger glite
glite-lb-logger.x86_64: E: non-standard-dir-perm /var/spool/glite/lb-locallogger 0775L
glite-lb-logger.x86_64: W: non-standard-uid /var/spool/glite/lb-proxy glite
glite-lb-logger.x86_64: W: non-standard-gid /var/spool/glite/lb-proxy glite
glite-lb-logger.x86_64: W: non-standard-uid /var/spool/glite/lb-notif glite
glite-lb-logger.x86_64: W: non-standard-gid /var/spool/glite/lb-notif glite
glite-lb-logger.x86_64: W: no-manual-page-for-binary glite-lb-notif-interlogd
glite-lb-logger.x86_64: W: no-manual-page-for-binary glite-lb-proxy-interlogd
glite-lb-logger-devel.x86_64: W: no-documentation
glite-lb-logger.src: W: summary-not-capitalized C gLite Logging and Bookkeeping local-logger and inter-logger
glite-lb-logger.src: W: spelling-error %description -l en_US logd -> gold, logs, log
glite-lb-logger.src: W: spelling-error %description -l en_US interlogd -> interloped, interloper
glite-lb-logger.src: W: spelling-error %description -l en_US notif -> motif, notify, not if
3 packages and 0 specfiles checked; 1 errors, 24 warnings.




Rpmlint (installed packages)
----------------------------
# rpmlint glite-lb-logger-devel glite-lb-logger
glite-lb-logger-devel.x86_64: W: no-documentation
glite-lb-logger.x86_64: W: summary-not-capitalized C gLite Logging and Bookkeeping local-logger and inter-logger
glite-lb-logger.x86_64: W: spelling-error %description -l en_US logd -> gold, logs, log
glite-lb-logger.x86_64: W: spelling-error %description -l en_US interlogd -> interloped, interloper
glite-lb-logger.x86_64: W: spelling-error %description -l en_US notif -> motif, notify, not if
glite-lb-logger.x86_64: W: only-non-binary-in-usr-lib
glite-lb-logger.x86_64: W: non-standard-uid /var/lib/glite glite
glite-lb-logger.x86_64: W: non-standard-gid /var/lib/glite glite
glite-lb-logger.x86_64: W: non-standard-uid /var/spool/glite glite
glite-lb-logger.x86_64: W: non-standard-gid /var/spool/glite glite
glite-lb-logger.x86_64: W: non-standard-uid /var/run/glite glite
glite-lb-logger.x86_64: W: non-standard-gid /var/run/glite glite
glite-lb-logger.x86_64: W: non-standard-uid /var/spool/glite/lb-locallogger glite
glite-lb-logger.x86_64: W: non-standard-gid /var/spool/glite/lb-locallogger glite
glite-lb-logger.x86_64: E: non-standard-dir-perm /var/spool/glite/lb-locallogger 0775L
glite-lb-logger.x86_64: W: non-standard-uid /var/spool/glite/lb-proxy glite
glite-lb-logger.x86_64: W: non-standard-gid /var/spool/glite/lb-proxy glite
glite-lb-logger.x86_64: W: non-standard-uid /var/spool/glite/lb-notif glite
glite-lb-logger.x86_64: W: non-standard-gid /var/spool/glite/lb-notif glite
glite-lb-logger.x86_64: W: no-manual-page-for-binary glite-lb-notif-interlogd
glite-lb-logger.x86_64: W: no-manual-page-for-binary glite-lb-proxy-interlogd
2 packages and 0 specfiles checked; 1 errors, 20 warnings.
# echo 'rpmlint-done:'



Requires
--------
glite-lb-logger-devel (rpmlib, GLIBC filtered):
    glite-lb-common-devel(x86-64)
    glite-lb-logger(x86-64)
    glite-lbjp-common-gss-devel(x86-64)
    glite-lbjp-common-log-devel(x86-64)

glite-lb-logger (rpmlib, GLIBC filtered):
    /bin/sh
    libc.so.6()(64bit)
    libdl.so.2()(64bit)
    libglite_jobid.so.2()(64bit)
    libglite_lb_common.so.16()(64bit)
    libglite_lbu_log.so.1()(64bit)
    libglite_lbu_trio.so.2()(64bit)
    libglite_security_gss.so.9()(64bit)
    libpthread.so.0()(64bit)
    rtld(GNU_HASH)
    systemd



Provides
--------
glite-lb-logger-devel:
    glite-lb-logger-devel
    glite-lb-logger-devel(x86-64)

glite-lb-logger:
    glite-lb-logger
    glite-lb-logger(x86-64)



Source checksums
----------------
http://scientific.zcu.cz/emi/emi.lb.logger/glite-lb-logger-2.4.21.tar.gz :
  CHECKSUM(SHA256) this package     : be365960fa1d20540f37d46b1d76821c6ad45b02bd2dcbbda92adcaa38526964
  CHECKSUM(SHA256) upstream package : be365960fa1d20540f37d46b1d76821c6ad45b02bd2dcbbda92adcaa38526964


Generated by fedora-review 0.5.1 (bb9bf27) last change: 2013-12-13
Command line :/usr/bin/fedora-review -b 1039335
Buildroot used: fedora-rawhide-x86_64
Active plugins: Generic, Shell-api, C/C++
Disabled plugins: Java, Python, fonts, SugarActivity, Ocaml, Perl, Haskell, R, PHP, Ruby
Disabled flags: EXARCH, EPEL5, BATCH, DISTTAG

New Package SCM Request
=======================
Package Name: glite-lb-logger
Short Description: gLite Logging and Bookkeeping local-logger and inter-loggers
Owners: valtri
Branches: f19 f20 el6
InitialCC:

Git done (by process-git-requests).

glite-lb-logger-2.4.21-2.fc20 has been submitted as an update for Fedora 20.
https://admin.fedoraproject.org/updates/glite-lb-logger-2.4.21-2.fc20

glite-lb-logger-2.4.21-2.fc19 has been submitted as an update for Fedora 19.
https://admin.fedoraproject.org/updates/glite-lb-logger-2.4.21-2.fc19

glite-lb-logger-2.4.21-2.el6 has been submitted as an update for Fedora EPEL 6.
https://admin.fedoraproject.org/updates/glite-lb-logger-2.4.21-2.el6

glite-lb-logger-2.4.21-2.fc20 has been pushed to the Fedora 20 testing repository.

glite-lb-logger-2.4.21-2.el6 has been pushed to the Fedora EPEL 6 stable repository.

glite-lb-logger-2.4.21-2.fc19 has been pushed to the Fedora 19 stable repository.

glite-lb-logger-2.4.21-2.fc20 has been pushed to the Fedora 20 stable repository.