Bug 1039555
| Summary: | Latest version of librabbitmq has a bogus pkg-config file | ||||||
|---|---|---|---|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Tomas Heinrich <theinric> | ||||
| Component: | librabbitmq | Assignee: | Remi Collet <fedora> | ||||
| Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> | ||||
| Severity: | medium | Docs Contact: | |||||
| Priority: | unspecified | ||||||
| Version: | 20 | CC: | fedora, jose.p.oliveira.oss, pvrabec | ||||
| Target Milestone: | --- | ||||||
| Target Release: | --- | ||||||
| Hardware: | All | ||||||
| OS: | Unspecified | ||||||
| Whiteboard: | |||||||
| Fixed In Version: | librabbitmq-0.4.1-3.fc20 | Doc Type: | Bug Fix | ||||
| Doc Text: | Story Points: | --- | |||||
| Clone Of: | Environment: | ||||||
| Last Closed: | 2014-01-16 07:18:05 UTC | Type: | Bug | ||||
| Regression: | --- | Mount Type: | --- | ||||
| Documentation: | --- | CRM: | |||||
| Verified Versions: | Category: | --- | |||||
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |||||
| Cloudforms Team: | --- | Target Upstream Version: | |||||
| Embargoed: | |||||||
| Attachments: |
|
||||||
|
Description
Tomas Heinrich
2013-12-09 12:56:33 UTC
Reported upstream https://github.com/alanxz/rabbitmq-c/issues/154 Is deleting those lines enough as a temporary workaround ? (waiting for upstream feedback). After commenting out those two, the compilation finishes correctly. Not sure yet whether there's something critical missing from the .pc file in this case. Here's the upstream commit that changed the .pc file:
commit ac88db56d3dd1827072d54e6846fc82069e8f05a
Author: Alan Antonuk <alan.antonuk>
Date: Tue Aug 20 17:19:06 2013 -0700
CMake: correct generation of librabbitmq.pc
Fix CMake code that substitutes librabbitmq.pc to be correct.
It only touches CMakeLists.txt, not configure.ac. The specfile only calls autoreconf and configure in %build, so this might be the problem.
Created attachment 844150 [details]
A patch to change the buildsystem from autotools to cmake
Here's a patch to use cmake instead of autotools. This should fix the issue and be a good change in general as the upstream seems to prefer cmake.
The spec file was adjusted to work with cmake and there are also couple of minor changes.
cmake handles RPATH during install and the calls to 'sed' to get rid of it won't be necessary. Though I still don't understand why calling 'autoreconf' was needed.
I prefer to not use cmake for now (mostly because in don't work in EPEL). autoconf stuff is now fixed upstream https://github.com/alanxz/rabbitmq-c/commit/02d5c58ae4b9bbaa6201990ff5066f0db561d231 librabbitmq-0.4.1-2.fc20 has been submitted as an update for Fedora 20. https://admin.fedoraproject.org/updates/librabbitmq-0.4.1-2.fc20 Package librabbitmq-0.4.1-2.fc20: * should fix your issue, * was pushed to the Fedora 20 testing repository, * should be available at your local mirror within two days. Update it with: # su -c 'yum update --enablerepo=updates-testing librabbitmq-0.4.1-2.fc20' as soon as you are able to. Please go to the following url: https://admin.fedoraproject.org/updates/FEDORA-2014-0055/librabbitmq-0.4.1-2.fc20 then log in and leave karma (feedback). Still broken, it seems: $ cat librabbitmq.pc prefix=/usr exec_prefix=/usr libdir=/usr/lib includedir=/usr/include Name: rabbitmq-c Description: An AMQP 0-9-1 client library Version: 0.4.1 URL: https://github.com/alanxz/rabbitmq-c Requires.private: @requires_private@ Libs: -L${libdir} -lrabbitmq Libs.private: @libs_private@ CFlags: -I${includedir} Both librabbitmq-devel-0.4.1-2.fc20.i686.rpm and x86_64. Thanks for checking... Patch not applied... :( Should be ok now http://pkgs.fedoraproject.org/cgit/librabbitmq.git/commit/?id=3b0b53d1bd1c85dde03cc7db462ae5a494d47b43 Great, thanks. Package librabbitmq-0.4.1-3.fc20: * should fix your issue, * was pushed to the Fedora 20 testing repository, * should be available at your local mirror within two days. Update it with: # su -c 'yum update --enablerepo=updates-testing librabbitmq-0.4.1-3.fc20' as soon as you are able to. Please go to the following url: https://admin.fedoraproject.org/updates/FEDORA-2014-0055/librabbitmq-0.4.1-3.fc20 then log in and leave karma (feedback). librabbitmq-0.4.1-3.fc20 has been pushed to the Fedora 20 stable repository. If problems still persist, please make note of it in this bug report. |