Bug 1039664

Here's the private method that we can add to RHQControl to check to see if the agent RPM is installed - it will be called almost as soon as rhqctl is invoked.

===

    private void logWarningIfAgentRPMIsInstalled(ControlCommand command) {
        // we only care about warning if the user is installing or upgrading; otherwise, just return silently
        if (!"install".equalsIgnoreCase(command.getName()) && (!"upgrade".equalsIgnoreCase(command.getName()))) {
            return;
        }

        // see if we can find an RPM installation somewhere.
        boolean rpmInstalled;
        File rpmParentLocation = new File("/usr/share");
        File[] rpms = rpmParentLocation.listFiles(new FilenameFilter() {
            @Override
            public boolean accept(File dir, String name) {
                if (name.startsWith("jboss-on-")) {
                    File jonDir = new File(dir, name);
                    // technically, we should look for the agent in new File(jonDir, "agent") because that's the rpm install dir.
                    // but there are no other rpms other than the agent, so if we see this jboss-on-* location, we know the agent is here.
                    log.warn("An agent RPM installation was found in ["
                        + jonDir
                        + "]!!! You will not be able to successfully run this older agent! You should manually remove it.");
                    return true;
                } else
                    return false;
            }
        });

        // if there is an RPM install on this box, we need to pause for some time to give the user a chance to read the message
        rpmInstalled = (rpms != null && rpms.length > 0);
        if (rpmInstalled) {
            try {
                log.warn("Please read the above warnings about the existence of agent RPM installations. This "
                    + command.getName() + " will resume in a few seconds.");
                Thread.sleep(30000L);
            } catch (InterruptedException ie) {
                Thread.currentThread().interrupt();
            }
        }

        return;
    }

git commit to master: e4c0b12f83c3d51f111591e7fc7773125e655e17

git commit to release/jon3.2.x: 8d987e8cdf916fa97a18e70f0c25679d211c138f

Development ... please document clearly what you have to test this change.

If you have an agent RPM installed (for example, /usr/share/jboss-on-3.1.2.GA/agent), you'll see this in the rhqctl install output:

$ ./rhqctl install
13:01:32,718 INFO  [org.jboss.modules] JBoss Modules version 1.2.0.CR1
13:01:32,865 WARN  [org.rhq.server.control.RHQControl] An agent RPM installation was found in [/usr/share/jboss-on-3.1.2.GA]!!! You will not be able to successfully run this older agent anymore. You should manually remove it.
13:01:32,865 WARN  [org.rhq.server.control.RHQControl] Please read the above warnings about the existence of agent RPM installations. This install will resume in a few seconds.

Here's what it looks like if you upgrade a server on a machine where an agent RPM also lives:

$ ./rhqctl upgrade --from-server-dir=/some-server-install-dir
13:02:54,575 INFO  [org.jboss.modules] JBoss Modules version 1.2.0.CR1
13:02:54,728 WARN  [org.rhq.server.control.RHQControl] An agent RPM installation was found in [/usr/share/jboss-on-3.1.2.GA]!!! You will not be able to successfully run this older agent anymore. You should manually remove it.
13:02:54,728 WARN  [org.rhq.server.control.RHQControl] Please read the above warnings about the existence of agent RPM installations. This upgrade will resume in a few seconds.

QE, please ... 
1) update the TCMS definition based on this BZ
2) another documented testcase run of this TCMS as part of the verification.  

https://tcms.engineering.redhat.com/run/94976/?from_plan=6517

Created attachment 834498 [details]
Updated rhq-server-control jar to be overlaid on GA release candidate for testing.

This can be tested with a GA-1 candidate by:
i)installing an earlier JON 3.1.2.GA agent via rpm
ii)Unzip JON 3.2.0.GA candidate build, then take the attached jar on top of 
 <jon-server-install-dir>/modules/org/rhq/rhq-server-control/main/rhq-server-control.....jar.
iii)Run normal upgrade/install test activities and monitor install logs for WARN as described above.

Updated the wording to explicitly direct users to the install documentation as discussed:
"... You will not be able to successfully run this older agent anymore. You should consult the install documentation about manually removing and/or merging the old and new agent.".

This if fixed with the following commits to the release branch:
dbf6b06c
15939eb4

Moving to ON_QA as available for test in latest brew build:
https://brewweb.devel.redhat.com//buildinfo?buildID=317919

Verified on https://brewweb.devel.redhat.com//buildinfo?buildID=317919

Verified as below:
---
Installation
-------
1. Installed JON agent RPM 3.1.2 on RHEL 6 machine.
(jboss-on-agent-3.1.2.GA-1.el6_3.noarch.rpm)
 rpm -e jboss-on-agent-3.1.2.GA-1.el6_3.noarch.rpm
 service jon-agent start
2. Attempted to install JON server 3.2.0 on the same machine.
 ./rhqctl install

It displayed below:
03:17:10,418 INFO  [org.jboss.modules] JBoss Modules version 1.2.2.Final-redhat-1
03:17:10,749 WARN  [org.rhq.server.control.RHQControl] An agent RPM installation was found in [/usr/share/jboss-on-3.1.2.GA]!!! You will not be able to successfully run this older agent anymore. You should consult the install documentation about manually removing and/or merging the old and new agent.
03:17:10,750 WARN  [org.rhq.server.control.RHQControl] Please read the above warnings about the existence of agent RPM installations. This install will resume in a few seconds. 
---------
Upgrade:
-------------
1. Installed JON Server 3.1.2 on RHEL 6 machine.
2. Installed JON agent RPM 3.1.2 RHEL 6 machine.
rpm -e jboss-on-agent-3.1.2.GA-1.el6_3.noarch.rpm
service jon-agent start
3. Attempted to upgrade to JON server 3.2.0.
./rhqctl upgrade --from-server-dir <JON3.2 Server Dir>

It displayed below:

[root@dhcp201-210 bin]# ./rhqctl upgrade --from-server-dir /JON3.1.2GA/jon-server-3.1.2.GA
05:35:24,625 INFO  [org.jboss.modules] JBoss Modules version 1.2.2.Final-redhat-1
05:35:25,195 WARN  [org.rhq.server.control.RHQControl] An agent RPM installation was found in [/usr/share/jboss-on-3.1.2.GA]!!! You will not be able to successfully run this older agent anymore. You should consult the install documentation about manually removing and/or merging the old and new agent.
05:35:25,196 WARN  [org.rhq.server.control.RHQControl] Please read the above warnings about the existence of agent RPM installations. This upgrade will resume in a few seconds.
------

Also verified that only rhqctl install and rhqctl upgrade displays above warning. Other rhqctl commands like rhqctl start, restart, stop, status, ---help does not display above warning message.