| Summary: | History change is accompanied with "comment X" needlessly | ||
|---|---|---|---|
| Product: | [Community] Bugzilla | Reporter: | Jan Pokorný [poki] <jpokorny> |
| Component: | Creating/Changing Bugs | Assignee: | Matt Tyson 🤬 <mtyson> |
| Status: | CLOSED CURRENTRELEASE | QA Contact: | Simon Green <sgreen> |
| Severity: | low | Docs Contact: | |
| Priority: | low | ||
| Version: | 4.4 | CC: | ebaak, jmcdonal, mtyson, rjoost, sgreen |
| Target Milestone: | 4.4 | ||
| Target Release: | --- | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| Whiteboard: | |||
| Fixed In Version: | 4.4.2015 | Doc Type: | Bug Fix |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2014-03-13 00:51:28 UTC | Type: | Bug |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
|
Description
Jan Pokorný [poki]
2013-12-10 13:21:14 UTC
Oops, [bz738468 comment 20] indeed. The orphaned "Comment X" label is shown because there is actually a comment associated with that change -- the comment is just being suppressed if the inline history is being shown. If you go to preferences and switch off the inline history via the "When viewing a bug, show all bug activity" setting, you'll see the following content for bz738468 comment 20: *** Bug 813330 has been marked as a duplicate of this bug. *** I expect that it would be possible to suppress the comment marker as well as the comment, but I'll leave it up to Simon to decide whether it's worth the effort (and whether the change should be made upstream instead). This code comes from Mozilla, not upstream. They suppress the comment marker, so we'll just use their code to do it. -- simon The 'Comment N' label is deliberately put in by the InlineHistory extension. Without this marker it may cause confusion as you will have comment numbers jumping without explanation. EG: Comment 1: Comment of some sort Duplicate of this bug : 1234 Duplicate of this bug : 2345 Comment 4: Another comment Removing this label may cause confusion as comments 2 and 3 are now 'missing'. Are we sure we want to proceed with this? IMO, yes. BMO have :) and comments can jumped if the user cannot see a comment. But I'll leave it for jmcdonald to make the call We have a choice between two implementations, both of which look a bit strange until you understand what BZ is doing in either case. I'm happy to follow BMO in this instance. Users often see gaps in the comment numbers due to private comments. Just to clarify, the missing 'Comment X' labels on bigzilla.mozilla.org is actually a bug that manifests in Firefox. If you look at their webpage in Chrome you'll see the 'Comment X' label appear. I've clarified this with a Mozilla dev and he confirmed that it is a bug. (In reply to Matt Tyson from comment #7) > If you look at their webpage in Chrome you'll see the 'Comment X' label > appear. > I've clarified this with a Mozilla dev and he confirmed that it is a bug. Just to be clear, it is a bug if the 'Comment X' anchor tag is missing on a closed-dup message. You still need to create the anchor, or otherwise make the 'Last comment' link work. (In the example in comment 1, the hidden comment was the last one) The anchor has been put back in, but without the 'Comment X' text. This change is now live. If there are any issues, do not reopen this bug. Instead, you should create a new bug and reference this bug. Thanks |