Bug 1040623

Summary:	Remove native components that are not used by the product
Product:	[Retired] JBoss BRMS Platform 6	Reporter:	Rajesh Rajasekaran <rrajasek>
Component:	Build and Assembly	Assignee:	Ryan Zhang <rzhang>
Status:	CLOSED CURRENTRELEASE	QA Contact:	Radovan Synek <rsynek>
Severity:	high	Docs Contact:
Priority:	high
Version:	unspecified	CC:	etirelli, mwinkler, ncross, porcelli, rzhang
Target Milestone:	CR2
Target Release:	6.0.0
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:		Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2014-08-06 20:15:58 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:

Description Rajesh Rajasekaran 2013-12-11 17:44:41 UTC

Description of problem:

Building native components on multiple platforms is a huge effort in productization, hence if we don't depend on a native component that is packaged with the product, we should remove it. 
This bz is to evaluate the needs for the native components identified below and remove them from the product if not required.

In ER5 of BRMS/BPMS, we have:      
EAP deployable:      
jboss-eap-6.1/modules/system/layers/brms/org/kie/lib/main/jline-2.9.jar      Supplimentary tools:      
zookeeper-3.3.4/lib/jline-0.9.94.jar      
zookeeper-3.3.4/contrib/fatjar/zookeeper-3.3.4-fatjar.jar (Need for this unknown at this point)      
helix-core-0.6.1-incubating/repo/jline/jline/0.9.94/jline-0.9.94.jar (this is not required, Engg will remove it)

Comment 2 Alexandre Porcelli 2013-12-12 17:50:01 UTC

JLine (dependency from zookeeper):

Was already removed as a dependency from UF (in fact it was a transiente dependency from zookeeper that should be optional) -> https://github.com/droolsjbpm/uberfire/commit/6629b2f585658f76ea8e45fcd849bc852336a6d2

About ZooKeeper.jar: 

I did a quick search (find zookeeper-3.3.4/ -name \*.so -print and find zookeeper-3.3.4/ -name \*.dll -print) and didn't find any native code there.

This jar is mandatory, we cannot remove it.

Comment 3 Roger Martínez 2013-12-16 19:25:48 UTC

As commented With Alexandre, jline dependency can be removed but not the ZooKeeper one.

I have removed this dependency for the eap modules distribution too.

Master commit -> https://github.com/droolsjbpm/kie-wb-distributions/commit/0967310ef5a439f56dee78fe7b76b0de761c9955

6.0.x commit -> https://github.com/droolsjbpm/kie-wb-distributions/commit/5549a9af3abe29586955792b485b3f42c0f9844a

Comment 4 Radovan Synek 2014-01-09 15:22:23 UTC

As I discussed with Alexandre, supplementary tools should contain original distribution of helix and zookeeper (with jline and zookeeper fatjar). The jline library should be removed only from EAP modules and dependencies of business-central (already done).

However, all those have been removed from supplementary tools:      
zookeeper-3.3.4/lib/jline-0.9.94.jar      
zookeeper-3.3.4/contrib/fatjar/zookeeper-3.3.4-fatjar.jar
helix-core-0.6.1-incubating/repo/jline/jline/0.9.94/jline-0.9.94.jar

Comment 6 Ryan Zhang 2014-01-10 07:28:57 UTC

The jline and fatjar in zookeeper and helix-core  has been recovered.

Comment 10 Radovan Synek 2014-01-27 09:38:16 UTC

Verified with BRMS-6.0.0.CR2

Comment 11 Radovan Synek 2014-03-18 15:13:17 UTC

qe_test_coverage: any issue cause by removal of native components should be caught by existing regression tests