Bug 1040673

Summary:	Streamline auth exception has no useful message
Product:	OpenShift Online	Reporter:	Clayton Coleman <ccoleman>
Component:	Pod	Assignee:	Abhishek Gupta <abhgupta>
Status:	CLOSED CURRENTRELEASE	QA Contact:	libra bugs <libra-bugs>
Severity:	medium	Docs Contact:
Priority:	unspecified
Version:	2.x	CC:	jhou, xtian
Target Milestone:	---
Target Release:	---
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:		Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2014-01-30 00:53:03 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:

Description Clayton Coleman 2013-12-11 21:08:30 UTC

The traced new relic exception from streamline:

https://rpm.newrelic.com/accounts/411887/applications/2116199/traced_errors/1024208320

conveys no useful information about the cause of the problem.  If this is an "expected" exception (i.e. auth just failed) then we shouldn't be logging this exception (the exception needs to be more specific, and then handled in handle_exception with a specific block that sets internal_error false).  If this is unexpected, we need to be logging more information about what triggered it (i.e. a bad streamline response, "Unable to authenticate at this time, please try again later").  If it's being logged to new relic as is it's also showing up to a user without a message.

Comment 1 Abhishek Gupta 2014-01-04 00:13:11 UTC

Proposed fix --> https://github.com/openshift/origin-server/pull/4418

Comment 2 openshift-github-bot 2014-01-06 22:22:02 UTC

Commit pushed to master at https://github.com/openshift/origin-server

https://github.com/openshift/origin-server/commit/ef8036b667a54c6787d4cbb546dab6581623976c
Fix for bug 1040673

Comment 3 Jianwei Hou 2014-01-07 02:31:24 UTC

Verified on devenv_4191

Make the steamline unavailable(by updating the streamline config) and then create an application. An AuthServiceException will be logged.

2014-01-06 21:24:30.298 [DEBUG] FAILURE ACTION=LIST_DOMAIN USER_ID= LOGIN= DOMAIN= Unable to complete the requested operation due to: OpenShift::AuthServiceException. Unable to complete the requested operation due to: OpenShift::AuthServiceException.
Reference ID: a6d98d1d241b91d59d40f29bcce813ee (pid:10229)