Bug 1040711

Summary: GlusterFS online snap deletion may loop endlessly
Product: Red Hat OpenStack Reporter: Eric Harney <eharney>
Component: openstack-novaAssignee: Eric Harney <eharney>
Status: CLOSED ERRATA QA Contact: Yogev Rabl <yrabl>
Severity: unspecified Docs Contact:
Priority: high    
Version: 4.0CC: abaron, dron, eharney, mlopes, ndipanov, xqueralt, yeylon, yrabl
Target Milestone: z1Keywords: Triaged, ZStream
Target Release: 4.0   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: openstack-nova-2013.2.1-2.el6ost Doc Type: Bug Fix
Doc Text:
Prior to this update, Compute's method of tracking libvirt block jobs may have resulted in certain jobs not completing as expected. As a result, Block Storage snapshot delete operations would timeout without finalizing the snapshot delete process. With this fix, Compute polls the block job until the job is completed, and then marks it as finished. Consequently, snapshot deletion for attached Block Storage GlusterFS-backed volumes now completes successfully. Note that the "libvirt-0.10.2-29.el6_5.2" update from RHEL 6.5.z is required for this fix.
Story Points: ---
Clone Of: Environment:
Last Closed: 2014-01-23 14:22:30 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On: 1056037    
Bug Blocks: 1033652, 1033714, 1045196, 1052969    

Description Eric Harney 2013-12-12 00:09:20 UTC
Description of problem:
Online snap deletion may loop endlessly

I have not encountered this on RHOS yet, but I'm filing this so I can look into it and see if it is an issue on RHOS as well.

If libvirt returns an empty dict indicating no block job, the delete process will interpret this as "in progress" rather than "complete" and may not complete as expected.

May appear with libvirt-0.10.2-29.el6_5.2 on RHEL 6.5, related bug: 1038815.

Comment 1 Eric Harney 2013-12-19 20:36:59 UTC
Confirmed broken with:

libvirt-0.10.2-29.el6_5.2.x86_64
libvirt-python-0.10.2-29.el6_5.2.x86_64

Comment 2 Ayal Baron 2014-01-15 14:33:18 UTC
*** Bug 1052969 has been marked as a duplicate of this bug. ***

Comment 7 Dafna Ron 2014-01-21 18:03:48 UTC
delete of snapshot when it's the only snapshot for a volume fails. 

after discussion with devel, this bug was verified using a volume with more than one snapshot:

1. create a volume
2. boot instance from the volume
3. create two snapshots
4. delete one. 

the delete succeeded. 

moving to verified on openstack-cinder-2013.2.1-5.el6ost.noarch

Comment 10 Lon Hohberger 2014-02-04 17:19:45 UTC
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://rhn.redhat.com/errata/RHBA-2014-0046.html