Bug 1040958

Summary: Uploading of puppet modules fails
Product: [Retired] Pulp Reporter: Kim Johansen <kim-andre.johansen>
Component: puppet-supportAssignee: Barnaby Court <bcourt>
Status: CLOSED CURRENTRELEASE QA Contact: pulp-qe-list
Severity: high Docs Contact: Preethi Thomas <pthomas>
Priority: urgent    
Version: 2.3CC: mhrivnak, pthomas, rbarlow
Target Milestone: ---Keywords: Triaged
Target Release: 2.3.1   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2014-03-18 16:06:13 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:

Description Kim Johansen 2013-12-12 12:16:14 UTC
Description of problem:

Uploading module from directory fails.


Version-Release number of selected component (if applicable):

createrepo-0.9.9-21.2.pulp.el6.noarch
python-pulp-puppet-common-2.3.0-1.el6.noarch
pulp-selinux-2.3.0-1.el6.noarch
pulp-puppet-admin-extensions-2.3.0-1.el6.noarch
python-pulp-common-2.3.0-1.el6.noarch
python-pulp-client-lib-2.3.0-1.el6.noarch
python-isodate-0.5.0-1.pulp.el6.noarch
pulp-rpm-plugins-2.3.0-1.el6.noarch
python-pulp-bindings-2.3.0-1.el6.noarch
mod_wsgi-3.4-1.pulp.el6.x86_64
pulp-puppet-plugins-2.3.0-1.el6.noarch
python-pulp-rpm-common-2.3.0-1.el6.noarch
m2crypto-0.21.1.pulp-8.el6.x86_64
pulp-admin-client-2.3.0-1.el6.noarch
pulp-server-2.3.0-1.el6.noarch

How reproducible:


Steps to Reproduce:
1. Create a new repository
2. download a puppet module
3. pulp-admin puppet repo uploads upload --repo-id upload-repo --dir /root/upload

Actual results:

An unexpected error has occurred. More information can be found in the client
log file ~/.pulp/admin.log.

2013-12-12 13:08:32,106 - ERROR - Client-side exception occurred
Traceback (most recent call last):
  File "/usr/lib/python2.6/site-packages/pulp/client/commands/repo/upload.py", line 617, in perform_upload
    if response.response_body['success_flag']:
TypeError: 'NoneType' object is unsubscriptable


Expected results:

Uploaded module.


Additional info:

Comment 1 Michael Hrivnak 2013-12-12 16:43:04 UTC
I have reproduced this on 2.3.0. It is a client-side parsing error only. The upload does succeed, and the module gets added to the repository.

Comment 2 Randy Barlow 2013-12-16 18:27:10 UTC
Since we are interrupting a sprint for this, we should mark its priority as urgent.

Comment 3 Barnaby Court 2013-12-16 18:59:30 UTC
PR: https://github.com/pulp/pulp_puppet/pull/92

Comment 4 Barnaby Court 2013-12-17 14:23:59 UTC
*** Bug 1037693 has been marked as a duplicate of this bug. ***

Comment 5 Preethi Thomas 2013-12-18 20:17:35 UTC
[root@pulp-v2-server ~]# pulp-admin puppet repo uploads upload --repo-id puppet-repo -f puppetlabs-apache-0.5.0-rc1.tar.gz -v
+----------------------------------------------------------------------+
                              Unit Upload
+----------------------------------------------------------------------+

Extracting necessary metadata for each request...
[==================================================] 100%
Analyzing: puppetlabs-apache-0.5.0-rc1.tar.gz
... completed

Files to be uploaded:
  puppetlabs-apache-0.5.0-rc1.tar.gz

Creating upload requests on the server...
[==================================================] 100%
Initializing: puppetlabs-apache-0.5.0-rc1.tar.gz
... completed

Starting upload of selected units. If this process is stopped through ctrl+c,
the uploads will be paused and may be resumed later using the resume command or
cancelled entirely using the cancel command.

Uploading: puppetlabs-apache-0.5.0-rc1.tar.gz
[==================================================] 100%
28866/28866 bytes
... completed

Importing into the repository...
... completed

Deleting the upload request...
... completed

[root@pulp-v2-server ~]# 
[root@pulp-v2-server ~]# 
[root@pulp-v2-server ~]# 
[root@pulp-v2-server ~]# pulp-admin puppet repo uploads upload --repo-id puppet-repo --dir puppet -v
+----------------------------------------------------------------------+
                              Unit Upload
+----------------------------------------------------------------------+

Extracting necessary metadata for each request...
[==================================================] 100%
Analyzing: puppetlabs-stdlib-4.1.0.tar.gz
... completed

Files to be uploaded:
  puppetlabs-stdlib-4.1.0.tar.gz

Creating upload requests on the server...
[==================================================] 100%
Initializing: puppetlabs-stdlib-4.1.0.tar.gz
... completed

Starting upload of selected units. If this process is stopped through ctrl+c,
the uploads will be paused and may be resumed later using the resume command or
cancelled entirely using the cancel command.

Uploading: puppetlabs-stdlib-4.1.0.tar.gz
[==================================================] 100%
67586/67586 bytes
... completed

Importing into the repository...
... completed

Deleting the upload request...
... completed

[root@pulp-v2-server ~]#

Comment 6 Preethi Thomas 2013-12-19 22:25:58 UTC
verified
[root@pulp-v2-server ~]# rpm -qa pulp-server
pulp-server-2.3.1-0.8.beta.el6.noarch
[root@pulp-v2-server ~]#
Also installed modules from the uploaded puppet repo

[root@pulp-v2-server ~]# pulp-admin puppet consumer install run --consumer-id consumer1 --content-unit puppetlabs/stdlib/4.1.0
This command may be exited via ctrl+c without affecting the request.

[-]
Waiting to begin...


1 change was made

Install Succeeded


[root@pulp-v2-server ~]

Comment 7 Preethi Thomas 2014-03-18 16:06:13 UTC
These were already verified in the corresponding releases that they were fixed in. Moving them to closed current release.