Bug 1041558

Summary: Filter out rootpw from anaconda reports
Product: [Fedora] Fedora Reporter: Orion Poplawski <orion>
Component: libreportAssignee: Jakub Filak <jfilak>
Status: CLOSED ERRATA QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: high Docs Contact:
Priority: unspecified    
Version: 21CC: abrt-devel-list, awilliam, dvlasenk, iprikryl, jberan, jfilak, mhabrnal, mmilata, mtoman, orion, ssuehle, vpodzime
Target Milestone: ---   
Target Release: ---   
Hardware: All   
OS: Linux   
Whiteboard:
Fixed In Version: libreport-2.3.0-5.fc21 Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of:
: 1168523 (view as bug list) Environment:
Last Closed: 2014-12-13 09:55:31 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On:    
Bug Blocks: 1168523    

Description Orion Poplawski 2013-12-12 17:18:52 UTC
Description of problem:

It would be good if abrt filtered out "rootpw" lines from anaconda reports.  I know this is in the ks.cfg and the traceback files, perhaps others.

Comment 1 Orion Poplawski 2014-11-04 23:48:44 UTC
I think this is fairly important.  How can I help?

Comment 2 Jakub Filak 2014-11-05 06:33:55 UTC
It is already possible to highlight such lines, but auto-removing is not implemented yet. Would the highlighting be an acceptable solution to you?

Comment 3 Orion Poplawski 2014-11-05 15:46:10 UTC
It's better than nothing, but it should be auto-removed, especially since the text mode reporter makes it quite hard to find.

Comment 4 Jakub Filak 2014-11-06 07:33:31 UTC
Ah, I forgot on the text mode reporter. Hence I am adding a simple auto-remove utility for Anaconda reports in the following pull request:
https://github.com/abrt/libreport/pull/301

The pull request also enables highlighting of "rootpw" lines in the GUI reporter.

Vratislav, could you please take a look at that pull request?

Comment 5 Vratislav Podzimek 2014-11-06 08:12:41 UTC
(In reply to Jakub Filak from comment #4)
> Ah, I forgot on the text mode reporter. Hence I am adding a simple
> auto-remove utility for Anaconda reports in the following pull request:
> https://github.com/abrt/libreport/pull/301
Looks good to me.

Comment 6 Jakub Filak 2014-11-26 10:06:51 UTC
I opened another pull request for a patch making libreport aware of anaconda-tb:
https://github.com/abrt/libreport/pull/305

libreport cannot highlight all forbidden words in that file because the file contains too many false positives.

Comment 7 Orion Poplawski 2014-11-26 15:18:33 UTC
Would be nice to get this into F21 Final.

Comment 8 Scott Suehle 2014-11-26 20:15:47 UTC
Discussed at today's blocker review meeting [1]. Accepted as a AcceptedFreezeException. A fix for this would be considered during freeze.

[1] http://meetbot.fedoraproject.org/fedora-blocker-review/2014-11-12/

Comment 9 Fedora Update System 2014-11-28 14:08:14 UTC
libreport-2.3.0-5.fc21 has been submitted as an update for Fedora 21.
https://admin.fedoraproject.org/updates/libreport-2.3.0-5.fc21

Comment 10 Fedora Update System 2014-11-29 20:59:39 UTC
Package libreport-2.3.0-5.fc21:
* should fix your issue,
* was pushed to the Fedora 21 testing repository,
* should be available at your local mirror within two days.
Update it with:
# su -c 'yum update --enablerepo=updates-testing libreport-2.3.0-5.fc21'
as soon as you are able to.
Please go to the following url:
https://admin.fedoraproject.org/updates/FEDORA-2014-15939/libreport-2.3.0-5.fc21
then log in and leave karma (feedback).

Comment 11 Jakub Filak 2014-12-03 16:17:13 UTC
(In reply to Scott Suehle from comment #8)
> Discussed at today's blocker review meeting [1]. Accepted as a
> AcceptedFreezeException. A fix for this would be considered during freeze.
> 
> [1] http://meetbot.fedoraproject.org/fedora-blocker-review/2014-11-12/

I can find this bug report in the log. Has this bug exception or not?

Comment 12 Adam Williamson 2014-12-05 19:43:39 UTC
It did, but we exercised discretion not to put it in the final week composes as by that point we're really in 'hair-on-fire changes only' mode. Sorry about that!

Comment 13 Adam Williamson 2014-12-05 19:44:43 UTC
21 is done, cleaning blocker process metadata.

Comment 14 Fedora Update System 2014-12-13 09:55:31 UTC
libreport-2.3.0-5.fc21 has been pushed to the Fedora 21 stable repository.  If problems still persist, please make note of it in this bug report.