Bug 1041722

Summary: [RFE][cinder]: Cinder monkey patching review
Product: Red Hat OpenStack Reporter: RHOS Integration <rhos-integ>
Component: RFEsAssignee: RHOS Maint <rhos-maint>
Status: CLOSED UPSTREAM QA Contact:
Severity: unspecified Docs Contact:
Priority: unspecified    
Version: unspecifiedCC: markmc, yeylon
Target Milestone: ---Keywords: FutureFeature
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
URL: https://blueprints.launchpad.net/cinder/+spec/safer-monkey-patching-for-a-safer-planet
Whiteboard: upstream_milestone_none upstream_status_unknown upstream_definition_obsolete
Fixed In Version: Doc Type: Enhancement
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2015-03-19 16:53:04 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:

Description RHOS Integration 2013-12-12 18:49:29 UTC 
Cloned from launchpad blueprint https://blueprints.launchpad.net/cinder/+spec/safer-monkey-patching-for-a-safer-planet.

Description:

Several cinder services do eventlet.monkey_patch() i.e. monkey patch everything that has an eventlet alternative. We should really consider a more conservative approach to doing this for the following reasons:

1. monkey patching everything increases the likelihood of unexpected results since you are using eventlet alternatives to modules which may not behave the same.
2. monkey patching everything is normally restricted to testing
3. other openstack services e.g. Glance use a whitelist approach so they know exactly what modules are being monkey patched thus making it easier to target tessts.
4. patching everyting makes it harder if you want to use a non-patched/original module

Specification URL (additional information):

None