Bug 1042508

Summary:	Guided Editor - when closing as asset always asks "Are you sure you want to discard unsaved data" even if nothing has been changed
Product:	[Retired] JBoss BRMS Platform 6	Reporter:	Tihomir Surdilovic <tsurdilo>
Component:	Business Central	Assignee:	Toni Rikkola <trikkola>
Status:	CLOSED EOL	QA Contact:	Lukáš Petrovický <lpetrovi>
Severity:	medium	Docs Contact:
Priority:	medium
Version:	6.0.0	CC:	etirelli, jpaulraj, lpetrovi, manstis, rrajasek, trikkola
Target Milestone:	ER5
Target Release:	6.1.0
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:		Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2020-03-27 19:41:29 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:

Description Tihomir Surdilovic 2013-12-12 23:07:39 UTC

Guided Rule editor, after opening an asset and closing it without any changes, a message pops up asking user if they would like to save unsaved changed. this is not needed

Comment 3 Zuzana Krejčová 2013-12-19 13:57:22 UTC

See also bug 975922 comment 6 and bug 1001673.

Comment 4 Toni Rikkola 2014-03-11 08:22:17 UTC

Did some testing with the mortgage example. Just opened the rule and closed it without changes. Fixed the problems those rules had, even without changes the editor refused to close.

master
https://github.com/droolsjbpm/drools-wb/commit/5757f4264
6.0.x
https://github.com/droolsjbpm/drools-wb/commit/981024da8

If this bug shows up again. We will need the rule that caused the problem to fix the problem.

Comment 5 Zuzana Krejčová 2014-05-06 14:09:19 UTC

This doesn't seem to be an issue with the source of the rule but with the editor itself.

Steps to reproduce:
1. Create a guided rule, add a condition 'Fact( someField == value)'. Save.
2. Reopen the rule.
3. Change the value in the condition, save the rule.
4. Try to close the rule.

At this moment, you get the "Are you sure you want to discard unsaved data" alert.

The source of the rule is exactly the same before and after saving, accepting alert, reopening.

Comment 6 Toni Rikkola 2014-11-25 19:04:54 UTC

Fix covers:
-Guided rule editor
-Enum editor
-Guided dsl rule editor
-Guided template rule editor
-Text editor
-Java class editor

It does not cover:
-Test scenarios
-Guided rule table

master:
https://github.com/droolsjbpm/drools/commit/e2a38a2e52244f9cb039ac4bce133346a4ed0cba

https://github.com/droolsjbpm/guvnor/commit/7fec4319af23d50d48b3cde6c3290195a8e68fb8

https://github.com/droolsjbpm/kie-wb-common/commit/0c56ec399f1acd88903e4f84a02acd9244305df0

https://github.com/droolsjbpm/drools-wb/commit/da59f96e3ae82ad41141f16f12cbf0784b0befa9

6.2.x 
https://github.com/droolsjbpm/drools/commit/678a83ab2b81cf3a606028dcbaac6c033b388c14

https://github.com/droolsjbpm/guvnor/commit/8ac6130159f5371d5d9cbb4474dd9a901332a95b

https://github.com/droolsjbpm/kie-wb-common/commit/a8d35b97ed070805aad3553abcf6b350fa75c466

https://github.com/droolsjbpm/drools-wb/commit/2336e9b45ac3c100e229dd0a4b7767ee13dcd8ac

Comment 7 Toni Rikkola 2014-11-28 13:14:04 UTC

There was a bug in java file editor. Link between the editor and the source editor got broken and fields created in editor were not added into the source.

master:
https://github.com/droolsjbpm/kie-wb-common/commit/19de871f1

6.2.x:
https://github.com/droolsjbpm/kie-wb-common/commit/671a76b1d

Comment 8 Toni Rikkola 2014-11-28 14:25:50 UTC

Save needs to reset the dirty status.

master:
https://github.com/droolsjbpm/kie-wb-common/commit/1248d719e
https://github.com/droolsjbpm/drools-wb/commit/43f14c9ce

6.2.x:
https://github.com/droolsjbpm/kie-wb-common/commit/541594ff0
https://github.com/droolsjbpm/drools-wb/commit/869e8a792

Comment 9 Toni Rikkola 2014-12-01 11:09:51 UTC

jbpm-console-ng was failing

master:
https://github.com/droolsjbpm/jbpm-console-ng/commit/c6af40e84
6.2.x
https://github.com/droolsjbpm/jbpm-console-ng/commit/25a7db080

Comment 13 Toni Rikkola 2015-01-08 14:33:52 UTC

master

https://github.com/droolsjbpm/kie-wb-common/commit/742ab1031
https://github.com/droolsjbpm/drools-wb/commit/f1746332a


6.2.x 

https://github.com/droolsjbpm/kie-wb-common/commit/6d82b3807
https://github.com/droolsjbpm/drools-wb/commit/48a1ba489

Comment 15 Zuzana Krejčová 2015-02-16 12:16:12 UTC

GDT and TS editors are now covered by bug 1193026 and bug 1193027.

Comment 16 Toni Rikkola 2015-02-16 12:20:14 UTC

Thank you. I will set this as modified.