Bug 1042906

Summary:	cmusphinx3: spurious build dependency on libbsd-devel
Product:	[Fedora] Fedora	Reporter:	Florian Weimer <fweimer>
Component:	cmusphinx3	Assignee:	Jerry James <loganjerry>
Status:	CLOSED RAWHIDE	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	unspecified	Docs Contact:
Priority:	unspecified
Version:	rawhide	CC:	loganjerry
Target Milestone:	---
Target Release:	---
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:		Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2013-12-13 23:14:06 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:

Description Florian Weimer 2013-12-13 15:39:38 UTC

I don't think the build dependency on libbsd-devel is needed.  I applied the following patch (after the sed business in the %prep stage), and the package still builds successfully.  The built RPMs didn't have dependencies on libbsd even before that, as libbsd isn't linked in.

diff -up sphinx3-0.8/src/libs3decoder/libcfg/s3_cfg_convert.c.bsd sphinx3-0.8/src/libs3decoder/libcfg/s3_cfg_convert.c
--- sphinx3-0.8/src/libs3decoder/libcfg/s3_cfg_convert.c.bsd    2013-12-13 16:19:45.575368130 +0100
+++ sphinx3-0.8/src/libs3decoder/libcfg/s3_cfg_convert.c        2013-12-13 16:19:55.006411687 +0100
@@ -1,5 +1,4 @@
 
-#include <bsd/libutil.h>
 #include "s3_cfg.h"
 #include "fsg.h"
 
diff -up sphinx3-0.8/src/libs3decoder/libsearch/fsg_history.c.bsd sphinx3-0.8/src/libs3decoder/libsearch/fsg_history.c
--- sphinx3-0.8/src/libs3decoder/libsearch/fsg_history.c.bsd    2013-12-13 16:19:10.457204835 +0100
+++ sphinx3-0.8/src/libs3decoder/libsearch/fsg_history.c        2013-12-13 16:19:20.477251590 +0100
@@ -55,7 +55,6 @@
 #include <kb.h>
 /*#include <phone.h>*/
 #include <search.h>
-#include "bsd/libutil.h"
 
 
 #define __FSG_DBG__    0

Comment 1 Jerry James 2013-12-13 22:52:33 UTC

The original sources are trying to include "libutil.h".  We're adding the "bsd/" on the front of that in the spec file.  So to simplify things, I removed that part of the spec file, and create an empty file named libutil.h instead.  That way no patches are necessary.

Thanks for the report.  A version with no libbsd-devel dependency is building in Rawhide now.

Comment 2 Jerry James 2013-12-13 23:14:06 UTC

The Rawhide build is complete.