Bug 1043052

Summary:	Installer: dtgovworkflows user password generation can create passwords that cause S-RAMP repo seeding to fail
Product:	[JBoss] JBoss Fuse Service Works 6	Reporter:	Thomas Hauser <thauser>
Component:	Installer	Assignee:	Thomas Hauser <thauser>
Status:	CLOSED CURRENTRELEASE	QA Contact:	Len DiMaggio <ldimaggi>
Severity:	high	Docs Contact:
Priority:	unspecified
Version:	6.0.0 GA	CC:	atangrin, ncross, soa-p-jira
Target Milestone:	ER8
Target Release:	6.0.0
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:		Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:		Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:

Description Thomas Hauser 2013-12-13 20:56:29 UTC

Description of problem:
The generation of the password allows quotation marks in the password. If the generated password meets the following conditions:
i) Begins with "
ii) Contains no other " characters

the s-ramp-shell-0.3.1.Final-redhat-4.jar will throw the following error:
Invalid argument:  Invalid final argument - did you forget to close your quotes?
S-RAMP shell shutting down...done.

This results in a failed installation.


Version-Release number of selected component (if applicable):
6.0.0.ER7-2

How reproducible:
Extremely rarely. Not reproducible by choice, only random chance. 

Steps to Reproduce:
1. Install until the password generated by the code results in a password meeting the above conditions (many, many installations)

Actual results:
Failed S-RAMP repo seeding

Expected results:
S-RAMP repo seeding succeeds. 

Additional info:

Comment 2 Thomas Hauser 2013-12-13 21:23:13 UTC

Fixed in 587e553e8d81037928c2277ed5504b0cc8ab3e31 of installer-commons.

Comment 3 Thomas Hauser 2013-12-13 21:27:25 UTC

This issue is also hit if the password starts with ' and contains no other ' character. 

Issue can be artificially reproduced by attempting to run

java -jar bin/s-ramp-shell-0.3.1.Final-redhat-4.jar -f dtgov-sramp-repo-seed-cli-commands.txt

and modifying the dtgov-sramp-repo-seed-cli-commands.txt to contain placeholder credentials, making the password start with either " or ' and not having any closing quotation, while a server is running.

Comment 4 Len DiMaggio 2014-01-06 17:29:29 UTC

Verified in ER8