Bug 1043093

Summary:	Multipath doesn't check realloc calls for null return pointers.
Product:	Red Hat Enterprise Linux 7	Reporter:	Ben Marzinski <bmarzins>
Component:	device-mapper-multipath	Assignee:	Ben Marzinski <bmarzins>
Status:	CLOSED ERRATA	QA Contact:	Barry Donahue <bdonahue>
Severity:	unspecified	Docs Contact:
Priority:	unspecified
Version:	7.0	CC:	agk, bmarzins, heinzm, msnitzer, prajnoha, yanwang, zkabelac
Target Milestone:	rc
Target Release:	---
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:	device-mapper-multipath-0.4.9-78.el7	Doc Type:	Bug Fix
Doc Text:	Found by code analysis. No related customer issues. No documentation needed.	Story Points:	---
Clone Of:		Environment:
Last Closed:	2015-11-19 12:56:02 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Ben Marzinski 2013-12-13 22:42:58 UTC

Description of problem:
In uxsock_listen() and likely elsewhere, device-mapper-multipath is calling realloc, without dealing with possible failures.  In uxsock_listen() a failure will case a null pointer dereference. Elsewhere, there is the possibility for memory leaks as well.  All the realloc() calls should be reviewed.

Version-Release number of selected component (if applicable):
device-mapper-multipath-0.4.9-60.el7

How reproducible:
Most likely very hard to reproduce.  Bug was found by code analysis.

Comment 2 Ludek Smid 2014-06-26 10:50:27 UTC

This request was resolved in Red Hat Enterprise Linux 7.0.

Contact your manager or support representative in case you have further questions about the request.

Comment 3 Ludek Smid 2014-06-26 11:15:51 UTC

The comment above is incorrect. The correct version is bellow.
I'm sorry for any inconvenience.
---------------------------------------------------------------

This request was NOT resolved in Red Hat Enterprise Linux 7.0.

Contact your manager or support representative in case you need
to escalate this bug.

Comment 6 Ben Marzinski 2015-05-08 04:00:44 UTC

Fixed all the realloc issues.

Comment 8 Barry Donahue 2015-08-10 15:45:24 UTC

Ran code against pNATE fault insertion test suite.

Comment 9 errata-xmlrpc 2015-11-19 12:56:02 UTC

Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://rhn.redhat.com/errata/RHBA-2015-2132.html