Bug 1043094

Summary: rest api: step of type, removing_bricks, has its external field set to false and does not have an external id that matches the gluster task id.
Product: Red Hat Gluster Storage Reporter: Dustin Tsang <dtsang>
Component: rhsc-sdkAssignee: Shubhendu Tripathi <shtripat>
Status: CLOSED WONTFIX QA Contact: Mike McCune <mmccune>
Severity: medium Docs Contact:
Priority: low    
Version: 2.1CC: dpati, knarra, mmahoney, mmccune, rhs-bugs, ssampat
Target Milestone: ---   
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2015-09-01 13:51:13 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:

Description Dustin Tsang 2013-12-13 22:43:24 UTC
Description of problem:

the step of type, remove_brick, has an external field set to false and does not have an external id that matches the gluster task id.

api calls affected:

GET /api/jobs/32965139-3796-436b-b8fd-de8d89807fdb/steps/72e1eeb1-709d-401f-872e-bdb0ee788695

GET /api/jobs/32965139-3796-436b-b8fd-de8d89807fdb/steps

Version-Release number of selected component (if applicable):
rhsc-cb11

How reproducible:
100% of the time

Steps to Reproduce:
1. create a simple dist volume
2. via rest api, start rebalance
=> Job id returned
3. via rest api, retrieve the index of steps 
=> list of steps that also include the step of type remove_brick
4. inspect the step with the type 'remove_brick'.

Actual results:

the external field is set to false.
no external id present to let the user know which gluster task this step is for.
-------- xml for the step -------
<step href="/api/jobs/32965139-3796-436b-b8fd-de8d89807fdb/steps/9f91e932-fc76-4ae1-b233-85da909945f5" id="9f91e932-fc76-4ae1-b233-85da909945f5">[\n]"
        <actions>[\n]"
            <link href="/api/jobs/32965139-3796-436b-b8fd-de8d89807fdb/steps/9f91e932-fc76-4ae1-b233-85da909945f5/end" rel="end"/>[\n]"
        </actions>[\n]"
        <description>Rebalancing Gluster Volume rebalstatuswhencompletetest in Cluster myCluster.( FINISHED Files [scanned: 0, moved: 0, failed: 0], Total size moved: 0.00 BYTES)</description>[\n]"
        <parent_step href="/api/jobs/32965139-3796-436b-b8fd-de8d89807fdb/steps/0a88cd88-c94d-49b7-941e-bc03f07f676b" id="0a88cd88-c94d-49b7-941e-bc03f07f676b"/>[\n]"
        <job href="/api/jobs/32965139-3796-436b-b8fd-de8d89807fdb" id="32965139-3796-436b-b8fd-de8d89807fdb"/>[\n]"
        <type>rebalancing_volume</type>[\n]"
        <number>0</number>[\n]"
        <status>[\n]"
            <state>FINISHED</state>[\n]"
        </status>[\n]"
        <start_time>2013-12-13T17:31:37.219-05:00</start_time>[\n]"
        <external>false</external>[\n]"
        <external_type>GLUSTER</external_type>[\n]"
    </step>[\n]"
</steps>[\n]




Expected results:
external field set to true and external id should be present


Additional info:
similar issue for rebalance step

Comment 2 Dustin Tsang 2013-12-13 22:55:55 UTC
correction to comment#0,

xml for step should looks like:

 <step href="/api/jobs/27b36146-9ead-479d-a167-bb201575e905/steps/08453732-8a1e-4420-8a0b-0e67420b33a5" id="08453732-8a1e-4420-8a0b-0e67420b33a5">[\n]"
     <actions>[\n]"
         <link href="/api/jobs/27b36146-9ead-479d-a167-bb201575e905/steps/08453732-8a1e-4420-8a0b-0e67420b33a5/end" rel="end"/>[\n]"
     </actions>[\n]"
     <description>Removing Bricks from Gluster Volume MigrateStepExecutingStepTest in Cluster myCluster.( STARTED  )</description>[\n]"
     <parent_step href="/api/jobs/27b36146-9ead-479d-a167-bb201575e905/steps/be30cd87-1344-4e99-b41a-08f612286f95" id="be30cd87-1344-4e99-b41a-08f612286f95"/>[\n]"
     <job href="/api/jobs/27b36146-9ead-479d-a167-bb201575e905" id="27b36146-9ead-479d-a167-bb201575e905"/>[\n]"
     <type>removing_bricks</type>[\n]"
     <number>0</number>[\n]"
     <status>[\n]"
         <state>STARTED</state>[\n]"
     </status>[\n]"
     <start_time>2013-12-13T17:53:47.362-05:00</start_time>[\n]"
     <external>false</external>[\n]"
     <external_type>GLUSTER</external_type>[\n]"
 </step>[\n]"

Comment 3 Dusmant 2013-12-16 08:45:00 UTC
This is a low priority as task id is not listed as part of step details. Its not a blocker for the functionality.

Comment 6 Dusmant 2015-09-01 13:49:34 UTC
We are not planning to address this new feature. Hence closing this BZ. If you think, it's applicable for 3.x or beyond release and would have an impact on customer, pls. open up a new BZ with the appropriate version. Thanks, -Dusmant

Comment 7 Dusmant 2015-09-01 13:51:13 UTC
Slight correction to Comment-6 : 

We are not planning to fix it. Hence closing this BZ. If you think, it's applicable for 3.x release and would have an impact on customer, pls. open up a new BZ with the appropriate version. Thanks, -Dusmant