| Summary: | Add new autogroup chart to dashboard shows empty chart in dashboard | ||
|---|---|---|---|
| Product: | [JBoss] JBoss Operations Network | Reporter: | Mike Thompson <mithomps> |
| Component: | UI | Assignee: | Jay Shaughnessy <jshaughn> |
| Status: | CLOSED CURRENTRELEASE | QA Contact: | Mike Foley <mfoley> |
| Severity: | unspecified | Docs Contact: | |
| Priority: | unspecified | ||
| Version: | JON 3.1.2 | CC: | jshaughn, myarboro |
| Target Milestone: | ER04 | ||
| Target Release: | JON 3.3.0 | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | Bug Fix | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2014-12-11 14:00:19 UTC | Type: | Bug |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
|
Description
Mike Thompson
2013-12-13 23:02:56 UTC
I think this was fixed upstream in Bug 1079225. The bug fix above may have been required to make this work, but acouple of things: - We no longer have that right-click from the menu option. We add to the dash via the monitoring->graphs subtab - Although I think we can support autogroup metric charts because they are backed by real groups, I'm not 100% sure we should because the group membership is only updated implicitly, when the user clicks on that node in the tree. - regardless of whether it would work, the ability to add the graph is broken on the monitoring->graphs for autogroups. I'll take a quick look to see if it's something simple... This is true for autoclusters as well. In short, the ResourceGroupD3GraphPortlet is not EntityContext-aware. And I'm not really sure it should be. I think what we should likely do is prevent adding AutoGroup/AutoCluster charts to the dash. They are really conveniences while navigating a resource or compatGroup tree, respectively. Their membership is not actively managed. Moving to ER03 for further consideration, but I think we should take the "AddToDash" widget away from the view for these special groups. Note, we could support this, but thew work on the portlet is mildly significant. For the reasons above I don't think it's a good idea to add autogroup or autocluster charts to the dash. Removing the option since it never worked anyway.
master commit afb91cb6f70bd38a6e562da789add0bde3e21cbc
Author: Jay Shaughnessy <jshaughn>
Date: Tue Sep 16 14:54:49 2014 -0400
Disable the ability to add Autogroup or Autocluster metric graphs to the
dashboard. It doesn't work because the portlets don't support them, and
these types of implicit groups should not be referenced outside of their
Tree navigation context. Despite being persisted they are maintained only
at click-time.
release/jon3.3.x commit b09ff2c85982f11e45283157f1836a25d334617a
Author: Jay Shaughnessy <jshaughn>
Date: Tue Sep 16 14:54:49 2014 -0400
(cherry picked from commit afb91cb6f70bd38a6e562da789add0bde3e21cbc)
Signed-off-by: Jay Shaughnessy <jshaughn>
Moving to ON_QA as available for test with build: https://brewweb.devel.redhat.com/buildinfo?buildID=388959 |