Bug 1043207
| Summary: | _at_groupinstall check for 'non-existent' package groups, added by upstream commit ff5416b1532fe43c68bf51ae30751504885a501a, reports that installed groups do not exist | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Adam Williamson <awilliam> |
| Component: | yum | Assignee: | Packaging Maintenance Team <packaging-team-maint> |
| Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | unspecified | Docs Contact: | |
| Priority: | unspecified | ||
| Version: | 20 | CC: | admiller, bclary, davidmenhur, ffesti, firas.alkafri, jawr, j, leonid, noloader, packaging-team-maint, pnemade, praiskup, samuel-rhbugs, sgraf, ss, theo148, zpavlas |
| Target Milestone: | --- | Keywords: | CommonBugs |
| Target Release: | --- | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| Whiteboard: | https://fedoraproject.org/wiki/Common_F20_bugs#yum-group-errors | ||
| Fixed In Version: | yum-3.4.3-128.fc19 | Doc Type: | Bug Fix |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2013-12-25 02:37:39 UTC | Type: | Bug |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Attachments: | |||
|
Description
Adam Williamson
2013-12-14 23:33:46 UTC
Created attachment 836852 [details]
/var/lib/yum/groups/installed from the affected system
Created attachment 836853 [details]
output of 'yum remove @cinnamon-desktop' on affected system
Created attachment 836854 [details]
output of 'yum group info cinnamon-desktop' on affected system
Oh, wait, it's much simpler than I thought. I can reproduce it on the clean test system just by updating yum - I forgot it still had yum -106. So this bug is simply: the check introduced by http://yum.baseurl.org/gitweb?p=yum.git;a=commit;h=ff5416b1532fe43c68bf51ae30751504885a501a incorrectly fails for installed groups, and reports that they don't exist. Beleaguered plea, while I try and figure out what's wrong with the check: can I just not read python, or are "yum install @foo" and "yum group install foo", even though they're supposed to be synonyms, implemented with entirely separate functions in two different files?! And if I'm right, er, isn't that a bit insane? Shouldn't _at_groupinstall just figure out the group name and then call installGroups, rather than re-implementing it? So if my very amateur-level python foo is right, the way this is implemented in installGroups is rather more sophisticated than the way it's implemented in _at_groupinstall. _at_groupinstall incorrectly prints its 'group does not exist' error if you call it on an installed group. installGroups does not. To my amateur eyes, though, I can't see why. The two seem to do pretty much the same thing, just in slightly different ways.
installGroups is in cli.py, lines 1902-1965, the most relevant bit looks like this:
-------------------
groups = []
if pkg_grp:
groups = self.comps.return_groups(group_string)
for group in groups:
group_matched = True
try:
txmbrs = self.selectGroup(group.groupid, upgrade=upgrade)
except yum.Errors.GroupsError:
self.logger.critical(_('Warning: group %s does not exist.'), group_string)
continue
else:
pkgs_used.extend(txmbrs)
if not group_matched:
self.logger.error(_('Warning: group %s does not exist.'), group_string)
continue
--------------------
_at_groupinstall is in yum/__init__.py , lines 4440-4477, the most relevant bit is:
--------------------
for group in comps.return_groups(group_string):
try:
txmbrs = self.selectGroup(group.groupid, upgrade=upgrade)
tx_return.extend(txmbrs)
except yum.Errors.GroupsError:
self.logger.critical(_('Warning: Group %s does not exist.'), group_string)
continue
else:
self.logger.error(_('Warning: group %s does not exist.'),
group_string)
--------------------
they're obviously not identical, but to my monkey eyes they look pretty equivalent. I might have to leave it to the experts at this point.
*** Bug 1039348 has been marked as a duplicate of this bug. *** Me too.... yum-3.4.3-127.fc20 has been submitted as an update for Fedora 20. https://admin.fedoraproject.org/updates/yum-3.4.3-127.fc20 (In reply to Fedora Update System from comment #9) > yum-3.4.3-127.fc20 has been submitted as an update for Fedora 20. > https://admin.fedoraproject.org/updates/yum-3.4.3-127.fc20 It helps. Is this fix going to be released for Fedora 19? We are a number of people with this problem (see bug #1039348). It should do yes, I think the devs wanted to gauge the feedback from F20 before sending it out to F19 too. It does touch quite a lot of important code. James tells me it should be sent out for F19 today, thanks for being patient! yum-3.4.3-127.fc19 has been submitted as an update for Fedora 19. https://admin.fedoraproject.org/updates/yum-3.4.3-127.fc19 Package yum-3.4.3-127.fc20: * should fix your issue, * was pushed to the Fedora 20 testing repository, * should be available at your local mirror within two days. Update it with: # su -c 'yum update --enablerepo=updates-testing yum-3.4.3-127.fc20' as soon as you are able to. Please go to the following url: https://admin.fedoraproject.org/updates/FEDORA-2013-23627/yum-3.4.3-127.fc20 then log in and leave karma (feedback). yum-3.4.3-128.fc20 has been pushed to the Fedora 20 stable repository. If problems still persist, please make note of it in this bug report. yum-3.4.3-128.fc19 has been pushed to the Fedora 19 stable repository. If problems still persist, please make note of it in this bug report. |