Bug 1043388

Summary:	virsh command cpu-stats return invalid return code
Product:	Red Hat Enterprise Linux 7	Reporter:	Hao Liu <hliu>
Component:	libvirt	Assignee:	Ján Tomko <jtomko>
Status:	CLOSED CURRENTRELEASE	QA Contact:	Virtualization Bugs <virt-bugs>
Severity:	medium	Docs Contact:
Priority:	medium
Version:	7.0	CC:	acathrow, dyuan, hliu, jtomko, mzhan, weizhan
Target Milestone:	rc
Target Release:	7.0
Hardware:	x86_64
OS:	Linux
Whiteboard:	virsh cmd
Fixed In Version:	libvirt-1.1.1-16.el7	Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2014-06-13 09:50:56 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:

Description Hao Liu 2013-12-16 07:42:00 UTC

Description of problem:
virsh command cpu-stats return invalid return code.

Version-Release number of selected component (if applicable):
libvirt-1.1.1-15.el7.x86_64

How reproducible:
100%

Steps to Reproduce:
With a running vm test-vm,

1. Call cpu-stats with --start or/and --count option, but without --total option. 
   Like following examples:
# virsh cpu-stats test-vm --start 1

2. Check return code.
# echo $?
Actual results:
1

Expected results:
0

Comment 2 Ján Tomko 2013-12-16 08:46:49 UTC

Fixed upstream by:
commit 9eb444364e5afca1e02448c48e0cb4ce36bf65db
Author:     Guannan Ren <gren>
CommitDate: 2013-08-27 15:17:03 +0800

    virsh: fix return value error of cpu-stats
    
    virsh cpu-stats guest --start 0 --count 3
    It outputs right but the return value is 1 rather than 0
    echo $?
    1
    
    Found by running libvirt-autotest
    ./run -t libvirt --tests virsh_cpu_stats

git describe: v1.1.1-232-g9eb4443 contains: v1.1.2-rc1~16

Comment 3 Ján Tomko 2013-12-16 08:49:24 UTC

Downstream patch posted:
http://post-office.corp.redhat.com/archives/rhvirt-patches/2013-December/msg00562.html

Comment 5 Hao Liu 2013-12-23 01:55:54 UTC

This patch is VERIFIED.

Verification steps:
# virsh cpu-stats virt-tests-vm1
# echo $?
0

# virsh cpu-stats virt-tests-vm1 --start 1
# echo $?
1 for libvirt-1.1.1-15.el7
0 for libvirt-1.1.1-16.el7

> virsh cpu-stats virt-tests-vm1 --count 1
# echo $?
1 for libvirt-1.1.1-15.el7
0 for libvirt-1.1.1-16.el7

# virsh cpu-stats virt-tests-vm1 --count 1 --total
# echo $?
0

# virsh cpu-stats virt-tests-vm1 --start 1 --count 1 --total
# echo $?
0

# virsh cpu-stats virt-tests-vm1 --start 1 --count 1
# echo $?
1 for libvirt-1.1.1-15.el7
0 for libvirt-1.1.1-16.el7

And all tests are PASS for virt-test:
(1/11) type_specific.virsh.cpu_stats.positive_test.option1: PASS (13.89 s)
(2/11) type_specific.virsh.cpu_stats.positive_test.option2: PASS (19.55 s)
(3/11) type_specific.virsh.cpu_stats.positive_test.option3: PASS (14.37 s)
(4/11) type_specific.virsh.cpu_stats.positive_test.option4: PASS (13.87 s)
(5/11) type_specific.virsh.cpu_stats.positive_test.option5: PASS (14.39 s)
(6/11) type_specific.virsh.cpu_stats.positive_test.option6: PASS (13.89 s)
(7/11) type_specific.virsh.cpu_stats.positive_test.paused_option: PASS (14.37 s)
(8/11) type_specific.virsh.cpu_stats.negative_test.no_option: PASS (13.98 s)
(9/11) type_specific.virsh.cpu_stats.negative_test.unexpect_option: PASS (14.68 s)
(10/11) type_specific.virsh.cpu_stats.negative_test.invalid_option: PASS (14.74 s)
(11/11) type_specific.virsh.cpu_stats.negative_test.invalid_start_option: PASS (15.13 s)

So this patch is verified.

Comment 6 Ludek Smid 2014-06-13 09:50:56 UTC

This request was resolved in Red Hat Enterprise Linux 7.0.

Contact your manager or support representative in case you have further questions about the request.