Bug 1043665

+++ This bug was initially created as a clone of Bug #1043636 +++

Description of problem:
augeas-libs 0.9.0-4.el6 allowed the following puppet snippet to work as it should:

    augeas {
      '/etc/sysconfig/nfs':
        context => '/files/etc/sysconfig/nfs',
        lens    => 'Sysconfig.lns',
        incl    => '/etc/sysconfig/nfs',
        changes => [ "set SECURE_NFS $nfsv4secure", ];
      '/etc/idmapd.conf':
        context => '/files/etc/idmapd.conf/General',
        lens    => 'Puppet.lns',
        incl    => '/etc/idmapd.conf',
        changes => ["set Domain ${nfs::client::redhat::nfs_v4_idmap_domain}"],
    }

Updating to 1.0.0-5 breaks this:

Dec 16 19:01:38 aws0 puppet-agent[18234]: Starting Puppet client version 3.3.1
Dec 16 19:01:46 aws0 puppet-agent[18238]: (Augeas[/etc/sysconfig/nfs](provider=augeas)) Loading failed for one or more files, see debug for /augeas//error output
Dec 16 19:01:46 aws0 puppet-agent[18238]: (/Stage[main]/Nfs::Client::Redhat::Configure/Augeas[/etc/sysconfig/nfs]) Could not evaluate: Save failed with return code false, see debug


Version-Release number of selected component (if applicable):
1.0.0-5

How reproducible:


Steps to Reproduce:
1.
2.
3.

Actual results:


Expected results:


Additional info:

--- Additional comment from Dominic Cleal on 2013-12-16 19:10:41 GMT ---

Please attach the contents of /etc/sysconfig/nfs to the BZ, as it's failing to load the file.

It'd also be useful if you can provide debug output from Puppet (--debug).

--- Additional comment from Jonathan Underwood on 2013-12-16 19:25:25 GMT ---

/etc/sysconfig/nfs

--- Additional comment from Jonathan Underwood on 2013-12-16 19:26:01 GMT ---

Nb. downgrading to 0.9.0-4.el6 allows the augeas resource to complete succesfully.

--- Additional comment from Jonathan Underwood on 2013-12-16 19:31:00 GMT ---



--- Additional comment from Jonathan Underwood on 2013-12-16 19:32:46 GMT ---

Relevant part seems to be:

ESC[0;36mDebug: Augeas[/etc/sysconfig/nfs](provider=augeas): Opening augeas with root /, lens path , flags 64ESC[0m
ESC[0;36mDebug: Augeas[/etc/sysconfig/nfs](provider=augeas): Augeas version 1.0.0 is installedESC[0m
ESC[1;31mWarning: Augeas[/etc/sysconfig/nfs](provider=augeas): Loading failed for one or more files, see debug for /augeas//error outputESC[0m
ESC[0;36mDebug: Augeas[/etc/sysconfig/nfs](provider=augeas): /augeas/files/etc/sysconfig/nfs/error = parse_failedESC[0m
ESC[0;36mDebug: Augeas[/etc/sysconfig/nfs](provider=augeas): /augeas/files/etc/sysconfig/nfs/error/pos = 159ESC[0m
ESC[0;36mDebug: Augeas[/etc/sysconfig/nfs](provider=augeas): /augeas/files/etc/sysconfig/nfs/error/line = 7ESC[0m
ESC[0;36mDebug: Augeas[/etc/sysconfig/nfs](provider=augeas): /augeas/files/etc/sysconfig/nfs/error/char = 0ESC[0m
ESC[0;36mDebug: Augeas[/etc/sysconfig/nfs](provider=augeas): /augeas/files/etc/sysconfig/nfs/error/lens = /usr/share/augeas/lenses/dist/sysconfig.aug:62.12-.71:ESC[0m
ESC[0;36mDebug: Augeas[/etc/sysconfig/nfs](provider=augeas): /augeas/files/etc/sysconfig/nfs/error/message = Get did not match entire inputESC[0m
ESC[0;36mDebug: Augeas[/etc/sysconfig/nfs](provider=augeas): Will attempt to save and only run if files changedESC[0m
ESC[0;36mDebug: Augeas[/etc/sysconfig/nfs](provider=augeas): sending command 'set' with params ["/files/etc/sysconfig/nfs/SECURE_NFS", "yes"]ESC[0m
ESC[0;36mDebug: Augeas[/etc/sysconfig/nfs](provider=augeas): Closed the augeas connectionESC[0m
ESC[1;31mError: /Stage[main]/Nfs::Client::Redhat::Configure/Augeas[/etc/sysconfig/nfs]: Could not evaluate: Save failed with return code false, see debugESC[0m

--- Additional comment from Jonathan Underwood on 2013-12-16 19:53:49 GMT ---

Ugh, a diff of the sysconfig lens between the 0.9 and 1.0 packages shows a heap of changes.

--- Additional comment from Dominic Cleal on 2013-12-16 19:58:30 GMT ---

(In reply to Jonathan Underwood from comment #6)
> Ugh, a diff of the sysconfig lens between the 0.9 and 1.0 packages shows a
> heap of changes.

Ah, I hadn't noticed you were using the Sysconfig module.  I'd recommend using Shellvars.lns instead, as this is the default lens for handling /etc/sysconfig/*.

Shellvars generally gets more attention and is far more extensive for handling shell-style files.

--- Additional comment from Dominic Cleal on 2013-12-16 20:53:51 GMT ---

Upstream as 92274bd3ff47d3cc4511d934dae06f16b59db7ad.

Steps to Reproduce:
1. augtool -A --transform "Sysconfig incl /etc/sysconfig/nfs" print /augeas/files/etc/sysconfig/nfs/error
2. augtool -A --transform "Sysconfig incl /etc/sysconfig/nfs" print /files/etc/sysconfig/nfs/

Actual results:
/augeas/files/etc/sysconfig/nfs/error = "parse_failed"
/augeas/files/etc/sysconfig/nfs/error/pos = "159"
/augeas/files/etc/sysconfig/nfs/error/line = "7"
/augeas/files/etc/sysconfig/nfs/error/char = "0"
/augeas/files/etc/sysconfig/nfs/error/lens = "/usr/share/augeas/lenses/dist/sysconfig.aug:62.12-.71:"
/augeas/files/etc/sysconfig/nfs/error/message = "Get did not match entire input"

Second command prints no output.

Expected results:
No output from the first command.

~54 lines of output from the second command:
/files/etc/sysconfig/nfs/#comment[1] = "Define which protocol versions mountd"
/files/etc/sysconfig/nfs/#comment[2] = "will advertise. The values are \"no\" or \"yes\""
/files/etc/sysconfig/nfs/#comment[3] = "with yes being the default"