Bug 1043792

Summary: [SNAPSHOT] : snapshot create without snap name shows ??? in the returned output
Product: Red Hat Gluster Storage Reporter: Rahul Hinduja <rhinduja>
Component: snapshotAssignee: Avra Sengupta <asengupt>
Status: CLOSED ERRATA QA Contact: Rahul Hinduja <rhinduja>
Severity: medium Docs Contact:
Priority: medium    
Version: rhgs-3.0CC: asengupt, nsathyan, rhs-bugs, sdharane, senaik, ssamanta, storage-qa-internal
Target Milestone: ---   
Target Release: RHGS 3.0.0   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard: SNAPSHOT
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2014-09-22 19:30:30 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:

Description Rahul Hinduja 2013-12-17 08:15:18 UTC
Description of problem:
=======================

Currently when the snapshot is created without -n (snap name) the command is successful and snapshot is created (system generated name) but the output returns as ??? as snap name

[root@snapshot-09 ~]# gluster snapshot create vol-snap0
snapshot create: ???: snap created successfully
[root@snapshot-09 ~]# gluster snapshot list vol-snap0

Volume Name : vol-snap0
Number of snaps taken : 1
Number of snaps available : 255

	Snap Name : 2013_12_17_01_07_26_732137
	Snap Time : 2013-12-17 06:37:27
	Snap ID : d2e191ab-aed7-48ff-ab04-8da3eef2fb9f
[root@snapshot-09 ~]# 

When a user doesn't provide a snap name, than CLI generates its own snap name which should be displayed in the return cli when success or failure

something similar to:

 snapshot create: 2013_12_17_01_07_26_732137 : snap created successfully


Version-Release number of selected component (if applicable):
=============================================================

glusterfs-3.4.0.snap.dec03.2013git-1.el6.x86_64


How reproducible:
=================
1/1


Steps to Reproduce:
===================
1.  gluster snapshot create volname

Actual results:
===============

snapshot create: ???: snap created successfully

Expected results:
=================

snapshot create: <system generated name> : snap created successfully

Comment 2 Avra Sengupta 2014-01-17 12:08:07 UTC
Fix at http://review.gluster.org/#/c/6625/

Comment 3 Rahul Hinduja 2014-01-17 12:24:02 UTC
verified with build: glusterfs-3.4.1.snap.jan15.2014git-1.el6.x86_64

snap creation without snap name success and prints the system generated name

[root@snapshot-01 ~]# gluster snapshot create vol1
snapshot create: 2014_01_17_05_23_17_123103: snap created successfully
[root@snapshot-01 ~]# 
[root@snapshot-01 ~]# gluster snapshot list vol1

Volume Name                  : vol1
Number of snaps taken        : 1
Number of snaps available    : 255

	Snap Name         : 2014_01_17_05_23_17_123103
	Snap Time         : 2014-01-17 10:53:18
	Snap UUID         : 7572bd04-eb96-4fa1-b776-dc841cba55ec
[root@snapshot-01 ~]# 


Marking bug as verified

Comment 5 Nagaprasad Sathyanarayana 2014-04-21 06:18:18 UTC
Marking snapshot BZs to RHS 3.0.

Comment 6 Nagaprasad Sathyanarayana 2014-05-19 10:56:39 UTC
Setting flags required to add BZs to RHS 3.0 Errata

Comment 9 errata-xmlrpc 2014-09-22 19:30:30 UTC
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

http://rhn.redhat.com/errata/RHEA-2014-1278.html