Bug 1043877

Summary: Project is able to build even if the invalid BPMN2 definition is present
Product: [Retired] JBoss BPMS Platform 6 Reporter: Sona Mala <smala>
Component: jBPM DesignerAssignee: Maciej Swiderski <mswiders>
Status: CLOSED CURRENTRELEASE QA Contact: Sona Mala <smala>
Severity: high Docs Contact:
Priority: high    
Version: 6.0.0CC: kverlaen, rrajasek
Target Milestone: CR1   
Target Release: 6.0.0   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2014-08-06 20:11:39 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Bug Depends On:    
Bug Blocks: 1045688    
Attachments:
Description Flags
BPMN2 definition - invalid none

Description Sona Mala 2013-12-17 11:54:00 UTC
Created attachment 837640 [details]
BPMN2 definition - invalid

Description of problem:
Use fresh unzipped BPMS server. If you create a new BPMN2 asset in repository1/project1 which content sequence flows from XOR gateway without condition then the project build success. Deployments perspective contains this jar but Process Definitions are empty.


Version-Release number of selected component (if applicable):
BPMS ER5 6.0.0

How reproducible:
Only if you use clear BPMS server (fresh unzip).

Steps to Reproduce:
1. Be sure that it is a first time when you run BPMS server
2. go to repository1/project1 
3. Create new business process (attached BPMN2)
    -> XOR gate contains default gate
    -> outgoing sequence flows from XOR gate are without conditions
4. Save it
5. go to Project screen
6. build project

Actual results:
The build is success, the deployment is present in Deployments perspective and process is missing in Process Definition. If you download the deployment then you realize that BPMN2 definition is missing in this jar file.

If you restart server than you get expected results, even if errors are not intuitive.

Expected results:
The build fail, Problems panel contains errors, no deployment in perspective Deployment and no process in Process Definitions.

Project build should have same behaviour at the first run of BPMS server and after restart.

Additional info:
Validation in Designer marks this process as invalid.

Comment 1 Sona Mala 2013-12-17 12:07:55 UTC
It seems that I get same result for a valid one.

Comment 2 Maciej Swiderski 2014-01-09 18:21:33 UTC
included processes as resources that refresh the cache on change event to ensure they are included in the build as previously there were simple not included that's why the kjar was deployed but without any processes thus no errors on build time.

guvnor
master:
https://github.com/droolsjbpm/guvnor/commit/af555400c64b6ae551d4a231275658ec3722c9b9

6.0.x:
https://github.com/droolsjbpm/guvnor/commit/2052194c915bccbfbe7f9313bd72968338c98c98

Comment 3 Maciej Swiderski 2014-01-10 11:45:34 UTC
after discussion with Mike, some refactoring has been applied so additional commit:

guvnor
master:
https://github.com/droolsjbpm/guvnor/commit/4aaed0dbfa37bbc1a2fffbb97788aa5ae359edcf

6.0.x:
https://github.com/droolsjbpm/guvnor/commit/c57bd450bd767a48af7836883973fdd35cc19733

Comment 4 Sona Mala 2014-01-23 14:06:32 UTC
Verified for 6.0.0 CR1.