Bug 1044223

Summary:	Broker returns important error message from node as "debug" severity
Product:	OpenShift Online	Reporter:	Clayton Coleman <ccoleman>
Component:	Image	Assignee:	Dan McPherson <dmcphers>
Status:	CLOSED CURRENTRELEASE	QA Contact:	libra bugs <libra-bugs>
Severity:	medium	Docs Contact:
Priority:	unspecified
Version:	2.x	CC:	bmeng, dmcphers, xtian
Target Milestone:	---
Target Release:	---
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:		Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2014-01-30 00:53:37 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:

Description Clayton Coleman 2013-12-17 22:52:51 UTC

Failure that is reported by the node on cart creation is returned as "debug" when it should be "error" severity.

Reproduce:

  rhc create-app cdk https://cdk-claytondev.rhcloud.com/manifest/failure

Get:

{"api_version":1.5,"data":null,"messages":[{"exit_code":157,"field":null,"index":null,"severity":"debug","text":"Error: Failed to execute: 'control start' for /var/lib/openshift/52b0d246230d29aa9d000049/cdk\n\n"},{"exit_code":157,"field":null,"index":null,"severity":"result","text":"The CDK is configured with password ZTNiMGM0NDI5OGZjMWMxNDlhZmJmNGM4OTk2ZmI5MjQyN2FlNDFlNDY0OWI5MzRjYTQ5NT for builds (use 'admin' as the user)\n"},{"exit_code":157,"field":null,"index":null,"severity":"error","text":"Unable to complete the requested operation due to: An invalid exit code (157) was returned from the server ip-10-111-2-46.  This indicates an unexpected problem during the execution of your request..\nReference ID: aa000f33e003a4b6f225a399621a0adf"}],"status":"internal_server_error","supported_api_versions":[1.0,1.1,1.2,1.3,1.4,1.5,1.6],"type":null,"version":"1.5"}

{"exit_code":157,"field":null,"index":null,"severity":"debug","text":"Error: Failed to execute: 'control start' for /var/lib/openshift/52b0d246230d29aa9d000049/cdk\n\n"} is very important - either the node or the broker is mislabeling that as debug, but it's actually the root cause of the issue.  Debug messages are excluded by the CLI intentionally

Comment 1 Lili Nader 2014-01-06 20:25:13 UTC

Return message from node is

Error: Failed to execute: 'control start' for /var/lib/openshift/52caf85a942f8540ad000001/cdk\n\n

full message:

[#<MCollective::RPC::Result:0x00000008364400 @agent="openshift", @action="cartridge_do", @results={:sender=>"ip-10-181-153-163", :statuscode=>1, :statusmsg=>"cartridge_do_action failed 157. Output Error: Failed to execute: 'control start' for /var/lib/openshift/52caf85a942f8540ad000001/cdk\n\n", :data=>{:time=>nil, :output=>"Error: Failed to execute: 'control start' for /var/lib/openshift/52caf85a942f8540ad000001/cdk\n\n", :exitcode=>157, :addtl_params=>nil}}>]

In order for broker to notify the client the message needs to be superseded with CLIENT_ERROR:

Comment 2 Dan McPherson 2014-01-17 19:40:02 UTC

https://github.com/openshift/origin-server/pull/4509

Comment 3 openshift-github-bot 2014-01-17 20:58:29 UTC

Commit pushed to master at https://github.com/openshift/origin-server

https://github.com/openshift/origin-server/commit/5d4f3962cbc632eb0f01ac586933ae0e16bdabaf
Bug 1044223

Comment 4 Meng Bo 2014-01-20 06:07:41 UTC

{"api_version":1.6,"data":null,"messages":[{"exit_code":157,"field":null,"index":null,"severity":"error","text":"Failed to execute: 'control start' for /var/lib/openshift/52dcbcb2d182b6076e00030a/cdk\n"}],"status":"unprocessable_entity","supported_api_versions":[1.0,1.1,1.2,1.3,1.4,1.5,1.6],"type":null,"version":"1.6"}

Issue has been fixed on devenv_4242.