| Summary: | netcf-libs should use systemd | ||
|---|---|---|---|
| Product: | Red Hat Enterprise Linux 7 | Reporter: | jcpunk |
| Component: | netcf | Assignee: | Laine Stump <laine> |
| Status: | CLOSED CURRENTRELEASE | QA Contact: | Virtualization Bugs <virt-bugs> |
| Severity: | unspecified | Docs Contact: | |
| Priority: | unspecified | ||
| Version: | 7.0 | CC: | csieh, dallan, dyuan, honzhang, jmiao, laine, misterbonnie, mjenner, mzhan, riehecky |
| Target Milestone: | rc | ||
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | All | ||
| Whiteboard: | |||
| Fixed In Version: | netcf-0.2.3-6.el7 | Doc Type: | Bug Fix |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2014-06-13 09:56:07 UTC | Type: | Bug |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
|
Description
jcpunk
2013-12-18 19:42:27 UTC
Once a netcf build with the proper patches is available, the testing scenario would be something like this: yum update netcf-*.x86_64.rpm # (libvirtd will continue using old netcf until we reload it. # this can only be avoided by mandating offline updates) systemctl restart libvirtd.service virsh iface-begin (erase/modify some ifcfg-* files in /etc/sysconfig/network-scripts) (reboot the system) (see if the original files have been restored to /etc/sysconfig/network-scripts) (Note that as long as "virsh iface-begin returns success, if the restoration part of the test fails, you can always manually retrieve the original files from /var/lib/netcf/network-snapshot) A patch to fix this has been pushed upstream:
commit 2ca7857cc5ececf12288f4bcda586befdb16378c
Author: Laine Stump <laine>
Date: Fri Jan 17 11:58:46 2014 +0200
support systemd-based netcf-transaction
Note that due to a typo in the above patch, a 2nd patch is required:
commit 9dabd473ce54a5264ae92a78d5e4019b864f6997
Author: Laine Stump <laine>
Date: Wed Jan 22 15:27:43 2014 +0200
fix autogen build error
A last minute change to the previous patch addressing a review comment
managed to break an autogen, but I didn't notice because the error
scrolled off the screen:
checking for system init flavor... ./configure: line 32046: systemd: command not found
Hi Laine, I can successfully run your steps from comment 2 both netcf-0.2.3-4.el7 and netcf-0.2.3-6.el7. And I also could see the file /etc/init.d/netcf-transaction and /etc/systemd/system/multi-user.target.wants/netcf-transaction.service in latest netcf-0.2.3-6.el7, so how could I know which script netcf currently used? In my opinion, the newer netcf should remove /etc/init.d/netcf-transaction if netcf decides to switch to systemd. Could you help me to understand it? netcf-0.2.3-6.el7 does not provide /etc/init.d/netcf-transaction (this can be verified with "yum provides */netcf-transaction - it returns no results). During an rpm update, the older version files are removed according to the older version's file list, and newer version files are installed according to the newer version's file list - in other words, it is the older version of the rpm that should be (and is) taking care of removing this file that is no longer used. I've just downgraded my local netcf to 0.2.3-5 (noting that /usr/libexec/netcf-transaction.sh and /lib/systemd/system/netcf-transaction.service were properly removed, and /etc/init.d/netcf-transaction was properly installed), and then updated back to netcf-0.2.3-6 - /etc/init.d/netcf-transaction *was* properly removed on my system during this update. How did you do the update? With exactly the simple yum update command I showed in Comment 2? Definitely that command should be uninstalling the files of the previous version. The only way that I can think this file could be around is if it was previously installed by other means (e.g a "make install" from the netcf sources), but I highly doubt you've done that. (BTW, another way you can verify that the /etc/init.d/netcf-transaction file is from a previous build is by looking at the date - it will have a date within a few minutes of the build date) (In reply to Laine Stump from comment #9) > (BTW, another way you can verify that the /etc/init.d/netcf-transaction file > is from a previous build is by looking at the date - it will have a date > within a few minutes of the build date) Yes, I recheck it, the updating to latest netcf-0.2.3-6 will remove the previous /etc/init.d/netcf-transaction, and add /usr/lib/systemd/system/netcf-transaction.service. Downgrade to netcf-0.2.3-6 is verse. This means netcf-0.2.3-6 already move to systemd. And the steps from comment 2, netcf-0.2.3-6 can get success, so the netcf-transaction function is working based on systemd. Therefore I choose to change the status to VERIFIED. This request was resolved in Red Hat Enterprise Linux 7.0. Contact your manager or support representative in case you have further questions about the request. |