Bug 1044810

Summary:	send-key can not send os_x code ANSI_A
Product:	Red Hat Enterprise Linux 6	Reporter:	weizhang <weizhan>
Component:	libvirt	Assignee:	Michal Privoznik <mprivozn>
Status:	CLOSED WONTFIX	QA Contact:	Virtualization Bugs <virt-bugs>
Severity:	medium	Docs Contact:
Priority:	medium
Version:	6.5	CC:	acathrow, dyuan, jdenemar, lcui, mzhan
Target Milestone:	rc	Keywords:	Upstream
Target Release:	---
Hardware:	x86_64
OS:	Linux
Whiteboard:
Fixed In Version:		Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:	1044806	Environment:
Last Closed:	2014-04-04 21:26:59 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:	1044806
Bug Blocks:

Description weizhang 2013-12-19 03:49:57 UTC

Also reproduce on 
libvirt-0.10.2-29.el6_5.2.x86_64

+++ This bug was initially created as a clone of Bug #1044806 +++

Description of problem:
send-key can not send os_x code ANSI_A maybe because its code is 0x0

Version-Release number of selected component (if applicable):
qemu-kvm-rhev-1.5.3-21.el7.x86_64
libvirt-1.1.1-16.el7.x86_64


How reproducible:
100%

Steps to Reproduce:
1. Start a guest
2. run
# virsh send-key guestname --codeset os_x ANSI_A
error: invalid keycode: 'ANSI_A'

check with other keys will be ok
# virsh send-key guestname --codeset os_x ANSI_B
# virsh send-key guestname --codeset os_x ANSI_C

Actual results:
error: invalid keycode: 'ANSI_A'

Expected results:
send-key will succeed.

Additional info:

Comment 1 Cui Lei 2014-02-26 02:24:02 UTC

I can reproduce this issue with:
libvirt-0.10.2-29.el6_5.4.x86_64
qemu-kvm-0.12.1.2-2.415.el6.x86_64

# virsh send-key guestname --codeset os_x ANSI_A
error: invalid keycode: 'ANSI_A'

check with other keys will be ok
# virsh send-key guestname --codeset os_x ANSI_B
# virsh send-key guestname --codeset os_x ANSI_C

Comment 2 Michal Privoznik 2014-04-01 09:14:35 UTC

Patch is upstream for a while already:

commit 72ffbd1bf3005907c604d94c13058c9e547d46e8
Author:     Michal Privoznik <mprivozn>
AuthorDate: Thu Dec 19 16:40:16 2013 +0100
Commit:     Michal Privoznik <mprivozn>
CommitDate: Tue Dec 24 17:36:47 2013 +0100

    virkeycode: Allow ANSI_A
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1044806
    
    Currently, sending the ANSI_A keycode from os_x codepage doesn't work as
    it has a special value of 0x0. Our internal code handles that no
    different to other not defined keycodes. Hence, in order to allow it we
    must change all the undefined keycodes from 0 to -1 and adapt some code
    too.
    
      # virsh send-key guestname --codeset os_x ANSI_A
      error: invalid keycode: 'ANSI_A'
    
      # virsh send-key guestname --codeset os_x ANSI_B
      # virsh send-key guestname --codeset os_x ANSI_C
    
    Signed-off-by: Michal Privoznik <mprivozn>


v1.2.1-rc1~63

Comment 4 RHEL Program Management 2014-04-04 21:26:59 UTC

Development Management has reviewed and declined this request.
You may appeal this decision by reopening this request.