Bug 1044894
| Summary: | Review Request: perl-Crypt-X509 - Parse a X.509 certificate | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Ralf Corsepius <rc040203> |
| Component: | Package Review | Assignee: | Christopher Meng <i> |
| Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | i, package-review |
| Target Milestone: | --- | Flags: | i:
fedora-review+
gwync: fedora-cvs+ |
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | perl-Crypt-X509-0.51-1.fc19 | Doc Type: | Bug Fix |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2014-01-16 06:59:42 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | |||
| Bug Blocks: | 665096 | ||
|
Description
Ralf Corsepius
2013-12-19 08:22:35 UTC
Why filter out perl(Convert::ASN1)? Any cons of removing this dep? (In reply to Christopher Meng from comment #1) > Why filter out perl(Convert::ASN1)? Any cons of removing this dep? This dep also is manually added: ... Requires: perl(Convert::ASN1) >= 0.19 ... Without filtering, the package carry this dep twice, the manually added (versioned) one and an automatically added (unversioned one). The latter is redundant to the former one and thus is unnecessary. As such redundant deps cause dependency bloat in yum metadata files and in rpmdb, its common practice to filter out less such redundant "Requires:". Can upstream fix the requires or let relevant package's maintainer round up the version? 1. According to: https://fedoraproject.org/wiki/Perl/Tips?rd=PackagingTips/Perl#ExtUtils::MakeMaker You can use DESTDIR as PERL_INSTALL_ROOT. 2. Also according to the same URL above, remove find $RPM_BUILD_ROOT -depth -type d -exec rmdir {} 2>/dev/null \; Others are fine. 3. No license file. (In reply to Christopher Meng from comment #3) > Can upstream fix the requires or let relevant package's maintainer round up > the version? It's wishful naive dreamery to expect upstreams doing so. > 1. According to: > > https://fedoraproject.org/wiki/Perl/Tips?rd=PackagingTips/Perl#ExtUtils:: > MakeMaker > > You can use DESTDIR as PERL_INSTALL_ROOT. Many roads lead to Rome ... CAN != MUST. > 2. Also according to the same URL above, remove > > find $RPM_BUILD_ROOT -depth -type d -exec rmdir {} 2>/dev/null \; This line does not do any harm. Keeping it is still useful on many occasions and prevents bad surprises. > Others are fine. > > 3. No license file. There is *no* requirement for a package to ship a detached license file. The license of the package can be found inlined at the bottom of: http://cpansearch.perl.org/src/AJUNG/Crypt-X509-0.51/lib/Crypt/X509.pm Thanks for the review, Christopher. New Package SCM Request ======================= Package Name: perl-Crypt-X509 Short Description: Parse a X.509 certificate Owners: corsepiu Branches: f19 f20 InitialCC: perl-sig Git done (by process-git-requests). perl-Crypt-X509-0.51-1.fc20 has been submitted as an update for Fedora 20. https://admin.fedoraproject.org/updates/perl-Crypt-X509-0.51-1.fc20 perl-Crypt-X509-0.51-1.fc19 has been submitted as an update for Fedora 19. https://admin.fedoraproject.org/updates/perl-Crypt-X509-0.51-1.fc19 perl-Crypt-X509-0.51-1.fc19 has been pushed to the Fedora 19 testing repository. perl-Crypt-X509-0.51-1.fc20 has been pushed to the Fedora 20 stable repository. perl-Crypt-X509-0.51-1.fc19 has been pushed to the Fedora 19 stable repository. |