Bug 1044913

Summary: [RFE] Allow the task prefix to be overridden
Product: [Retired] Beaker Reporter: Nick Coghlan <ncoghlan>
Component: command lineAssignee: Raymond Mancy <rmancy>
Status: CLOSED CURRENTRELEASE QA Contact: tools-bugs <tools-bugs>
Severity: unspecified Docs Contact:
Priority: high    
Version: developCC: aigao, asaha, dcallagh, ebaak, llim, qwan, rmancy
Target Milestone: 0.15.3Keywords: FutureFeature
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: Doc Type: Enhancement
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2014-02-03 04:47:29 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:

Description Nick Coghlan 2013-12-19 08:55:54 UTC
Currently, the Beaker task makefile takes the git repo name into account when generating tags and RPM files.

This can cause problems if a task is moved from one repo (say, beaker) to another (say, beaker-core-tasks), since uploading a task with a different RPM name from the original can cause errors in tasks that have been scheduled, but haven't actually started running yet (they end up trying to install using the wrong RPM name).

The simplest solution to this is to make it easy to force a particular prefix for tasks, instead of using the repo name.

Comment 1 Dan Callaghan 2013-12-19 23:55:12 UTC
(In reply to Nick Coghlan from comment #0)
> since uploading a task with a different
> RPM name from the original can cause errors in tasks that have been
> scheduled, but haven't actually started running yet (they end up trying to
> install using the wrong RPM name).

For reference this is bug 1040258.

Comment 2 Dan Callaghan 2014-01-08 03:17:59 UTC
Instead of keeping these annoying pointless prefixes, another possible solution would be to drop the prefixes entirely from the RPM name but add the prefixed name as a virtual Provides. We would also need a mechanism to add other prefixed names as virtual Provides too, to cover this case. Then in another few months/years we can just drop all that logic entirely.

Comment 3 Raymond Mancy 2014-01-12 22:03:25 UTC
http://gerrit.beaker-project.org/#/c/2662/

Comment 4 Nick Coghlan 2014-01-24 03:29:23 UTC
As per the email to beaker-devel-list, we need to change this to use the old name by default, since the task snapshotting behaves badly if the RPM name changes.

We can start providing the new shorter name as well, though, which will make it easier to switch the actual name in the future.

Comment 5 Nick Coghlan 2014-01-24 06:10:31 UTC
http://gerrit.beaker-project.org/2717 added a new RHTS_RPM_NAME setting to force a particular RPM name (the actual workaround needed to avoid bug 1040258 when moving to a task to a different repo)

Comment 6 Nick Coghlan 2014-02-03 04:47:29 UTC
This was fixed by http://gerrit.beaker-project.org/#/c/2730/ and included in the rhts 4.58-1 release.