Bug 1044929

Summary: Review Request: perl-Date-Extract - Date::Extract Perl module
Product: [Fedora] Fedora Reporter: Ralf Corsepius <rc040203>
Component: Package ReviewAssignee: Nobody's working on this, feel free to take it <nobody>
Status: CLOSED ERRATA QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: medium Docs Contact:
Priority: medium    
Version: rawhideCC: package-review, panemade
Target Milestone: ---Flags: panemade: fedora-review+
gwync: fedora-cvs+
Target Release: ---   
Hardware: All   
OS: Linux   
Whiteboard:
Fixed In Version: perl-Date-Extract-0.04-1.fc19 Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2014-01-05 06:00:59 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On:    
Bug Blocks: 665096    

Description Ralf Corsepius 2013-12-19 09:11:29 UTC
Spec URL: http://corsepiu.fedorapeople.org/packages/perl-Date-Extract.spec
SRPM URL: http://corsepiu.fedorapeople.org/packages/perl-Date-Extract-0.04-1.fc21.src.rpm
Description: Search a string for something that looks like a date string, and build a DateTime object out of it. 
Fedora Account System Username: corsepiu

Comment 1 Parag AN(पराग) 2013-12-21 14:26:48 UTC
Review:

+ Package built in mock rawhide

+ rpmlint on generated rpms gave
2 packages and 0 specfiles checked; 0 errors, 0 warnings.

+ Source verified with upstream as (sha256sum)
upstream tarball : 7124d9e8d745544080f612a42d8cf6b3a27eda0f4ec607d25d255ddaadb1957a
srpm tarball : 7124d9e8d745544080f612a42d8cf6b3a27eda0f4ec607d25d255ddaadb1957a

+ License is valid

+ Package perl-Date-Extract-0.04-1.fc21.noarch =>
Provides: perl(Date::Extract) = 0.04 perl-Date-Extract = 0.04-1.fc21

Requires: perl(Class::Data::Inheritable) perl(DateTime::Format::Natural) perl(List::Util) perl(parent) perl(strict) perl(warnings)

+ make test output is
All tests successful.

suggestion:
* I think following can be removed from spec
find $RPM_BUILD_ROOT -depth -type d -exec rmdir {} 2>/dev/null \;

APPROVED.

Comment 2 Ralf Corsepius 2013-12-22 10:34:33 UTC
Thanks for the review, Parag.


New Package SCM Request
=======================
Package Name: perl-Date-Extract
Short Description: Date::Extract Perl module
Owners: corsepiu
Branches: f19 f20
InitialCC: perl-sig

Comment 3 Gwyn Ciesla 2013-12-23 12:57:31 UTC
Git done (by process-git-requests).

Comment 4 Fedora Update System 2013-12-26 16:54:43 UTC
perl-Date-Extract-0.04-1.fc20 has been submitted as an update for Fedora 20.
https://admin.fedoraproject.org/updates/perl-Date-Extract-0.04-1.fc20

Comment 5 Fedora Update System 2013-12-26 16:54:50 UTC
perl-Date-Extract-0.04-1.fc19 has been submitted as an update for Fedora 19.
https://admin.fedoraproject.org/updates/perl-Date-Extract-0.04-1.fc19

Comment 6 Fedora Update System 2013-12-28 02:01:24 UTC
perl-Date-Extract-0.04-1.fc20 has been pushed to the Fedora 20 testing repository.

Comment 7 Fedora Update System 2014-01-05 06:00:59 UTC
perl-Date-Extract-0.04-1.fc20 has been pushed to the Fedora 20 stable repository.

Comment 8 Fedora Update System 2014-01-05 06:03:08 UTC
perl-Date-Extract-0.04-1.fc19 has been pushed to the Fedora 19 stable repository.