Bug 1044973

Summary: Guided rule editor does not let the user to set objects as a parameters for method calls that have objects super type as a parameter
Product: [Retired] JBoss BRMS Platform 6 Reporter: Toni Rikkola <trikkola>
Component: Business CentralAssignee: Toni Rikkola <trikkola>
Status: CLOSED CURRENTRELEASE QA Contact: Tomas David <tdavid>
Severity: medium Docs Contact:
Priority: high    
Version: 6.0.0CC: etirelli, mbaluch, mbiarnes, rrajasek, tdavid
Target Milestone: CR1   
Target Release: 6.0.1   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2014-08-06 19:57:24 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Bug Depends On: 1056950, 1075584    
Bug Blocks: 1042798    

Description Toni Rikkola 2013-12-19 10:57:40 UTC
Description of problem:
Long topic, but the problem in code

rule something
when 
 a:Application()
 map:HashMap()
then
 map.put("string","string");
end

The method put(Object,Object) only supports LiteralValues, even when it could take in both Application and the HashMap from above. This is because the code behind does not see that both Application and HashMap extend Object.

Comment 3 Tomas David 2014-03-12 12:28:42 UTC
I can't verify this, because any parameters cannot be set or inserted.
Tested on BRMS 6.0.1.ER2.

Comment 4 Toni Rikkola 2014-03-13 14:35:39 UTC
The current state is that the editor let's the user to write the variables in. 
The problem that the user does not get to use helpful dropdowns.

Comment 5 Toni Rikkola 2014-03-14 14:22:47 UTC
master http://github.com/droolsjbpm/drools/commit/0213181ad

Comment 6 Toni Rikkola 2014-03-17 07:19:52 UTC
Fix for the test above.

master https://github.com/droolsjbpm/drools/commit/8288ddb55293cb868fb5901f539ca6372dce5fe7

Comment 8 Michael 2014-03-18 10:50:19 UTC
Ticket cherry-picked into 6.0.1.CR1. 
Commits:
33db34840da19591484fee1dd9e4bc2af6c8d3dd
2951db57099c4c727b574d4db1a613e4a2b948e8
d293f0985c3737af7a93140f0c4cc243470c1ce8
681aade7f3633a6b1c89d98eac7bf1af13d5acdb

Comment 9 Toni Rikkola 2014-03-18 11:39:01 UTC
Few commits for the bug 
https://bugzilla.redhat.com/show_bug.cgi?id=1077212
broke the previous fixes. So here are the fixes after that.

master
https://github.com/droolsjbpm/drools/commit/02ffd6ae3

6.0.x
https://github.com/droolsjbpm/drools/commit/db9ab9295

Comment 10 Michael 2014-03-18 12:19:24 UTC
https://github.com/droolsjbpm/drools/commit/db9ab9295 cherry picked:

Ticket cherry-picked into 6.0.1.CR1. 
Commit: b60f4f43a8c696cce75a00f4e48e5b47f7c044b0

Comment 11 Tomas David 2014-03-25 09:36:45 UTC
Verified on BRMS 6.0.1.CR1.