Bug 1045033
| Summary: | LIBVIRT_DEFAULT_URI=qemu:///system breaks libguestfs | |||
|---|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Richard W.M. Jones <rjones> | |
| Component: | libguestfs | Assignee: | Richard W.M. Jones <rjones> | |
| Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> | |
| Severity: | unspecified | Docs Contact: | ||
| Priority: | unspecified | |||
| Version: | rawhide | CC: | berrange, clalancette, crobinso, itamar, jforbes, jyang, laine, libvirt-maint, mbooth, ptoscano, rjones, veillard, virt-maint | |
| Target Milestone: | --- | |||
| Target Release: | --- | |||
| Hardware: | Unspecified | |||
| OS: | Unspecified | |||
| Whiteboard: | ||||
| Fixed In Version: | libguestfs-1.24.5-1.fc20 | Doc Type: | Bug Fix | |
| Doc Text: | Story Points: | --- | ||
| Clone Of: | ||||
| : | 1045069 (view as bug list) | Environment: | ||
| Last Closed: | 2014-01-30 03:38:48 UTC | Type: | Bug | |
| Regression: | --- | Mount Type: | --- | |
| Documentation: | --- | CRM: | ||
| Verified Versions: | Category: | --- | ||
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | ||
| Cloudforms Team: | --- | Target Upstream Version: | ||
| Embargoed: | ||||
| Bug Depends On: | 1045069 | |||
| Bug Blocks: | 910269 | |||
|
Description
Richard W.M. Jones
2013-12-19 13:43:34 UTC
Why is libguestfs relying on automatic probing of libvirt URIs ? This is only suitable for applications which are able to run against any libvirt virtualization driver - there's no guarantee it'll even be QEMU. Libguestfs should explicitly request qemu:///session if non-root, or qemu:///system if running as root. (In reply to Daniel Berrange from comment #1) > Why is libguestfs relying on automatic probing of libvirt URIs ? This is > only suitable for applications which are able to run against any libvirt > virtualization driver - there's no guarantee it'll even be QEMU. Libguestfs > should explicitly request qemu:///session if non-root, or qemu:///system if > running as root. Isn't qemu:///system always wrong? It has caused us a lot of trouble in the past, eg: bug 913774, bug 984409. Why can't we always specify qemu:///session? Also I'd say the documentation here: http://libvirt.org/drvqemu.html#uris doesn't reflect the reality. (But it would be nice if root had session guests). If libguestfs is running as root then there is no qemu:///session instance you can use - qemu:///system is your only choice. NB, I'm not entirely against the idea of introducing a way to use 'qemu://session' when running as root. The distinction of system vs session was motivated by the way dbus separates its system and session bus. When run as root, dbus still allows creation of a session bus for root. We've got a long historical practice where libvirtd uses getuid==0 to determine whether it runs in system vs session mode, so we'd need to some flag to force it to use session mode. We then also probably need to audit every single piece of code which looks as 'bool privileged' to see that it still makes sense when running in session mode as root. Patch posted for this bug here: https://www.redhat.com/archives/libguestfs/2013-December/msg00085.html libguestfs-1.24.5-1.fc20 has been submitted as an update for Fedora 20. https://admin.fedoraproject.org/updates/libguestfs-1.24.5-1.fc20 Package libguestfs-1.24.5-1.fc20: * should fix your issue, * was pushed to the Fedora 20 testing repository, * should be available at your local mirror within two days. Update it with: # su -c 'yum update --enablerepo=updates-testing libguestfs-1.24.5-1.fc20' as soon as you are able to. Please go to the following url: https://admin.fedoraproject.org/updates/FEDORA-2014-1262/libguestfs-1.24.5-1.fc20 then log in and leave karma (feedback). libguestfs-1.24.5-1.fc20 has been pushed to the Fedora 20 stable repository. If problems still persist, please make note of it in this bug report. |