Bug 1045214

Summary: puppet_importer can't sync from https feeds
Product: [Retired] Pulp Reporter: pgustafs
Component: puppet-supportAssignee: Randy Barlow <rbarlow>
Status: CLOSED CURRENTRELEASE QA Contact: pulp-qe-list
Severity: high Docs Contact:
Priority: medium    
Version: 2.3CC: igulina, rbarlow, skarmark
Target Milestone: ---Keywords: Triaged
Target Release: 2.4.0   
Hardware: Unspecified   
OS: Linux   
Whiteboard:
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2014-08-09 06:56:30 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Attachments:
Description Flags
/root/.pulp/server_calls.log none

Description pgustafs 2013-12-19 21:34:45 UTC
Description of problem:
puppet_importer can't sync from https feeds

Version-Release number of selected component (if applicable):
python-pulp-common-2.3.0-1.el6.noarch
python-pulp-rpm-extension-2.3.0-1.el6.noarch
pulp-rpm-admin-extensions-2.3.0-1.el6.noarch
pulp-selinux-2.3.0-1.el6.noarch
pulp-nodes-common-2.3.0-1.el6.noarch
createrepo-0.9.9-21.2.pulp.el6.noarch
pulp-server-2.3.0-1.el6.noarch
python-pulp-puppet-common-2.3.0-1.el6.noarch
python-pulp-bindings-2.3.0-1.el6.noarch
pulp-admin-client-2.3.0-1.el6.noarch
pulp-puppet-admin-extensions-2.3.0-1.el6.noarch
pulp-rpm-plugins-2.3.0-1.el6.noarch
pulp-nodes-parent-2.3.0-1.el6.noarch
python-isodate-0.5.0-1.pulp.el6.noarch
m2crypto-0.21.1.pulp-8.el6.x86_64
mod_wsgi-3.4-1.pulp.el6.x86_64
python-pulp-rpm-common-2.3.0-1.el6.noarch
python-pulp-client-lib-2.3.0-1.el6.noarch
pulp-puppet-plugins-2.3.0-1.el6.noarch
pulp-nodes-admin-extensions-2.3.0-1.el6.noarch

How reproducible:
Always


Steps to Reproduce:
1. When creating an puppet repo with an https feed i get below and the repo is not created:
{
  "exception": null,
  "args": [
    "The feed <https://test.exampple,com/pulp/puppet/puppet-repo/> is invalid"
  ],
  "_href": "/pulp/api/v2/repositories/",
  "traceback": null,
  "error_message": "The feed <https://test.exampple,com/pulp/puppet/puppet-repo> is invalid",
  "http_request_method": "POST",
  "http_status": 400
}

Additional info:
Adding https to the MAPPINGS in /usr/lib/python2.6/site-packages/pulp_puppet/plugins/importers/downloaders/factory.py fix the problem.

Br, Peter

Comment 1 Randy Barlow 2014-03-28 19:21:36 UTC
I can confirm that the suggestion above regarding the MAPPINGS structure does allow a sync to happen, but we will need to do far more than that to get this feature added to the Puppet plugins properly. We're going to need support for all of the various SSL options in both the plugins, the downloader, and the CLI.

Comment 2 Randy Barlow 2014-04-01 20:17:55 UTC
https://github.com/pulp/pulp_puppet/pull/111

Comment 3 Irina Gulina 2014-05-19 14:55:46 UTC
>>pulp-admin puppet repo create --repo-id=makaka --feed=https://forge.puppetlabs.com --queries tomcat

Successfully created repository [makaka]

>>pulp-admin puppet repo sync run --repo-id=makaka
+----------------------------------------------------------------------+
                   Synchronizing Repository [makaka]
+----------------------------------------------------------------------+

This command may be exited via ctrl+c without affecting the request.


Downloading metadata...
[==================================================] 100%
Metadata Query: 1/1 items
... completed

Downloading new modules...
[==================================================] 100%
Module: 21/21 items
... completed


Task Succeeded



Publishing modules...
[==================================================] 100%
Module: 21/21 items
... completed

Generating repository metadata...
[-]
... completed

Publishing repository over HTTP...
... completed

Publishing repository over HTTPS...
... skipped

Task Succeeded

Comment 4 Irina Gulina 2014-05-19 14:57:38 UTC
Created attachment 897206 [details]
/root/.pulp/server_calls.log

Comment 5 Randy Barlow 2014-08-09 06:56:30 UTC
This has been fixed in Pulp 2.4.0-1.