| Summary: | Improve R build | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Ulrich Drepper <drepper.fsp+rhbz> |
| Component: | R | Assignee: | Tom "spot" Callaway <tcallawa> |
| Status: | CLOSED RAWHIDE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | low | Docs Contact: | |
| Priority: | unspecified | ||
| Version: | rawhide | CC: | michel, tcallawa |
| Target Milestone: | --- | ||
| Target Release: | --- | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | Bug Fix | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2013-12-20 19:40:17 UTC | Type: | Bug |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
Sensible. Blas was disabled a long time ago because R upstream felt that using the system copy was buggy, but it seems alright to enable it now. I'll do this in rawhide only for the time being, then enable it everywhere when the next R point release lands. Thanks for the patch! Applied in R-3.0.2-2.fc21 |
Description of problem: It's very easy to get a bit more out of the existing R source by adding some more config options. First, instruct the build to use the system blas. Less duplication, possibly better implementation. Second, use LTO. This compiler feature seems stable not and it does indeed lead to small performance gains. Not too much but it's measurable. Version-Release number of selected component (if applicable): R-3.0.2-1 How reproducible: N/A Steps to Reproduce: 1.look at .spec file 2. 3. Actual results: Add the patch below. Expected results: Additional info: Use this patch: --- R.spec-save 2013-12-03 19:30:07.000000000 -0500 +++ R.spec 2013-12-03 19:53:27.000000000 -0500 @@ -303,10 +303,12 @@ ( %configure \ --with-system-zlib --with-system-bzlib --with-system-pcre \ --with-lapack \ + --with-blas \ --with-tcl-config=%{_libdir}/tclConfig.sh \ --with-tk-config=%{_libdir}/tkConfig.sh \ --enable-R-shlib \ --enable-prebuilt-html \ + --enable-lto \ rdocdir=%{?_pkgdocdir}%{!?_pkgdocdir:%{_docdir}/%{name}-%{version}} \ rincludedir=%{_includedir}/R \ rsharedir=%{_datadir}/R) \