Bug 1045309

Summary: "volfile-max-fetch-attempts" was not deprecated correctl..
Product: [Community] GlusterFS Reporter: Humble Chirammal <hchiramm>
Component: fuseAssignee: Pranith Kumar K <pkarampu>
Status: CLOSED CURRENTRELEASE QA Contact:
Severity: medium Docs Contact:
Priority: unspecified    
Version: mainlineCC: bugs, gluster-bugs, kkeithle
Target Milestone: ---   
Target Release: ---   
Hardware: x86_64   
OS: Linux   
Whiteboard:
Fixed In Version: glusterfs-3.6.0beta1 Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of:
: 1045313 (view as bug list) Environment:
Last Closed: 2014-11-11 08:25:56 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On:    
Bug Blocks: 1045313, 1061594, 1103623    

Description Humble Chirammal 2013-12-20 06:22:03 UTC 
Description of problem:

The glusterfs-fuse on earlier glusterfs version (<3.4) have 'fetch-attempts'option, how-ever 'fetch-attempts' option does not exists .

If a previous client mounted the volume with "fetch-attempts", the new version can not parse the same and it will cause the mount to fail.

Version-Release number of selected component (if applicable):

glusterfs-3.4.1


Actual results:

The mount was failed..

Expected results:

The mount options fetch-attempts should be backward compatible and mount should succeed.
Comment 1 Anand Avati 2013-12-20 06:26:02 UTC 
REVIEW: http://review.gluster.org/6544 (glusterfsd,mount correctly deprecate *fetch-attempts options) posted (#1) for review on master by Humble Devassy Chirammal (humble.devassy)
Comment 2 Anand Avati 2013-12-20 16:43:31 UTC 
REVIEW: http://review.gluster.org/6550 (tests: Add sanity check for mount-options) posted (#1) for review on master by Pranith Kumar Karampuri (pkarampu)
Comment 3 Anand Avati 2013-12-21 11:45:45 UTC 
REVIEW: http://review.gluster.org/6550 (tests: Add sanity check for mount-options) posted (#2) for review on master by Pranith Kumar Karampuri (pkarampu)
Comment 4 Anand Avati 2014-01-22 22:11:01 UTC 
REVIEW: http://review.gluster.org/6544 (mount.glusterfS/glusterfsd: Add dummy deprecated *fetch-attempts options) posted (#2) for review on master by Harshavardhana (harsha)
Comment 5 Anand Avati 2014-01-22 22:24:10 UTC 
REVIEW: http://review.gluster.org/6761 (mount.glusterfS/glusterfsd: Add dummy deprecated *fetch-attempts options) posted (#1) for review on release-3.5 by Harshavardhana (harsha)
Comment 6 Anand Avati 2014-01-29 09:55:12 UTC 
COMMIT: http://review.gluster.org/6550 committed in master by Vijay Bellur (vbellur) 
------
commit e780df78fae4f69923df20c14f15b66dc918a61b
Author: Pranith Kumar K <pkarampu>
Date:   Fri Dec 20 15:43:08 2013 +0530

    tests: Add sanity check for mount-options
    
    Change-Id: Ica246f99b8cdb6c0cf0e9143f50be056e37d3b7f
    BUG: 1045309
    Signed-off-by: Pranith Kumar K <pkarampu>
    Reviewed-on: http://review.gluster.org/6550
    Tested-by: Gluster Build System <jenkins.com>
    Reviewed-by: Vijay Bellur <vbellur>
Comment 7 Kaleb KEITHLEY 2014-01-29 18:58:46 UTC 
I have a clean checkout of the master branch on a Fedora 20 system and I  consistently get

# prove mount-options.t 
mount-options.t .. 8/90 umount: /mnt/glusterfs/0: not mounted
mount-options.t .. Failed 4/90 subtests 

Test Summary Report
-------------------
mount-options.t (Wstat: 0 Tests: 90 Failed: 4)
  Failed tests:  30-31, 54, 81
Files=1, Tests=90, 11 wallclock secs ( 0.07 usr  0.00 sys +  0.27 cusr  0.59 csys =  0.93 CPU)
Result: FAIL

or 

# prove mount-options.t 
mount-options.t .. 8/90 umount: /mnt/glusterfs/0: not mounted
mount-options.t .. Failed 3/90 subtests 

Test Summary Report
-------------------
mount-options.t (Wstat: 0 Tests: 90 Failed: 3)
  Failed tests:  30-31, 54
Files=1, Tests=90, 11 wallclock secs ( 0.06 usr  0.02 sys +  0.22 cusr  0.52 csys =  0.82 CPU)
Result: FAIL
Comment 8 Anand Avati 2014-01-30 16:58:16 UTC 
REVIEW: http://review.gluster.org/6874 (tests: Fix a regression failure) posted (#1) for review on master by Vijay Bellur (vbellur)
Comment 9 Anand Avati 2014-01-30 17:50:20 UTC 
REVIEW: http://review.gluster.org/6874 (tests: Fix regression failures) posted (#2) for review on master by Vijay Bellur (vbellur)
Comment 10 Anand Avati 2014-01-30 18:03:46 UTC 
REVIEW: http://review.gluster.org/6874 (tests: Fix regression failures) posted (#3) for review on master by Vijay Bellur (vbellur)
Comment 11 Anand Avati 2014-02-02 14:02:25 UTC 
REVIEW: http://review.gluster.org/6874 (tests: Fix regression failures) posted (#4) for review on master by Vijay Bellur (vbellur)
Comment 12 Anand Avati 2014-02-03 04:28:32 UTC 
COMMIT: http://review.gluster.org/6761 committed in release-3.5 by Vijay Bellur (vbellur) 
------
commit 1e35bfa0b4085424a7572f812c3243e233a46fda
Author: Harshavardhana <harsha>
Date:   Wed Jan 22 14:15:05 2014 -0800

    mount.glusterfS/glusterfsd: Add dummy deprecated *fetch-attempts options
    
    volfile-max-fetch-attempts and fetch-attempts were not deprecated
    properly at 'b610f1be7cd71b8f3e51c224c8b6fe0e7366c8cf'.
    
    Provide a way for backward compatibility for broken third party apps.
    
    Change-Id: I520d7bc775d67917cf149d7833a8e46bdf265d9d
    BUG: 1045309
    Signed-off-by: Harshavardhana <harsha>
    Reviewed-on: http://review.gluster.org/6761
    Tested-by: Gluster Build System <jenkins.com>
    Reviewed-by: Vijay Bellur <vbellur>
Comment 13 Anand Avati 2014-02-03 06:05:47 UTC 
REVIEW: http://review.gluster.org/6544 (mount.glusterfs/glusterfsd: Add dummy deprecated *fetch-attempts options) posted (#3) for review on master by Harshavardhana (harsha)
Comment 14 Anand Avati 2014-02-03 08:10:30 UTC 
COMMIT: http://review.gluster.org/6874 committed in master by Vijay Bellur (vbellur) 
------
commit 3395b98a341228e89cf0a88e0d86c90117dbb285
Author: Vijay Bellur <vbellur>
Date:   Thu Jan 30 22:27:24 2014 +0530

    tests: Fix regression failures
    
    Change-Id: I83dc651a5ce87adf51d1f539400cd91c801fc460
    BUG: 1045309
    Signed-off-by: Vijay Bellur <vbellur>
    Reviewed-on: http://review.gluster.org/6874
    Tested-by: Gluster Build System <jenkins.com>
    Reviewed-by: Kaushal M <kaushal>
    Reviewed-by: Pranith Kumar Karampuri <pkarampu>
Comment 15 Anand Avati 2014-02-03 10:24:40 UTC 
REVIEW: http://review.gluster.org/6544 (mount.glusterfs/glusterfsd: Add dummy deprecated *fetch-attempts options) posted (#4) for review on master by Vijay Bellur (vbellur)
Comment 16 Anand Avati 2014-02-04 01:21:29 UTC 
COMMIT: http://review.gluster.org/6544 committed in master by Anand Avati (avati) 
------
commit bbe02d77a5e7fb587787b9bbc06d28ca8419afb3
Author: Harshavardhana <harsha>
Date:   Wed Jan 22 14:08:45 2014 -0800

    mount.glusterfs/glusterfsd: Add dummy deprecated *fetch-attempts options
    
    volfile-max-fetch-attempts and fetch-attempts were not deprecated
    properly at 'b610f1be7cd71b8f3e51c224c8b6fe0e7366c8cf'.
    
    Provide a way for backward compatibility for broken third party apps.
    
    Change-Id: I597b50df08823e74691c5a20a4da4d13aab4b7ff
    BUG: 1045309
    Signed-off-by: Harshavardhana <harsha>
    Signed-off-by: Humble Chirammal <hchiramm>
    Reviewed-on: http://review.gluster.org/6544
    Reviewed-by: Humble Devassy Chirammal <humble.devassy>
    Tested-by: Gluster Build System <jenkins.com>
Comment 17 Niels de Vos 2014-09-22 12:33:59 UTC 
A beta release for GlusterFS 3.6.0 has been released. Please verify if the release solves this bug report for you. In case the glusterfs-3.6.0beta1 release does not have a resolution for this issue, leave a comment in this bug and move the status to ASSIGNED. If this release fixes the problem for you, leave a note and change the status to VERIFIED.

Packages for several distributions should become available in the near future. Keep an eye on the Gluster Users mailinglist [2] and the update (possibly an "updates-testing" repository) infrastructure for your distribution.

[1] http://supercolony.gluster.org/pipermail/gluster-users/2014-September/018836.html
[2] http://supercolony.gluster.org/pipermail/gluster-users/
Comment 18 Niels de Vos 2014-11-11 08:25:56 UTC 
This bug is getting closed because a release has been made available that should address the reported issue. In case the problem is still not fixed with glusterfs-3.6.1, please reopen this bug report.

glusterfs-3.6.1 has been announced [1], packages for several distributions should become available in the near future. Keep an eye on the Gluster Users mailinglist [2] and the update infrastructure for your distribution.

[1] http://supercolony.gluster.org/pipermail/gluster-users/2014-November/019410.html
[2] http://supercolony.gluster.org/mailman/listinfo/gluster-users