Bug 1045389

Summary:	grilo-plugins: please use SQLite prepared statements properly
Product:	Red Hat Enterprise Linux 7	Reporter:	Florian Weimer <fweimer>
Component:	grilo-plugins	Assignee:	Bastien Nocera <bnocera>
Status:	CLOSED UPSTREAM	QA Contact:	Desktop QE <desktop-qa-list>
Severity:	unspecified	Docs Contact:
Priority:	unspecified
Version:	7.0
Target Milestone:	rc
Target Release:	---
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:		Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:	953952	Environment:
Last Closed:	2014-01-07 08:11:48 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Bug Depends On:	953952
Bug Blocks:	953946

Description Florian Weimer 2013-12-20 10:20:59 UTC

+++ This bug was initially created as a clone of Bug #953952 +++

In src/podcasts/grl-podcasts.c and src/bookmarks/grl-bookmarks.c, parameter values are spliced directly into SQL statements using g_strdup_printf in some cases.  The values should be kept separate and passed to SQLite using sqlite3_bind_text.

--- Additional comment from Fedora End Of Life on 2013-09-16 15:33:38 CEST ---

This bug appears to have been reported against 'rawhide' during the Fedora 20 development cycle.
Changing version to '20'.

More information and reason for this action is here:
https://fedoraproject.org/wiki/BugZappers/HouseKeeping/Fedora20

Comment 2 Bastien Nocera 2014-01-07 08:11:48 UTC

The upstream bug report has been opened for a while:
https://bugzilla.gnome.org/show_bug.cgi?id=673912

As it's only possible for users to break their own local databases, I don't consider this a high enough risk to handle this downstream.