Bug 1045590

Summary: Unimplemented methods in org.drools.impl.adapters.KnowledgeRuntimeAdapter
Product: [Retired] JBoss BRMS Platform 6 Reporter: Lukáš Petrovický <lpetrovi>
Component: BREAssignee: Mario Fusco <mfusco>
Status: CLOSED CURRENTRELEASE QA Contact: Tomas Schlosser <tschloss>
Severity: high Docs Contact:
Priority: high    
Version: 6.0.0CC: agiertli, rrajasek, rzhang
Target Milestone: ER1   
Target Release: 6.0.1   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2014-08-06 19:59:25 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On:    
Bug Blocks: 1066969    

Description Lukáš Petrovický 2013-12-20 19:22:19 UTC
The Drools 5 legacy adapter appears to be incomplete. Code snippet taken directly from the referenced class:

    public Agenda getAgenda() {
        throw new UnsupportedOperationException("org.drools.impl.adapters.StatefulKnowledgeSessionAdapter.getAgenda -> TODO");
    }

    public WorkingMemoryEntryPoint getWorkingMemoryEntryPoint(String name) {
        throw new UnsupportedOperationException("org.drools.impl.adapters.StatefulKnowledgeSessionAdapter.getWorkingMemoryEntryPoint -> TODO");
    }

    public Collection<? extends WorkingMemoryEntryPoint> getWorkingMemoryEntryPoints() {
        throw new UnsupportedOperationException("org.drools.impl.adapters.StatefulKnowledgeSessionAdapter.getWorkingMemoryEntryPoints -> TODO");
    }

    public QueryResults getQueryResults(String query, Object... arguments) {
        throw new UnsupportedOperationException("org.drools.impl.adapters.StatefulKnowledgeSessionAdapter.getQueryResults -> TODO");
    }

    public LiveQuery openLiveQuery(String query, Object[] arguments, ViewChangedEventListener listener) {
        throw new UnsupportedOperationException("org.drools.impl.adapters.StatefulKnowledgeSessionAdapter.openLiveQuery -> TODO");
    }

Comment 2 Mario Fusco 2014-01-07 12:06:07 UTC
Fixed by https://github.com/droolsjbpm/drools/commit/6dc7605db

Comment 3 Tomas Schlosser 2014-01-24 11:41:59 UTC
This was not included in CR1, I have cecked the commits and it is included in latest sync, that will be used as CR2. I'll verify the issue again then.

Comment 4 Tomas Schlosser 2014-01-24 12:25:39 UTC
There are still 4 methods unimplemented in the KnowledgeRuntimeAdapter. Namely registerChannel() and getChannels() - ironically unregisterChannel() method is implemented.

Then there are register/unregisterExitPoint() that use deprecated ExitPoint class may not be supported any more, but there should be better message than "org.drools.impl.adapters.StatefulKnowledgeSessionAdapter.registerExitPoint -> TODO"

Comment 6 Lukáš Petrovický 2014-02-07 16:19:50 UTC
This no longer has a target release of 6.0.0.

Comment 7 Tomas Schlosser 2014-02-18 12:08:10 UTC
The code is complete and all methods implemented now.

Verified in BRMS.6.0.1.ER1