Bug 1045738

Summary:	Generic and confusing error message using a keypair name with "@" for an uploaded new ssh keypair
Product:	Red Hat OpenStack	Reporter:	Andrea Perotti <aperotti>
Component:	python-django-horizon	Assignee:	Matthias Runge <mrunge>
Status:	CLOSED ERRATA	QA Contact:	Ami Jeain <ajeain>
Severity:	medium	Docs Contact:
Priority:	medium
Version:	4.0	CC:	aortega, aperotti, apevec, dnavale, jpichon, mrunge, yeylon
Target Milestone:	z2	Keywords:	Rebase, Triaged, ZStream
Target Release:	4.0
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:	python-django-horizon-2013.2.2-1.el6ost	Doc Type:	Rebase: Bug Fixes Only
Doc Text:	With this bug fix, the following issues have been addressed. - When a user tries to name a keypair including an '@' sign, a message 'Keypair names may only contain letters, numbers, underscores and hyphens.' is displayed instead of the generic message. - Even when the Block Storage service was disabled, it was possible to create an instance with a volume, which later produced an error. This issue has now been fixed. - There were some 'required' fields that were missing the asterisk.	Story Points:	---
Clone Of:		Environment:
Last Closed:	2014-03-04 20:13:42 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Bug Depends On:	1065323
Bug Blocks:

Description Andrea Perotti 2013-12-21 16:14:28 UTC

Description of problem:
Once logged into horizon, if I go in the keypairs tab: 
https://os1-public.osop.rhcloud.com/dashboard/project/access_and_security/?tab=access_security_tabs__keypairs_tab

and try to upload a key naming it with a string containing "@" or other unusual signs, I got a generic error message.

If I try to generate a new keypair instead I got an explicit error message stating "Keypair names may only contain letters, numbers, underscores and hyphens."


Version-Release number of selected component (if applicable):
Not able to provide it, since I experienced in the openstack instance hosted here: https://os1-public.osop.rhcloud.com

How reproducible:
Always


Steps to Reproduce:
see below

Actual results:
Generic error message trying to label a imported key with string containing @

Expected results:
An explicit message as when I try to choose a label of that kind in the create keypair.

Comment 2 Matthias Runge 2014-01-06 10:45:46 UTC

the patch was merged for icehouse-2, the backport for Havana is here:

https://review.openstack.org/#/c/65059/

Comment 3 Alan Pevec 2014-01-27 13:11:09 UTC

This will be included in the 2013.2.2 rebase.

Comment 4 Matthias Runge 2014-02-17 08:13:56 UTC

This is how to test:
before this update, when trying to add a keypair with an '@' sign in the name, one would get a generic error, with this update, the message is more specific like '... may only contain letters and numbers'.

Comment 6 Ami Jeain 2014-02-23 10:21:58 UTC

verified while trying to add invalid characters into the keypair name...
# rpm -qa |grep horizon
python-django-horizon-2013.2.2-1.el6ost.noarch

Comment 8 errata-xmlrpc 2014-03-04 20:13:42 UTC

Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

http://rhn.redhat.com/errata/RHBA-2014-0213.html