Bug 1045868

Summary:	ibus-chewing again not built with $RPM_OPT_FLAGS
Product:	[Fedora] Fedora	Reporter:	Ville Skyttä <ville.skytta>
Component:	ibus-chewing	Assignee:	Ding-Yi Chen <dchen>
Status:	CLOSED ERRATA	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	high	Docs Contact:
Priority:	medium
Version:	20	CC:	dchen, i18n-bugs, mfabian, petersen, shawn.p.huang
Target Milestone:	---	Keywords:	Regression
Target Release:	---
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:	No remaining need info.	Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2014-02-28 06:55:51 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:
Bug Blocks:	496968

Description Ville Skyttä 2013-12-22 16:52:16 UTC

Ding-Yi, looks like your last update to ibus-chewing 1.4.4-1 simply threw away my changes to fix bug 842856, the patch was removed and the package is now again built without $RPM_OPT_FLAGS even if the changelog claims otherwise:

http://pkgs.fedoraproject.org/cgit/ibus-chewing.git/commit/?id=9d2384f6a18e24003de5a6561a3381eb2017ef37

Why is that, and why was it done so that it also threw away the change logs?

If you're upstream for this package, please consider applying the patch I submitted so it won't get lost in the future; in CMakeLists.txt, replace:
    SET(CMAKE_C_FLAGS "-Wall")
...with:
    SET(CMAKE_C_FLAGS "${CMAKE_C_FLAGS} -Wall")
...so that user set CFLAGS are honored and not overwritten by simply -Wall.

Comment 1 Fedora Update System 2014-01-15 14:39:12 UTC

ibus-chewing-1.4.5-1.fc20 has been submitted as an update for Fedora 20.
https://admin.fedoraproject.org/updates/ibus-chewing-1.4.5-1.fc20

Comment 2 Fedora Update System 2014-01-16 07:00:11 UTC

ibus-chewing-1.4.6-1.fc19 has been submitted as an update for Fedora 19.
https://admin.fedoraproject.org/updates/ibus-chewing-1.4.6-1.fc19

Comment 3 Fedora Update System 2014-01-16 07:00:56 UTC

ibus-chewing-1.4.6-1.fc20 has been submitted as an update for Fedora 20.
https://admin.fedoraproject.org/updates/ibus-chewing-1.4.6-1.fc20

Comment 4 Fedora Update System 2014-02-01 06:02:55 UTC

ibus-chewing-1.4.10.1-1.fc19 has been submitted as an update for Fedora 19.
https://admin.fedoraproject.org/updates/ibus-chewing-1.4.10.1-1.fc19

Comment 5 Fedora Update System 2014-02-01 06:03:21 UTC

ibus-chewing-1.4.10.1-1.fc20 has been submitted as an update for Fedora 20.
https://admin.fedoraproject.org/updates/ibus-chewing-1.4.10.1-1.fc20

Comment 6 Fedora Update System 2014-02-11 23:10:11 UTC

ibus-chewing-1.4.10.1-1.fc20 has been pushed to the Fedora 20 stable repository.  If problems still persist, please make note of it in this bug report.

Comment 7 Fedora Update System 2014-02-22 18:15:00 UTC

ibus-chewing-1.4.10.1-1.fc19 has been pushed to the Fedora 19 stable repository.  If problems still persist, please make note of it in this bug report.